Complex classes like Donation often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Donation, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 15 | class Donation { |
||
| 16 | |||
| 17 | /** |
||
| 18 | * @var integer |
||
| 19 | * |
||
| 20 | * @ORM\Column(name="id", type="integer") |
||
| 21 | * @ORM\Id |
||
| 22 | * @ORM\GeneratedValue(strategy="IDENTITY") |
||
| 23 | */ |
||
| 24 | private $id; |
||
| 25 | |||
| 26 | /** |
||
| 27 | * @var string |
||
| 28 | * |
||
| 29 | * @ORM\Column(name="status", type="string", length=1, options={"default":"N", "fixed":true}, nullable=false) |
||
| 30 | */ |
||
| 31 | private $status = 'N'; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @var string |
||
| 35 | * |
||
| 36 | * @ORM\Column(name="name", type="string", length=250, nullable=true) |
||
| 37 | */ |
||
| 38 | private $donorFullName; |
||
| 39 | |||
| 40 | /** |
||
| 41 | * @var string |
||
| 42 | * |
||
| 43 | * @ORM\Column(name="ort", type="string", length=250, nullable=true) |
||
| 44 | */ |
||
| 45 | private $donorCity; |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @var string |
||
| 49 | * |
||
| 50 | * @ORM\Column(name="email", type="string", length=250, nullable=true) |
||
| 51 | */ |
||
| 52 | private $donorEmail; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * @var boolean |
||
| 56 | * |
||
| 57 | * @ORM\Column(name="info", type="boolean", options={"default":0}, nullable=false) |
||
| 58 | */ |
||
| 59 | private $donorOptsIntoNewsletter = 0; |
||
| 60 | |||
| 61 | /** |
||
| 62 | * @var boolean |
||
| 63 | * |
||
| 64 | * @ORM\Column(name="bescheinigung", type="boolean", nullable=true) |
||
| 65 | */ |
||
| 66 | private $donationReceipt; |
||
| 67 | |||
| 68 | /** |
||
| 69 | * @var string |
||
| 70 | * |
||
| 71 | * @ORM\Column(name="eintrag", type="string", length=250, options={"default":""}, nullable=false) |
||
| 72 | */ |
||
| 73 | private $publicRecord = ''; |
||
| 74 | |||
| 75 | /** |
||
| 76 | * @var string |
||
| 77 | * |
||
| 78 | * @ORM\Column(name="betrag", type="string", length=250, nullable=true) |
||
| 79 | */ |
||
| 80 | private $amount; |
||
| 81 | |||
| 82 | /** |
||
| 83 | * @var integer |
||
| 84 | * |
||
| 85 | * @ORM\Column(name="periode", type="smallint", options={"default":0}, nullable=false) |
||
| 86 | */ |
||
| 87 | private $paymentIntervalInMonths = 0; |
||
| 88 | |||
| 89 | /** |
||
| 90 | * @var string |
||
| 91 | * |
||
| 92 | * @ORM\Column(name="zahlweise", type="string", length=3, options={"default":"BEZ", "fixed":true}, nullable=false) |
||
| 93 | */ |
||
| 94 | private $paymentType = 'BEZ'; |
||
| 95 | |||
| 96 | /** |
||
| 97 | * @var string |
||
| 98 | * |
||
| 99 | * @ORM\Column(name="kommentar", type="text", options={"default":""}, nullable=false) |
||
| 100 | */ |
||
| 101 | private $comment = ''; |
||
| 102 | |||
| 103 | /** |
||
| 104 | * @var string |
||
| 105 | * |
||
| 106 | * @ORM\Column(name="ueb_code", type="string", length=32, options={"default":""}, nullable=false) |
||
| 107 | */ |
||
| 108 | private $bankTransferCode = ''; |
||
| 109 | |||
| 110 | /** |
||
| 111 | * @var string |
||
| 112 | * |
||
| 113 | * @ORM\Column(name="data", type="text", nullable=true) |
||
| 114 | */ |
||
| 115 | private $data; |
||
| 116 | |||
| 117 | /** |
||
| 118 | * @var string |
||
| 119 | * |
||
| 120 | * @ORM\Column(name="source", type="string", length=250, nullable=true) |
||
| 121 | */ |
||
| 122 | private $source; |
||
| 123 | |||
| 124 | /** |
||
| 125 | * @var string |
||
| 126 | * |
||
| 127 | * @ORM\Column(name="remote_addr", type="string", length=250, options={"default":""}, nullable=false) |
||
| 128 | */ |
||
| 129 | private $remoteAddr = ''; |
||
| 130 | |||
| 131 | /** |
||
| 132 | * @var string |
||
| 133 | * |
||
| 134 | * @ORM\Column(name="hash", type="string", length=250, nullable=true) |
||
| 135 | */ |
||
| 136 | private $hash; |
||
| 137 | |||
| 138 | /** |
||
| 139 | * @var boolean |
||
| 140 | * |
||
| 141 | * @ORM\Column(name="is_public", type="boolean", options={"default":0}, nullable=false) |
||
| 142 | */ |
||
| 143 | private $isPublic = 0; |
||
| 144 | |||
| 145 | /** |
||
| 146 | * @var \DateTime |
||
| 147 | * |
||
| 148 | * @Gedmo\Timestampable(on="create") |
||
| 149 | * @ORM\Column(name="dt_new", type="datetime") |
||
| 150 | */ |
||
| 151 | private $creationTime; |
||
| 152 | |||
| 153 | /** |
||
| 154 | * @var \DateTime |
||
| 155 | * |
||
| 156 | * @ORM\Column(name="dt_del", type="datetime", nullable=true) |
||
| 157 | */ |
||
| 158 | private $deletionTime; |
||
| 159 | |||
| 160 | /** |
||
| 161 | * @var \DateTime |
||
| 162 | * |
||
| 163 | * @ORM\Column(name="dt_exp", type="datetime", nullable=true) |
||
| 164 | */ |
||
| 165 | private $dtExp; |
||
| 166 | |||
| 167 | /** |
||
| 168 | * @var \DateTime |
||
| 169 | * |
||
| 170 | * @ORM\Column(name="dt_gruen", type="datetime", nullable=true) |
||
| 171 | */ |
||
| 172 | private $dtGruen; |
||
| 173 | |||
| 174 | /** |
||
| 175 | * @var \DateTime |
||
| 176 | * |
||
| 177 | * @ORM\Column(name="dt_backup", type="datetime", nullable=true) |
||
| 178 | */ |
||
| 179 | private $dtBackup; |
||
| 180 | |||
| 181 | /** |
||
| 182 | * @param string $donorFullName |
||
| 183 | * |
||
| 184 | * @return self |
||
| 185 | */ |
||
| 186 | public function setDonorFullName( $donorFullName ) { |
||
| 191 | |||
| 192 | /** |
||
| 193 | * @return string |
||
| 194 | */ |
||
| 195 | public function getDonorFullName() { |
||
| 198 | |||
| 199 | /** |
||
| 200 | * @param string $donorCity |
||
| 201 | * |
||
| 202 | * @return self |
||
| 203 | */ |
||
| 204 | public function setDonorCity( $donorCity ) { |
||
| 209 | |||
| 210 | /** |
||
| 211 | * @return string |
||
| 212 | */ |
||
| 213 | public function getDonorCity() { |
||
| 216 | |||
| 217 | /** |
||
| 218 | * @param string $donorEmail |
||
| 219 | * |
||
| 220 | * @return self |
||
| 221 | */ |
||
| 222 | public function setDonorEmail( $donorEmail ) { |
||
| 227 | |||
| 228 | /** |
||
| 229 | * @return string |
||
| 230 | */ |
||
| 231 | public function getDonorEmail() { |
||
| 234 | |||
| 235 | /** |
||
| 236 | * @param boolean $donorOptsIntoNewsletter |
||
| 237 | * |
||
| 238 | * @return self |
||
| 239 | */ |
||
| 240 | public function setDonorOptsIntoNewsletter( $donorOptsIntoNewsletter ) { |
||
| 245 | |||
| 246 | /** |
||
| 247 | * @return boolean |
||
| 248 | */ |
||
| 249 | public function getDonorOptsIntoNewsletter() { |
||
| 252 | |||
| 253 | /** |
||
| 254 | * Set donation receipt state |
||
| 255 | * |
||
| 256 | * @param boolean $donationReceipt |
||
| 257 | * @return self |
||
| 258 | */ |
||
| 259 | public function setDonationReceipt( $donationReceipt ) { |
||
| 264 | |||
| 265 | /** |
||
| 266 | * Get donation receipt state |
||
| 267 | * |
||
| 268 | * @return boolean |
||
| 269 | */ |
||
| 270 | public function getDonationReceipt() { |
||
| 273 | |||
| 274 | /** |
||
| 275 | * Set publicly displayed donation record |
||
| 276 | * |
||
| 277 | * @param string $publicRecord |
||
| 278 | * @return self |
||
| 279 | */ |
||
| 280 | public function setPublicRecord( $publicRecord ) { |
||
| 285 | |||
| 286 | /** |
||
| 287 | * Get publicly displayed donation record |
||
| 288 | * |
||
| 289 | * @return string |
||
| 290 | */ |
||
| 291 | public function getPublicRecord() { |
||
| 294 | |||
| 295 | /** |
||
| 296 | * @param string $amount |
||
| 297 | * @return self |
||
| 298 | */ |
||
| 299 | public function setAmount( $amount ) { |
||
| 304 | |||
| 305 | /** |
||
| 306 | * @return string |
||
| 307 | */ |
||
| 308 | public function getAmount() { |
||
| 311 | |||
| 312 | /** |
||
| 313 | * @param integer $paymentIntervalInMonths |
||
| 314 | * |
||
| 315 | * @return self |
||
| 316 | */ |
||
| 317 | public function setPaymentIntervalInMonths( $paymentIntervalInMonths ) { |
||
| 322 | |||
| 323 | /** |
||
| 324 | * @return integer |
||
| 325 | */ |
||
| 326 | public function getPaymentIntervalInMonths() { |
||
| 329 | |||
| 330 | /** |
||
| 331 | * Set payment type short code |
||
| 332 | * |
||
| 333 | * @param string $paymentType |
||
| 334 | * @return self |
||
| 335 | */ |
||
| 336 | public function setPaymentType( $paymentType ) { |
||
| 341 | |||
| 342 | /** |
||
| 343 | * Get payment type short code |
||
| 344 | * |
||
| 345 | * @return string |
||
| 346 | */ |
||
| 347 | public function getPaymentType() { |
||
| 350 | |||
| 351 | /** |
||
| 352 | * @param string $comment |
||
| 353 | * @return self |
||
| 354 | */ |
||
| 355 | public function setComment( $comment ) { |
||
| 360 | |||
| 361 | /** |
||
| 362 | * @return string |
||
| 363 | */ |
||
| 364 | public function getComment() { |
||
| 367 | |||
| 368 | /** |
||
| 369 | * Set bank transfer reference code |
||
| 370 | * |
||
| 371 | * @param string $bankTransferCode |
||
| 372 | * |
||
| 373 | * @return self |
||
| 374 | */ |
||
| 375 | public function setBankTransferCode( $bankTransferCode ) { |
||
| 380 | |||
| 381 | /** |
||
| 382 | * Get bank transfer reference code |
||
| 383 | * |
||
| 384 | * @return string |
||
| 385 | */ |
||
| 386 | public function getBankTransferCode() { |
||
| 389 | |||
| 390 | /** |
||
| 391 | * @param string $source |
||
| 392 | * @return self |
||
| 393 | */ |
||
| 394 | public function setSource( $source ) { |
||
| 399 | |||
| 400 | /** |
||
| 401 | * @return string |
||
| 402 | */ |
||
| 403 | public function getSource() { |
||
| 406 | |||
| 407 | /** |
||
| 408 | * @param string $remoteAddr |
||
| 409 | * @return self |
||
| 410 | */ |
||
| 411 | public function setRemoteAddr( $remoteAddr ) { |
||
| 416 | |||
| 417 | /** |
||
| 418 | * @return string |
||
| 419 | */ |
||
| 420 | public function getRemoteAddr() { |
||
| 423 | |||
| 424 | /** |
||
| 425 | * @param string $hash |
||
| 426 | * @return self |
||
| 427 | */ |
||
| 428 | public function setHash( $hash ) { |
||
| 433 | |||
| 434 | /** |
||
| 435 | * @return string |
||
| 436 | */ |
||
| 437 | public function getHash() { |
||
| 440 | |||
| 441 | /** |
||
| 442 | * @param boolean $isPublic |
||
| 443 | * @return self |
||
| 444 | */ |
||
| 445 | public function setIsPublic( $isPublic ) { |
||
| 450 | |||
| 451 | /** |
||
| 452 | * @return boolean |
||
| 453 | */ |
||
| 454 | public function getIsPublic() { |
||
| 457 | |||
| 458 | /** |
||
| 459 | * @param \DateTime $creationTime |
||
| 460 | * |
||
| 461 | * @return self |
||
| 462 | */ |
||
| 463 | public function setCreationTime( $creationTime ) { |
||
| 468 | |||
| 469 | /** |
||
| 470 | * @return \DateTime |
||
| 471 | */ |
||
| 472 | public function getCreationTime() { |
||
| 475 | |||
| 476 | /** |
||
| 477 | * @param \DateTime|null $deletionTime |
||
| 478 | * |
||
| 479 | * @return self |
||
| 480 | */ |
||
| 481 | public function setDeletionTime( $deletionTime ) { |
||
| 486 | |||
| 487 | /** |
||
| 488 | * @return \DateTime|null |
||
| 489 | */ |
||
| 490 | public function getDeletionTime() { |
||
| 493 | |||
| 494 | /** |
||
| 495 | * @param \DateTime $dtExp |
||
| 496 | * @return self |
||
| 497 | */ |
||
| 498 | public function setDtExp( $dtExp ) { |
||
| 503 | |||
| 504 | /** |
||
| 505 | * @return \DateTime |
||
| 506 | */ |
||
| 507 | public function getDtExp() { |
||
| 510 | |||
| 511 | /** |
||
| 512 | * @param string $status |
||
| 513 | * @return self |
||
| 514 | */ |
||
| 515 | public function setStatus( $status ) { |
||
| 520 | |||
| 521 | /** |
||
| 522 | * @return string |
||
| 523 | */ |
||
| 524 | public function getStatus() { |
||
| 527 | |||
| 528 | /** |
||
| 529 | * @param \DateTime $dtGruen |
||
| 530 | * @return self |
||
| 531 | */ |
||
| 532 | public function setDtGruen( $dtGruen ) { |
||
| 537 | |||
| 538 | /** |
||
| 539 | * @return \DateTime |
||
| 540 | */ |
||
| 541 | public function getDtGruen() { |
||
| 544 | |||
| 545 | /** |
||
| 546 | * @param \DateTime $dtBackup |
||
| 547 | * @return self |
||
| 548 | */ |
||
| 549 | public function setDtBackup( $dtBackup ) { |
||
| 554 | |||
| 555 | /** |
||
| 556 | * @return \DateTime |
||
| 557 | */ |
||
| 558 | public function getDtBackup() { |
||
| 561 | |||
| 562 | /** |
||
| 563 | * @return integer|null |
||
| 564 | */ |
||
| 565 | public function getId() { |
||
| 568 | |||
| 569 | /** |
||
| 570 | * @since 2.0 |
||
| 571 | * |
||
| 572 | * @param integer|null $id |
||
| 573 | */ |
||
| 574 | public function setId( $id ) { |
||
| 577 | |||
| 578 | public function getUExpiry() { |
||
| 581 | |||
| 582 | public function uTokenIsExpired() { |
||
| 585 | |||
| 586 | public function validateToken( $tokenToCheck, $serverSecret ) { |
||
| 595 | |||
| 596 | public function getEntryType( $mode = null ) { |
||
| 618 | |||
| 619 | /** |
||
| 620 | * @deprecated since 2.0, use encodeAndSetData or setDataObject instead |
||
| 621 | * |
||
| 622 | * @param string $data Base 64 encoded, serialized PHP array |
||
| 623 | * @return self |
||
| 624 | */ |
||
| 625 | public function setData( $data ) { |
||
| 630 | |||
| 631 | /** |
||
| 632 | * @deprecated since 2.0, use @see getDecodedData or @see getDataObject instead |
||
| 633 | * |
||
| 634 | * @return string Base 64 encoded, serialized PHP array |
||
| 635 | */ |
||
| 636 | public function getData() { |
||
| 639 | |||
| 640 | /** |
||
| 641 | * NOTE: if possible, use @see getDataObject instead, as it provides a nicer API. |
||
| 642 | * |
||
| 643 | * @since 2.0 |
||
| 644 | * @return array |
||
| 645 | */ |
||
| 646 | public function getDecodedData() { |
||
| 651 | |||
| 652 | /** |
||
| 653 | * NOTE: if possible, use @see modifyDataObject instead, as it provides a nicer API. |
||
| 654 | * |
||
| 655 | * @since 2.0 |
||
| 656 | * @param array $data |
||
| 657 | */ |
||
| 658 | public function encodeAndSetData( array $data ) { |
||
| 661 | |||
| 662 | /** |
||
| 663 | * WARNING: updates made to the return value will not be reflected in the Donation state. |
||
| 664 | * Similarly, updates to the Donation state will not propagate to the returned object. |
||
| 665 | * To update the Donation state, explicitly call @see setDataObject. |
||
| 666 | * |
||
| 667 | * @since 2.0 |
||
| 668 | * @return DonationData |
||
| 669 | */ |
||
| 670 | public function getDataObject() { |
||
| 681 | |||
| 682 | /** |
||
| 683 | * @since 2.0 |
||
| 684 | * @param DonationData $data |
||
| 685 | */ |
||
| 686 | public function setDataObject( DonationData $data ) { |
||
| 704 | |||
| 705 | /** |
||
| 706 | * @since 2.0 |
||
| 707 | * @param callable $modificationFunction Takes a modifiable DonationData parameter |
||
| 708 | */ |
||
| 709 | public function modifyDataObject( callable $modificationFunction ) { |
||
| 714 | |||
| 715 | } |
||
| 716 |