MembershipApplicationInsertionTest::testMembershipApplicationCanBeLoaded() - Code Metrics - Inspection of "[WIP] T177416 Opt out of donation receipt - member..." - wmde/FundraisingStore - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#143)

by wiese

created 2017-10-25 09:45 UTC

testMembershipApplicationCanBeLoaded() A

↳ Parent: MembershipApplicationInsertionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	0

<?php

declare( strict_types = 1 );

namespace WMDE\Fundraising\Store\Tests;

use PHPUnit\Framework\TestCase;
use WMDE\Fundraising\Entities\MembershipApplication;

/**
 * @covers \WMDE\Fundraising\Entities\MembershipApplication
 */
class MembershipApplicationInsertionTest extends TestCase {

	public function testNewMembershipApplicationCanBeInserted(): void {
		$entityManager = TestEnvironment::newDefault()->getFactory()->getEntityManager();
		$entityManager->persist( new MembershipApplication() );
		$entityManager->flush();

		$count = $entityManager->createQueryBuilder()
			->select( 'COUNT(r.id)' )
			->from( MembershipApplication::class, 'r' )
			->getQuery()
			->getSingleScalarResult();

		$this->assertSame( '1', $count );
	}

	public function testMembershipApplicationCanBeLoaded(): void {
		$entityManager = TestEnvironment::newDefault()->getFactory()->getEntityManager();

		$application = new MembershipApplication();
		$application->setDonationReceipt( true );

		$entityManager->persist( $application );
		$entityManager->flush();

		/**
		 * @var MembershipApplication $application
		 */
		$application = $entityManager->getRepository( MembershipApplication::class )->find( $application->getId() );

		$this->assertTrue( $application->getDonationReceipt() );

	}
}


1			<?php
2
3			declare( strict_types = 1 );
4
5			namespace WMDE\Fundraising\Store\Tests;
6
7			use PHPUnit\Framework\TestCase;
8			use WMDE\Fundraising\Entities\MembershipApplication;
9
10			/**
11			* @covers \WMDE\Fundraising\Entities\MembershipApplication
12			*/
13			class MembershipApplicationInsertionTest extends TestCase {
14
15			public function testNewMembershipApplicationCanBeInserted(): void {
16			$entityManager = TestEnvironment::newDefault()->getFactory()->getEntityManager();
17			$entityManager->persist( new MembershipApplication() );
18			$entityManager->flush();
19
20			$count = $entityManager->createQueryBuilder()
21			->select( 'COUNT(r.id)' )
22			->from( MembershipApplication::class, 'r' )
23			->getQuery()
24			->getSingleScalarResult();
25
26			$this->assertSame( '1', $count );
27			}
28
29			public function testMembershipApplicationCanBeLoaded(): void {
30			$entityManager = TestEnvironment::newDefault()->getFactory()->getEntityManager();
31
32			$application = new MembershipApplication();
33			$application->setDonationReceipt( true );
34
35			$entityManager->persist( $application );
36			$entityManager->flush();
37
38			/**
39			* @var MembershipApplication $application
40			*/
41			$application = $entityManager->getRepository( MembershipApplication::class )->find( $application->getId() );
42
43			$this->assertTrue( $application->getDonationReceipt() );
			0 ignored issues – show Bug introduced 2017-10-25 09:49 UTC by Report Bug Copy Issue Report It seems like `$application->getDonationReceipt()` targeting `WMDE\Fundraising\Entitie...n::getDonationReceipt()` can also be of type `null`; however, `PHPUnit\Framework\Assert::assertTrue()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
44			}
45			}
46

wmde / FundraisingStore

Pull Request — master (#143)

testMembershipApplicationCanBeLoaded() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like