WMDE\Fundraising\Frontend\BucketTesting\Logging\StreamLogWriter

Complexity

Total Complexity

10

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Test Coverage

Coverage

96.3%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	createPathIfNeeded()	0	7	3
A	__construct()	0	2	1
A	__destruct()	0	3	2
A	write()	0	5	1
A	openStreamIfNeeded()	0	8	3

<?php

declare( strict_types = 1 );

namespace WMDE\Fundraising\Frontend\BucketTesting\Logging;

/**
 * Writes log entries to a file stream, one per line
 */
class StreamLogWriter implements LogWriter {

	private $url;
	private $stream;

	public function __construct( string $url ) {
		$this->url = $url;
	}

	/**
	 * @param string $logEntry
	 * @throws LoggingError
	 */
	public function write( string $logEntry ) {
		$this->openStreamIfNeeded();
		fwrite(
			$this->stream,
			$logEntry . "\n"
		);
	}

	private function openStreamIfNeeded() {
		if ( $this->stream !== null ) {
			return;
		}
		$this->createPathIfNeeded();
		$this->stream = @fopen( $this->url, 'a' );
		if ( $this->stream === false ) {
			throw new LoggingError( 'Could not open ' . $this->url );
		}
	}

	private function createPathIfNeeded() {
		$path = dirname( $this->url );
		if ( file_exists( $path ) ) {
			return;
		}
		if ( !mkdir( $path, 0777, true ) ) {
			throw new LoggingError( 'Could not create directory ' . $path );
		}
	}

	public function __destruct() {
		if ( is_resource( $this->stream ) ) {
			@fclose( $this->stream );

It seems like you do not handle an error condition for fclose(). This can introduce security issues, and is generally not recommended.

		}
	}

}