ChoiceFactory::getMembershipCallToActionTemplate() - Code Metrics - Inspection of "Clear old A/B Tests" - wmde/FundraisingFrontend - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#2157)

unknown

created 2021-04-01 10:24 UTC

ChoiceFactory::getMembershipCallToActionTemplate() A

↳ Parent: ChoiceFactory

Complexity

Conditions	3
Paths	3

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3.3332

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	3
nop	0
dl	0
loc	7
ccs	4
cts	6
cp	0.6667
crap	3.3332
rs	10
c	0
b	0
f	0

<?php

declare( strict_types = 1 );

namespace WMDE\Fundraising\Frontend\Factories;

use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use WMDE\Euro\Euro;
use WMDE\Fundraising\Frontend\BucketTesting\FeatureToggle;
use WMDE\Fundraising\Frontend\Infrastructure\UrlGenerator;

/**
 * Factory for generating classes whose implementations differ due to A/B testing.
 *
 * @license GPL-2.0-or-later
 */
class ChoiceFactory {

	private $featureToggle;

	public function __construct( FeatureToggle $featureToggle ) {
		$this->featureToggle = $featureToggle;
	}

	public function getAddressType(): ?string {
		if ( $this->featureToggle->featureIsActive( 'campaigns.address_type.no_preselection' ) ) {
			return null;
		} elseif ( $this->featureToggle->featureIsActive( 'campaigns.address_type.preselection' ) ) {
			return 'person';
		}
		throw new UnknownChoiceDefinition( 'Address type configuration failure.' );
	}
}


1		<?php
2
3		declare( strict_types = 1 );
4
5		namespace WMDE\Fundraising\Frontend\Factories;
6
7		use Symfony\Component\HttpFoundation\RedirectResponse;
8		use Symfony\Component\HttpFoundation\Request;
9		use WMDE\Euro\Euro;
10		use WMDE\Fundraising\Frontend\BucketTesting\FeatureToggle;
11		use WMDE\Fundraising\Frontend\Infrastructure\UrlGenerator;
12
13		/**
14		* Factory for generating classes whose implementations differ due to A/B testing.
15		*
16		* @license GPL-2.0-or-later
17		*/
18		class ChoiceFactory {
19
20	100	private $featureToggle;
21	100
22	100	public function __construct( FeatureToggle $featureToggle ) {
23		$this->featureToggle = $featureToggle;
24	14	}
25
26	14	public function getAddressType(): ?string {
27	10	if ( $this->featureToggle->featureIsActive( 'campaigns.address_type.no_preselection' ) ) {
28		return null;
29	4	} elseif ( $this->featureToggle->featureIsActive( 'campaigns.address_type.preselection' ) ) {
30	4	return 'person';
31		}
32		throw new UnknownChoiceDefinition( 'Address type configuration failure.' );
33		}
34		}
35

wmde / FundraisingFrontend

Pull Request — master (#2157)

ChoiceFactory::getMembershipCallToActionTemplate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like