AddDonationValidatorTest - Code Metrics - Inspection of "Move tests to where they belong" - wmde/FundraisingFrontend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#649)

by Jeroen De

created 2016-09-09 08:46 UTC

AddDonationValidatorTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	175
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes

Metric	Value
wmc	14
c	0
b	0
f	0
lcom	1
cbo	12
dl	0
loc	175
rs	10

14 Methods

Rating	Name	Size	Complexity
A	setUp()	3	1
A	testGivenValidDonation_validationIsSuccessful()	4	1
A	testGivenAnonymousDonorAndEmptyAddressFields_validatorReturnsNoViolations()	17	1
A	testGivenNoPaymentType_validatorReturnsFalse()	11	1
A	testGivenUnsupportedPaymentType_validatorReturnsFalse()	11	1
A	testPersonalInfoValidationFails_validatorReturnsFalse()	12	1
A	testDirectDebitMissingBankData_validatorReturnsFalse()	15	1
A	testAmountTooLow_validatorReturnsFalse()	9	1
B	testPersonalInfoWithLongFields_validationFails()	26	1
A	testBankDataWithLongFields_validationFails()	20	1
A	testLongSource_validationFails()	9	1
A	newDonationValidator()	7	1
A	newBankDataValidator()	7	1
A	newMockEmailValidator()	5	1

<?php

declare( strict_types = 1 );

namespace WMDE\Fundraising\Frontend\DonatingContext\Tests\Integration\UseCases\AddDonation;

use WMDE\Euro\Euro;
use WMDE\Fundraising\Frontend\DonatingContext\Domain\Model\DonorName;
use WMDE\Fundraising\Frontend\DonatingContext\UseCases\AddDonation\AddDonationValidationResult;
use WMDE\Fundraising\Frontend\DonatingContext\UseCases\AddDonation\AddDonationValidator;
use WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\BankData;
use WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\Iban;
use WMDE\Fundraising\Frontend\Tests\Data\ValidAddDonationRequest;
use WMDE\Fundraising\Frontend\Tests\Unit\Validation\ValidatorTestCase;
use WMDE\Fundraising\Frontend\Validation\PaymentDataValidator;
use WMDE\Fundraising\Frontend\Validation\BankDataValidator;
use WMDE\Fundraising\Frontend\Validation\EmailValidator;
use WMDE\Fundraising\Frontend\Validation\IbanValidator;
use WMDE\Fundraising\Frontend\Validation\ValidationResult;

/**
 * @covers WMDE\Fundraising\Frontend\DonatingContext\UseCases\AddDonation\AddDonationValidator
 *
 * @licence GNU GPL v2+
 * @author Kai Nissen < [email protected] >
 * @author Gabriel Birke < [email protected] >
 */
class AddDonationValidatorTest extends ValidatorTestCase {

	/** @var AddDonationValidator */
	private $donationValidator;

	public function setUp() {
		$this->donationValidator = $this->newDonationValidator();
	}

	public function testGivenValidDonation_validationIsSuccessful() {
		$request = ValidAddDonationRequest::getRequest();
		$this->assertEmpty( $this->donationValidator->validate( $request )->getViolations() );
	}

	public function testGivenAnonymousDonorAndEmptyAddressFields_validatorReturnsNoViolations() {
		$request = ValidAddDonationRequest::getRequest();

		$request->setDonorType( DonorName::PERSON_ANONYMOUS );
		$request->setDonorSalutation( '' );
		$request->setDonorTitle( '' );
		$request->setDonorCompany( '' );
		$request->setDonorFirstName( '' );
		$request->setDonorLastName( '' );
		$request->setDonorStreetAddress( '' );
		$request->setDonorPostalCode( '' );
		$request->setDonorCity( '' );
		$request->setDonorCountryCode( '' );
		$request->setDonorEmailAddress( '' );

		$this->assertEmpty( $this->donationValidator->validate( $request )->getViolations() );
	}

	public function testGivenNoPaymentType_validatorReturnsFalse() {
		$request = ValidAddDonationRequest::getRequest();
		$request->setPaymentType( '' );

		$this->assertFalse( $this->donationValidator->validate( $request )->isSuccessful() );

		$this->assertConstraintWasViolated(
			$this->donationValidator->validate( $request ),
			AddDonationValidationResult::SOURCE_PAYMENT_TYPE
		);
	}

	public function testGivenUnsupportedPaymentType_validatorReturnsFalse() {
		$request = ValidAddDonationRequest::getRequest();
		$request->setPaymentType( 'KaiCoin' );

		$this->assertFalse( $this->donationValidator->validate( $request )->isSuccessful() );

		$this->assertConstraintWasViolated(
			$this->donationValidator->validate( $request ),
			AddDonationValidationResult::SOURCE_PAYMENT_TYPE
		);
	}

	public function testPersonalInfoValidationFails_validatorReturnsFalse() {
		$request = ValidAddDonationRequest::getRequest();
		$request->setDonorType( DonorName::PERSON_COMPANY );
		$request->setDonorCompany( '' );

		$this->assertFalse( $this->donationValidator->validate( $request )->isSuccessful() );

		$this->assertConstraintWasViolated(
			$this->donationValidator->validate( $request ),
			AddDonationValidationResult::SOURCE_DONOR_COMPANY
		);
	}

	public function testDirectDebitMissingBankData_validatorReturnsFalse() {
		$bankData = new BankData();
		$bankData->setIban( new Iban( '' ) );
		$bankData->setBic( '' );
		$bankData->setBankName( '' );
		$request = ValidAddDonationRequest::getRequest();
		$request->setBankData( $bankData );

		$result = $this->donationValidator->validate( $request );
		$this->assertFalse( $result->isSuccessful() );

		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_IBAN );
		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_BIC );
		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_BANK_NAME );
	}

	public function testAmountTooLow_validatorReturnsFalse() {
		$request = ValidAddDonationRequest::getRequest();
		$request->setAmount( Euro::newFromCents( 50 ) );

		$result = $this->donationValidator->validate( $request );
		$this->assertFalse( $result->isSuccessful() );

		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_PAYMENT_AMOUNT );
	}

	public function testPersonalInfoWithLongFields_validationFails() {
		$longText = str_repeat( 'Cats ', 500 );
		$request = ValidAddDonationRequest::getRequest();
		$request->setDonorFirstName( $longText );
		$request->setDonorLastName( $longText );
		$request->setDonorTitle( $longText );
		$request->setDonorSalutation( $longText );
		$request->setDonorStreetAddress( $longText );
		$request->setDonorPostalCode( $longText );
		$request->setDonorCity( $longText );
		$request->setDonorCountryCode( $longText );
		$request->setDonorEmailAddress( str_repeat( 'Cats', 500 ) . '@example.com' );

		$result = $this->donationValidator->validate( $request );
		$this->assertFalse( $result->isSuccessful() );

		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_FIRST_NAME );
		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_LAST_NAME );
		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_SALUTATION );
		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_TITLE );
		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_STREET_ADDRESS );
		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_CITY );
		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_POSTAL_CODE );
		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_COUNTRY );
		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_EMAIL );
	}

	public function testBankDataWithLongFields_validationFails() {
		$longText = str_repeat( 'Cats ', 500 );
		$request = ValidAddDonationRequest::getRequest();
		$validBankData = $request->getBankData();
		$bankData = new BankData();
		$bankData->setBic( $longText );
		$bankData->setBankName( $longText );
		// Other length violations will be caught by IBAN validation
		$bankData->setIban( $validBankData->getIban() );
		$bankData->setAccount( $validBankData->getAccount() );
		$bankData->setBankCode( $validBankData->getBankCode() );
		$bankData->freeze();
		$request->setBankData( $bankData );

		$result = $this->donationValidator->validate( $request );
		$this->assertFalse( $result->isSuccessful() );

		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_BANK_NAME );
		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_BIC );
	}

	public function testLongSource_validationFails() {
		$request = ValidAddDonationRequest::getRequest();
		$request->setSource( 'http://catlady.com/#' . str_repeat( 'Cats ', 500 ) );

		$result = $this->donationValidator->validate( $request );
		$this->assertFalse( $result->isSuccessful() );

		$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_TRACKING_SOURCE );
	}

	private function newDonationValidator(): AddDonationValidator {
		return new AddDonationValidator(
			new PaymentDataValidator( 1.0, 100000 ),
			$this->newBankDataValidator(),
			$this->newMockEmailValidator()
		);
	}

	private function newBankDataValidator(): BankDataValidator {
		$ibanValidatorMock = $this->getMockBuilder( IbanValidator::class )->disableOriginalConstructor()->getMock();
		$ibanValidatorMock->method( 'validate' )
			->willReturn( new ValidationResult() );

		return new BankDataValidator( $ibanValidatorMock );
	}

	private function newMockEmailValidator() {
		$validator = $this->getMockBuilder( EmailValidator::class )->disableOriginalConstructor()->getMock();
		$validator->method( 'validate' )->willReturn( new ValidationResult() );
		return $validator;
	}
}


1			<?php
2
3			declare( strict_types = 1 );
4
5			namespace WMDE\Fundraising\Frontend\DonatingContext\Tests\Integration\UseCases\AddDonation;
6
7			use WMDE\Euro\Euro;
8			use WMDE\Fundraising\Frontend\DonatingContext\Domain\Model\DonorName;
9			use WMDE\Fundraising\Frontend\DonatingContext\UseCases\AddDonation\AddDonationValidationResult;
10			use WMDE\Fundraising\Frontend\DonatingContext\UseCases\AddDonation\AddDonationValidator;
11			use WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\BankData;
12			use WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\Iban;
13			use WMDE\Fundraising\Frontend\Tests\Data\ValidAddDonationRequest;
14			use WMDE\Fundraising\Frontend\Tests\Unit\Validation\ValidatorTestCase;
15			use WMDE\Fundraising\Frontend\Validation\PaymentDataValidator;
16			use WMDE\Fundraising\Frontend\Validation\BankDataValidator;
17			use WMDE\Fundraising\Frontend\Validation\EmailValidator;
18			use WMDE\Fundraising\Frontend\Validation\IbanValidator;
19			use WMDE\Fundraising\Frontend\Validation\ValidationResult;
20
21			/**
22			* @covers WMDE\Fundraising\Frontend\DonatingContext\UseCases\AddDonation\AddDonationValidator
23			*
24			* @licence GNU GPL v2+
25			* @author Kai Nissen < [email protected] >
26			* @author Gabriel Birke < [email protected] >
27			*/
28			class AddDonationValidatorTest extends ValidatorTestCase {
29
30			/** @var AddDonationValidator */
31			private $donationValidator;
32
33			public function setUp() {
34			$this->donationValidator = $this->newDonationValidator();
35			}
36
37			public function testGivenValidDonation_validationIsSuccessful() {
38			$request = ValidAddDonationRequest::getRequest();
39			$this->assertEmpty( $this->donationValidator->validate( $request )->getViolations() );
40			}
41
42			public function testGivenAnonymousDonorAndEmptyAddressFields_validatorReturnsNoViolations() {
43			$request = ValidAddDonationRequest::getRequest();
44
45			$request->setDonorType( DonorName::PERSON_ANONYMOUS );
46			$request->setDonorSalutation( '' );
47			$request->setDonorTitle( '' );
48			$request->setDonorCompany( '' );
49			$request->setDonorFirstName( '' );
50			$request->setDonorLastName( '' );
51			$request->setDonorStreetAddress( '' );
52			$request->setDonorPostalCode( '' );
53			$request->setDonorCity( '' );
54			$request->setDonorCountryCode( '' );
55			$request->setDonorEmailAddress( '' );
56
57			$this->assertEmpty( $this->donationValidator->validate( $request )->getViolations() );
58			}
59
60			public function testGivenNoPaymentType_validatorReturnsFalse() {
61			$request = ValidAddDonationRequest::getRequest();
62			$request->setPaymentType( '' );
63
64			$this->assertFalse( $this->donationValidator->validate( $request )->isSuccessful() );
65
66			$this->assertConstraintWasViolated(
67			$this->donationValidator->validate( $request ),
68			AddDonationValidationResult::SOURCE_PAYMENT_TYPE
69			);
70			}
71
72			public function testGivenUnsupportedPaymentType_validatorReturnsFalse() {
73			$request = ValidAddDonationRequest::getRequest();
74			$request->setPaymentType( 'KaiCoin' );
75
76			$this->assertFalse( $this->donationValidator->validate( $request )->isSuccessful() );
77
78			$this->assertConstraintWasViolated(
79			$this->donationValidator->validate( $request ),
80			AddDonationValidationResult::SOURCE_PAYMENT_TYPE
81			);
82			}
83
84			public function testPersonalInfoValidationFails_validatorReturnsFalse() {
85			$request = ValidAddDonationRequest::getRequest();
86			$request->setDonorType( DonorName::PERSON_COMPANY );
87			$request->setDonorCompany( '' );
88
89			$this->assertFalse( $this->donationValidator->validate( $request )->isSuccessful() );
90
91			$this->assertConstraintWasViolated(
92			$this->donationValidator->validate( $request ),
93			AddDonationValidationResult::SOURCE_DONOR_COMPANY
94			);
95			}
96
97			public function testDirectDebitMissingBankData_validatorReturnsFalse() {
98			$bankData = new BankData();
99			$bankData->setIban( new Iban( '' ) );
100			$bankData->setBic( '' );
101			$bankData->setBankName( '' );
102			$request = ValidAddDonationRequest::getRequest();
103			$request->setBankData( $bankData );
104
105			$result = $this->donationValidator->validate( $request );
106			$this->assertFalse( $result->isSuccessful() );
107
108			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_IBAN );
109			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_BIC );
110			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_BANK_NAME );
111			}
112
113			public function testAmountTooLow_validatorReturnsFalse() {
114			$request = ValidAddDonationRequest::getRequest();
115			$request->setAmount( Euro::newFromCents( 50 ) );
116
117			$result = $this->donationValidator->validate( $request );
118			$this->assertFalse( $result->isSuccessful() );
119
120			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_PAYMENT_AMOUNT );
121			}
122
123			public function testPersonalInfoWithLongFields_validationFails() {
124			$longText = str_repeat( 'Cats ', 500 );
125			$request = ValidAddDonationRequest::getRequest();
126			$request->setDonorFirstName( $longText );
127			$request->setDonorLastName( $longText );
128			$request->setDonorTitle( $longText );
129			$request->setDonorSalutation( $longText );
130			$request->setDonorStreetAddress( $longText );
131			$request->setDonorPostalCode( $longText );
132			$request->setDonorCity( $longText );
133			$request->setDonorCountryCode( $longText );
134			$request->setDonorEmailAddress( str_repeat( 'Cats', 500 ) . '@example.com' );
135
136			$result = $this->donationValidator->validate( $request );
137			$this->assertFalse( $result->isSuccessful() );
138
139			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_FIRST_NAME );
140			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_LAST_NAME );
141			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_SALUTATION );
142			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_TITLE );
143			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_STREET_ADDRESS );
144			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_CITY );
145			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_POSTAL_CODE );
146			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_COUNTRY );
147			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_DONOR_EMAIL );
148			}
149
150			public function testBankDataWithLongFields_validationFails() {
151			$longText = str_repeat( 'Cats ', 500 );
152			$request = ValidAddDonationRequest::getRequest();
153			$validBankData = $request->getBankData();
154			$bankData = new BankData();
155			$bankData->setBic( $longText );
156			$bankData->setBankName( $longText );
157			// Other length violations will be caught by IBAN validation
158			$bankData->setIban( $validBankData->getIban() );
159			$bankData->setAccount( $validBankData->getAccount() );
160			$bankData->setBankCode( $validBankData->getBankCode() );
161			$bankData->freeze();
162			$request->setBankData( $bankData );
163
164			$result = $this->donationValidator->validate( $request );
165			$this->assertFalse( $result->isSuccessful() );
166
167			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_BANK_NAME );
168			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_BIC );
169			}
170
171			public function testLongSource_validationFails() {
172			$request = ValidAddDonationRequest::getRequest();
173			$request->setSource( 'http://catlady.com/#' . str_repeat( 'Cats ', 500 ) );
174
175			$result = $this->donationValidator->validate( $request );
176			$this->assertFalse( $result->isSuccessful() );
177
178			$this->assertConstraintWasViolated( $result, AddDonationValidationResult::SOURCE_TRACKING_SOURCE );
179			}
180
181			private function newDonationValidator(): AddDonationValidator {
182			return new AddDonationValidator(
183			new PaymentDataValidator( 1.0, 100000 ),
184			$this->newBankDataValidator(),
185			$this->newMockEmailValidator()
186			);
187			}
188
189			private function newBankDataValidator(): BankDataValidator {
190			$ibanValidatorMock = $this->getMockBuilder( IbanValidator::class )->disableOriginalConstructor()->getMock();
191			$ibanValidatorMock->method( 'validate' )
192			->willReturn( new ValidationResult() );
193
194			return new BankDataValidator( $ibanValidatorMock );
195			}
196
197			private function newMockEmailValidator() {
198			$validator = $this->getMockBuilder( EmailValidator::class )->disableOriginalConstructor()->getMock();
199			$validator->method( 'validate' )->willReturn( new ValidationResult() );
200			return $validator;
201			}
202			}
203

wmde / FundraisingFrontend

Pull Request — master (#649)

AddDonationValidatorTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

Duplication Side-by-Side

Filter issues like