HandlePayPalPaymentNotificationUseCaseTest::testWhenAuthorizationSucceedsForAnonymousDonation_confirmationMailIsNot() - Code Metrics - Inspection of "Merge pull request #620 from wmde/add-license" - wmde/FundraisingFrontend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 26b6e4...03f4f4 )

by Jeroen De

created 2016-08-05 12:48 UTC

testWhenAuthorizationSucceedsForAnonymousDonation_confirmationMailIsNot() A

↳ Parent: HandlePayPalPaymentNotificationUseCaseTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	20
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	15
nc	1
nop	0
dl	0
loc	20
rs	9.4285
c	0
b	0
f	0

<?php

declare( strict_types = 1 );

namespace WMDE\Fundraising\Frontend\Tests\Integration\UseCases\HandlePayPalPaymentNotification;

use Psr\Log\NullLogger;
use WMDE\Fundraising\Frontend\DonatingContext\DataAccess\DoctrineDonationRepository;
use WMDE\Fundraising\Frontend\DonatingContext\Domain\Model\Donation;
use WMDE\Fundraising\Frontend\DonatingContext\Domain\Model\DonorName;
use WMDE\Fundraising\Frontend\DonatingContext\Infrastructure\DonationConfirmationMailer;
use WMDE\Fundraising\Frontend\DonatingContext\Infrastructure\DonationEventLogger;
use WMDE\Fundraising\Frontend\DonatingContext\UseCases\HandlePayPalPaymentNotification\HandlePayPalPaymentNotificationUseCase;
use WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\PayPalData;
use WMDE\Fundraising\Frontend\Tests\Data\ValidDonation;
use WMDE\Fundraising\Frontend\Tests\Data\ValidPayPalNotificationRequest;
use WMDE\Fundraising\Frontend\Tests\Fixtures\DonationEventLoggerSpy;
use WMDE\Fundraising\Frontend\Tests\Fixtures\DonationRepositorySpy;
use WMDE\Fundraising\Frontend\Tests\Fixtures\FailingDonationAuthorizer;
use WMDE\Fundraising\Frontend\Tests\Fixtures\FakeDonationRepository;
use WMDE\Fundraising\Frontend\Tests\Fixtures\LoggerSpy;
use WMDE\Fundraising\Frontend\Tests\Fixtures\SucceedingDonationAuthorizer;
use WMDE\Fundraising\Frontend\Tests\Fixtures\ThrowingEntityManager;

/**
 * @covers WMDE\Fundraising\Frontend\DonatingContext\UseCases\HandlePayPalPaymentNotification\HandlePayPalPaymentNotificationUseCase
 *
 * @licence GNU GPL v2+
 * @author Kai Nissen < [email protected] >
 * @author Gabriel Birke < [email protected] >
 */
class HandlePayPalPaymentNotificationUseCaseTest extends \PHPUnit_Framework_TestCase {

	public function testWhenRepositoryThrowsException_handlerReturnsFalse() {
		$useCase = new HandlePayPalPaymentNotificationUseCase(
			new DoctrineDonationRepository( ThrowingEntityManager::newInstance( $this ) ),
			new FailingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$this->getEventLogger()

		);
		$request = ValidPayPalNotificationRequest::newInstantPaymentForDonation( 1 );
		$this->assertFalse( $useCase->handleNotification( $request ) );
	}

	public function testWhenAuthorizationFails_handlerReturnsFalse() {
		$fakeRepository = new FakeDonationRepository();
		$fakeRepository->storeDonation( ValidDonation::newIncompletePayPalDonation() );

		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$fakeRepository,
			new FailingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$this->getEventLogger()

		);

		$request = ValidPayPalNotificationRequest::newInstantPaymentForDonation( 1 );
		$this->assertFalse( $useCase->handleNotification( $request ) );
	}

	public function testWhenAuthorizationSucceeds_handlerReturnsTrue() {
		$fakeRepository = new FakeDonationRepository();
		$fakeRepository->storeDonation( ValidDonation::newIncompletePayPalDonation() );

		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$fakeRepository,
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$this->getEventLogger()

		);

		$request = ValidPayPalNotificationRequest::newInstantPaymentForDonation( 1 );
		$this->assertTrue( $useCase->handleNotification( $request ) );
	}

	public function testWhenPaymentTypeIsNonPayPal_handlerReturnsFalse() {
		$fakeRepository = new FakeDonationRepository();
		$fakeRepository->storeDonation( ValidDonation::newDirectDebitDonation() );

		$request = ValidPayPalNotificationRequest::newInstantPaymentForDonation( 1 );
		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$fakeRepository,
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$this->getEventLogger()

		);

		$this->assertFalse( $useCase->handleNotification( $request ) );
	}

	public function testWhenPaymentStatusIsPending_handlerReturnsFalse() {
		$request = ValidPayPalNotificationRequest::newPendingPayment();

		$useCase = new HandlePayPalPaymentNotificationUseCase(
			new FakeDonationRepository(),
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$this->getEventLogger()

		);

		$this->assertFalse( $useCase->handleNotification( $request ) );
	}

	public function testWhenPaymentStatusIsPending_handlerLogsStatus() {
		$logger = new LoggerSpy();

		$request = $request = ValidPayPalNotificationRequest::newPendingPayment();

		$useCase = new HandlePayPalPaymentNotificationUseCase(
			new FakeDonationRepository(),
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			$logger,
			$this->getEventLogger()

		);

		$useCase->handleNotification( $request );

		$logger->assertCalledOnceWithMessage( 'Unhandled PayPal notification: Pending', $this );
	}

	public function testWhenTransactionTypeIsForSubscriptionChanges_handlerReturnsFalse() {
		$request = ValidPayPalNotificationRequest::newSubscriptionModification();

		$useCase = new HandlePayPalPaymentNotificationUseCase(
			new FakeDonationRepository(),
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$this->getEventLogger()

		);
		$this->assertFalse( $useCase->handleNotification( $request ) );
	}

	public function testWhenTransactionTypeIsForSubscriptionChanges_handlerLogsStatus() {
		$logger = new LoggerSpy();

		$useCase = new HandlePayPalPaymentNotificationUseCase(
			new FakeDonationRepository(),
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			$logger,
			$this->getEventLogger()

		);

		$request = ValidPayPalNotificationRequest::newSubscriptionModification();

		$useCase->handleNotification( $request );

		$logger->assertCalledOnceWithMessage( 'Unhandled PayPal subscription notification: subscr_modify', $this );
	}

	public function testWhenAuthorizationSucceeds_confirmationMailIsSent() {
		$donation = ValidDonation::newIncompletePayPalDonation();
		$fakeRepository = new FakeDonationRepository();
		$fakeRepository->storeDonation( $donation );

		$mailer = $this->getMailer();
		$mailer->expects( $this->once() )
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
			->method( 'sendConfirmationMailFor' );
			// TODO: assert that the correct values are passed to the mailer

		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$fakeRepository,
			new SucceedingDonationAuthorizer(),
			$mailer,
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			new NullLogger(),
			$this->getEventLogger()

		);

		$request = ValidPayPalNotificationRequest::newInstantPaymentForDonation( 1 );
		$this->assertTrue( $useCase->handleNotification( $request ) );
	}

	public function testWhenAuthorizationSucceedsForAnonymousDonation_confirmationMailIsNotSent() {
		$donation = ValidDonation::newIncompleteAnonymousPayPalDonation();
		$fakeRepository = new FakeDonationRepository();
		$fakeRepository->storeDonation( $donation );

		$mailer = $this->getMailer();
		$mailer->expects( $this->never() )
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
			->method( 'sendConfirmationMailFor' );

		$request = ValidPayPalNotificationRequest::newInstantPaymentForDonation( 1 );
		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$fakeRepository,
			new SucceedingDonationAuthorizer(),
			$mailer,
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			new NullLogger(),
			$this->getEventLogger()

		);

		$this->assertTrue( $useCase->handleNotification( $request ) );
	}

	public function testWhenAuthorizationSucceeds_donationIsStored() {
		$donation = ValidDonation::newIncompletePayPalDonation();
		$repositorySpy = new DonationRepositorySpy( $donation );

		$request = ValidPayPalNotificationRequest::newInstantPaymentForDonation( 1 );
		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$repositorySpy,
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$this->getEventLogger()

		);

		$this->assertTrue( $useCase->handleNotification( $request ) );
		$this->assertCount( 1, $repositorySpy->getStoreDonationCalls() );
	}

	public function testWhenAuthorizationSucceeds_donationIsBooked() {
		$donation = ValidDonation::newIncompletePayPalDonation();
		$repository = new FakeDonationRepository( $donation );

		$request = ValidPayPalNotificationRequest::newInstantPaymentForDonation( 1 );
		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$repository,
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$this->getEventLogger()

		);

		$this->assertTrue( $useCase->handleNotification( $request ) );
		$this->assertTrue( $repository->getDonationById( $donation->getId() )->isBooked() );
	}

	public function testWhenAuthorizationSucceeds_bookingEventIsLogged() {
		$donation = ValidDonation::newIncompletePayPalDonation();
		$repositorySpy = new DonationRepositorySpy( $donation );

		$eventLogger = new DonationEventLoggerSpy();

		$request = ValidPayPalNotificationRequest::newInstantPaymentForDonation( 1 );
		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$repositorySpy,
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$eventLogger
		);

		$this->assertTrue( $useCase->handleNotification( $request ) );

		$this->assertEventLogContainsExpression( $eventLogger, $donation->getId(), '/booked/' );
	}

	public function testWhenSendingConfirmationMailFails_handlerReturnsTrue() {
		$fakeRepository = new FakeDonationRepository();
		$fakeRepository->storeDonation( ValidDonation::newIncompletePayPalDonation() );

		$mailer = $this->getMailer();
		$mailer->expects( $this->once() )
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
			->method( 'sendConfirmationMailFor' )
			->willThrowException( new \RuntimeException( 'Oh noes!' ) );

		$request = ValidPayPalNotificationRequest::newInstantPaymentForDonation( 1 );
		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$fakeRepository,
			new SucceedingDonationAuthorizer(),
			$mailer,
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			new NullLogger(),
			$this->getEventLogger()

		);

		$this->assertTrue( $useCase->handleNotification( $request ) );
	}

	public function testGivenNewTransactionIdForBookedDonation_transactionIdShowsUpInChildPayments() {
		$donation = ValidDonation::newBookedPayPalDonation();
		$transactionId = '16R12136PU8783961';

		$fakeRepository = new FakeDonationRepository();
		$fakeRepository->storeDonation( $donation );

		$request = ValidPayPalNotificationRequest::newDuplicatePaymentForDonation( $donation->getId(), $transactionId );

		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$fakeRepository,
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$this->getEventLogger()

		);

		$this->assertTrue( $useCase->handleNotification( $request ) );

		/** @var \WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\PayPalPayment $payment */
		$payment = $fakeRepository->getDonationById( $donation->getId() )->getPaymentMethod();

		$this->assertTrue(
			$payment->getPayPalData()->hasChildPayment( $transactionId ),
			'Parent payment must have new transaction ID in its list'
		);
	}

	public function testGivenNewTransactionIdForBookedDonation_childTransactionWithSameDataIsCreated() {
		$donation = ValidDonation::newBookedPayPalDonation();
		$transactionId = '16R12136PU8783961';

		$fakeRepository = new FakeDonationRepository();
		$fakeRepository->storeDonation( $donation );

		$request = ValidPayPalNotificationRequest::newDuplicatePaymentForDonation( $donation->getId(), $transactionId );

		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$fakeRepository,
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$this->getEventLogger()

		);

		$this->assertTrue( $useCase->handleNotification( $request ) );

		$donation = $fakeRepository->getDonationById( $donation->getId() );
		/** @var \WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\PayPalPayment $payment */
		$payment = $donation->getPaymentMethod();
		$childDonation = $fakeRepository->getDonationById( $payment->getPayPalData()->getChildPaymentEntityId( $transactionId ) );
		$this->assertNotNull( $childDonation );
		/** @var \WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\PayPalPayment $childDonationPaymentMethod */
		$childDonationPaymentMethod = $childDonation->getPaymentMethod();
		$this->assertEquals( $transactionId, $childDonationPaymentMethod->getPayPalData()->getPaymentId() );
		$this->assertEquals( $donation->getAmount(), $childDonation->getAmount() );
		$this->assertEquals( $donation->getDonor(), $childDonation->getDonor() );
		$this->assertEquals( $donation->getPaymentIntervalInMonths(), $childDonation->getPaymentIntervalInMonths() );
		$this->assertTrue( $childDonation->isBooked() );
	}

	public function testGivenNewTransactionIdForBookedDonation_childCreationeventIsLogged() {
		$donation = ValidDonation::newBookedPayPalDonation();
		$transactionId = '16R12136PU8783961';

		$fakeRepository = new FakeDonationRepository();
		$fakeRepository->storeDonation( $donation );

		$request = ValidPayPalNotificationRequest::newDuplicatePaymentForDonation( $donation->getId(), $transactionId );

		$eventLogger = new DonationEventLoggerSpy();

		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$fakeRepository,
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$eventLogger
		);

		$this->assertTrue( $useCase->handleNotification( $request ) );

		$donation = $fakeRepository->getDonationById( $donation->getId() );
		/** @var \WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\PayPalPayment $payment */
		$payment = $donation->getPaymentMethod();
		$childDonationId = $payment->getPayPalData()->getChildPaymentEntityId( $transactionId );

		$this->assertEventLogContainsExpression( $eventLogger, $donation->getId(), '/child donation.*' . $childDonationId .'/' );
		$this->assertEventLogContainsExpression( $eventLogger, $childDonationId, '/parent donation.*' . $donation->getId() .'/' );
	}

	public function testGivenExistingTransactionIdForBookedDonation_handlerReturnsFalse() {
		$fakeRepository = new FakeDonationRepository();
		$fakeRepository->storeDonation( ValidDonation::newBookedPayPalDonation() );

		$request = ValidPayPalNotificationRequest::newInstantPaymentForDonation( 1 );

		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$fakeRepository,
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$this->getEventLogger()

		);

		$this->assertFalse( $useCase->handleNotification( $request ) );
	}

	public function testGivenTransactionIdInBookedChildDonation_noNewDonationIsCreated() {
		$transactionId = '16R12136PU8783961';
		$fakeChildEntityId = 2;
		$donation = ValidDonation::newBookedPayPalDonation();
		$donation->getPaymentMethod()->getPaypalData()->addChildPayment( $transactionId, $fakeChildEntityId );
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

		$fakeRepository = new FakeDonationRepository();
		$fakeRepository->storeDonation( $donation );

		$request = ValidPayPalNotificationRequest::newDuplicatePaymentForDonation( $donation->getId(), $transactionId );

		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$fakeRepository,
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$this->getEventLogger()

		);

		$this->assertFalse( $useCase->handleNotification( $request ) );
	}

	public function testWhenNotificationIsForNonExistingDonation_newDonationIsCreated() {
		$repositorySpy = new DonationRepositorySpy();

		$request = ValidPayPalNotificationRequest::newInstantPaymentForDonation( 12345 );
		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$repositorySpy,
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$this->getEventLogger()

		);

		$useCase->handleNotification( $request );

		$storeDonationCalls = $repositorySpy->getStoreDonationCalls();
		$this->assertCount( 1, $storeDonationCalls, 'Donation is stored' );
		$this->assertNull( $storeDonationCalls[0]->getId(), 'ID is not taken from request' );
		$this->assertDonationIsCreatedWithNotficationRequestData( $storeDonationCalls[0] );
	}

	public function testGivenRecurringPaymentForBookedDonation_newDonationIsCreated() {
		$donation = ValidDonation::newBookedPayPalDonation();
		$repositorySpy = new DonationRepositorySpy( $donation );

		$request = ValidPayPalNotificationRequest::newRecurringPayment( $donation->getId() );

		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$repositorySpy,
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$this->getEventLogger()

		);

		$useCase->handleNotification( $request );

		$this->assertCount( 1, $repositorySpy->getStoreDonationCalls() );
		/** @var \WMDE\Fundraising\Frontend\DonatingContext\Domain\Model\Donation $newDonation */
		$newDonation = $repositorySpy->getStoreDonationCalls()[0];
		$this->assertNotEquals( $donation, $newDonation );

		$this->assertDonationIsCreatedWithNotficationRequestData( $newDonation );
	}

	public function testGivenRecurringPaymentForIncompleteDonation_donationIsBooked() {
		$donation = ValidDonation::newIncompletePayPalDonation();
		$repositorySpy = new DonationRepositorySpy( $donation );

		$request = ValidPayPalNotificationRequest::newRecurringPayment( $donation->getId() );

		$useCase = new HandlePayPalPaymentNotificationUseCase(
			$repositorySpy,
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$this->getEventLogger()

		);

		$useCase->handleNotification( $request );
		$donation = $repositorySpy->getDonationById( $donation->getId() );

		$this->assertCount( 1, $repositorySpy->getStoreDonationCalls() );
		$this->assertEquals( $donation, $repositorySpy->getStoreDonationCalls()[0] );
		$this->assertTrue( $donation->isBooked() );
	}

	public function testWhenNotificationIsForNonExistingDonation_confirmationMailIsSent() {
		$request = ValidPayPalNotificationRequest::newInstantPaymentForDonation( 12345 );
		$mailer = $this->getMailer();
		$mailer->expects( $this->once() )
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
			->method( 'sendConfirmationMailFor' )
			->with( $this->anything() );
		$useCase = new HandlePayPalPaymentNotificationUseCase(
			new FakeDonationRepository(),
			new SucceedingDonationAuthorizer(),
			$mailer,
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			new NullLogger(),
			$this->getEventLogger()

		);

		$useCase->handleNotification( $request );
	}

	public function testWhenNotificationIsForNonExistingDonation_bookingEventIsLogged() {
		$request = ValidPayPalNotificationRequest::newInstantPaymentForDonation( 12345 );
		$eventLogger = new DonationEventLoggerSpy();

		$useCase = new HandlePayPalPaymentNotificationUseCase(
			new FakeDonationRepository(),
			new SucceedingDonationAuthorizer(),
			$this->getMailer(),

			new NullLogger(),
			$eventLogger
		);

		$useCase->handleNotification( $request );

		$this->assertEventLogContainsExpression( $eventLogger, 1, '/booked/' ); // 1 is the generated donation id
	}

	private function assertDonationIsCreatedWithNotficationRequestData( Donation $donation ) {
		$this->assertSame( 0, $donation->getPaymentIntervalInMonths(), 'Payment interval is always empty' );
		$this->assertTrue( $donation->isBooked() );

		$donorName = $donation->getDonor()->getName();
		$this->assertSame( DonorName::PERSON_PRIVATE, $donorName->getPersonType(), 'Person is always private' );
		$this->assertSame( ValidPayPalNotificationRequest::PAYER_ADDRESS_NAME, $donorName->getFullName() );

		$this->assertSame( ValidPayPalNotificationRequest::PAYER_EMAIL, $donation->getDonor()->getEmailAddress() );

		$address = $donation->getDonor()->getPhysicalAddress();
		$this->assertSame( ValidPayPalNotificationRequest::PAYER_ADDRESS_STREET, $address->getStreetAddress() );
		$this->assertSame( ValidPayPalNotificationRequest::PAYER_ADDRESS_CITY, $address->getCity() );
		$this->assertSame( ValidPayPalNotificationRequest::PAYER_ADDRESS_POSTAL_CODE, $address->getPostalCode() );
		$this->assertSame( ValidPayPalNotificationRequest::PAYER_ADDRESS_COUNTRY_CODE, $address->getCountryCode() );

		$payment = $donation->getPayment();
		$this->assertSame( ValidPayPalNotificationRequest::AMOUNT_GROSS_CENTS, $payment->getAmount()->getEuroCents() );

		/** @var PayPalData $paypalData */
		$paypalData = $payment->getPaymentMethod()->getPaypalData();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
		$this->assertSame( ValidPayPalNotificationRequest::PAYER_ADDRESS_NAME, $paypalData->getAddressName() );
	}

	private function assertEventLogContainsExpression( DonationEventLoggerSpy $eventLoggerSpy, int $donationId, string $expr ) {
		$foundCalls = array_filter( $eventLoggerSpy->getLogCalls(), function( $call ) use ( $donationId, $expr ) {
			return $call[0] == $donationId && preg_match( $expr, $call[1] );
		} );
		$assertMsg = 'Failed to assert that donation event log log contained "' . $expr . '" for donation id '.$donationId;
		$this->assertCount( 1, $foundCalls, $assertMsg );
	}

	/**
	 * @return DonationConfirmationMailer|\PHPUnit_Framework_MockObject_MockObject
	 */
	private function getMailer(): DonationConfirmationMailer {
		return $this->getMockBuilder( DonationConfirmationMailer::class )->disableOriginalConstructor()->getMock();
	}

	/**
	 * @return DonationEventLogger|\PHPUnit_Framework_MockObject_MockObject
	 */
	private function getEventLogger(): DonationEventLogger {
		return $this->createMock( DonationEventLogger::class );
	}

}


Push — master ( 26b6e4...03f4f4 )

testWhenAuthorizationSucceedsForAnonymousDonation_confirmationMailIsNot() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			declare( strict_types = 1 );
4
5			namespace WMDE\Fundraising\Frontend\Tests\Integration\UseCases\HandlePayPalPaymentNotification;
6
7			use Psr\Log\NullLogger;
8			use WMDE\Fundraising\Frontend\DonatingContext\DataAccess\DoctrineDonationRepository;
9			use WMDE\Fundraising\Frontend\DonatingContext\Domain\Model\Donation;
10			use WMDE\Fundraising\Frontend\DonatingContext\Domain\Model\DonorName;
11			use WMDE\Fundraising\Frontend\DonatingContext\Infrastructure\DonationConfirmationMailer;
12			use WMDE\Fundraising\Frontend\DonatingContext\Infrastructure\DonationEventLogger;
13			use WMDE\Fundraising\Frontend\DonatingContext\UseCases\HandlePayPalPaymentNotification\HandlePayPalPaymentNotificationUseCase;
14			use WMDE\Fundraising\Frontend\PaymentContext\Domain\Model\PayPalData;
15			use WMDE\Fundraising\Frontend\Tests\Data\ValidDonation;
16			use WMDE\Fundraising\Frontend\Tests\Data\ValidPayPalNotificationRequest;
17			use WMDE\Fundraising\Frontend\Tests\Fixtures\DonationEventLoggerSpy;
18			use WMDE\Fundraising\Frontend\Tests\Fixtures\DonationRepositorySpy;
19			use WMDE\Fundraising\Frontend\Tests\Fixtures\FailingDonationAuthorizer;
20			use WMDE\Fundraising\Frontend\Tests\Fixtures\FakeDonationRepository;
21			use WMDE\Fundraising\Frontend\Tests\Fixtures\LoggerSpy;
22			use WMDE\Fundraising\Frontend\Tests\Fixtures\SucceedingDonationAuthorizer;
23			use WMDE\Fundraising\Frontend\Tests\Fixtures\ThrowingEntityManager;
24
25			/**
26			* @covers WMDE\Fundraising\Frontend\DonatingContext\UseCases\HandlePayPalPaymentNotification\HandlePayPalPaymentNotificationUseCase
27			*
28			* @licence GNU GPL v2+
29			* @author Kai Nissen < [email protected] >
30			* @author Gabriel Birke < [email protected] >
31			*/
32			class HandlePayPalPaymentNotificationUseCaseTest extends \PHPUnit_Framework_TestCase {
33
34			public function testWhenRepositoryThrowsException_handlerReturnsFalse() {
35			$useCase = new HandlePayPalPaymentNotificationUseCase(
36			new DoctrineDonationRepository( ThrowingEntityManager::newInstance( $this ) ),
37			new FailingDonationAuthorizer(),
38			$this->getMailer(),
			0 ignored issues – show Bug introduced 2016-08-05 09:41 UTC by Report Bug Copy Issue Report It seems like `$this->getMailer()` targeting `WMDE\Fundraising\Fronten...seCaseTest::getMailer()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `WMDE\Fundraising\Fronten...nUseCase::__construct()` does only seem to accept `object<WMDE\Fundraising\...tionConfirmationMailer>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
39			new NullLogger(),

wmde / FundraisingFrontend

Push — master ( 26b6e4...03f4f4 )

testWhenAuthorizationSucceedsForAnonymousDonation_confirmationMailIsNot() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like