CallbackComparer::valuesAreEqual() - Code Metrics - Inspection of "Added scalar and return type hints" - wmde/Diff - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — php70 ( e501b7...c1737a )

by Jeroen De

created 2017-03-07 07:00 UTC

CallbackComparer::valuesAreEqual() A

↳ Parent: CallbackComparer

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2.032

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	4
cts	5
cp	0.8
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	2
crap	2.032

<?php

namespace Diff\Comparer;

/**
 * Adapter around a comparison callback that implements the ValueComparer
 * interface.
 *
 * @since 0.6
 *
 * @license GPL-2.0+
 * @author Jeroen De Dauw < [email protected] >
 */
class CallbackComparer implements ValueComparer {

	private $callback;

	/**
	 * @since 0.6
	 *
	 * @param callable $callback
	 */
	public function __construct( $callback ) {
		$this->callback = $callback;
	}

	public function valuesAreEqual( $firstValue, $secondValue ): bool {
		$valuesAreEqual = call_user_func_array( $this->callback, array( $firstValue, $secondValue ) );

		if ( !is_bool( $valuesAreEqual ) ) {
			throw new \RuntimeException( 'ValueComparer callback needs to return a boolean' );
		}

		return $valuesAreEqual;
	}

}


1		<?php
2
3		namespace Diff\Comparer;
4
5		/**
6		* Adapter around a comparison callback that implements the ValueComparer
7		* interface.
8		*
9		* @since 0.6
10		*
11		* @license GPL-2.0+
12		* @author Jeroen De Dauw < [email protected] >
13		*/
14		class CallbackComparer implements ValueComparer {
15
16		private $callback;
17
18		/**
19		* @since 0.6
20		*
21		* @param callable $callback
22		*/
23	7	public function __construct( $callback ) {
24	7	$this->callback = $callback;
25	7	}
26
27	7	public function valuesAreEqual( $firstValue, $secondValue ): bool {
28	7	$valuesAreEqual = call_user_func_array( $this->callback, array( $firstValue, $secondValue ) );
29
30	7	if ( !is_bool( $valuesAreEqual ) ) {
31		throw new \RuntimeException( 'ValueComparer callback needs to return a boolean' );
32		}
33
34	7	return $valuesAreEqual;
35		}
36
37		}
38

wmde / Diff

Push — php70 ( e501b7...c1737a )

CallbackComparer::valuesAreEqual() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like