DataTypeTest::tearDown() - Code Metrics - Inspection of "Add missing DataTypeTest::tearDown" - wmde/DataTypes - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — tearDown ( d20aa4 )

by no

created 2016-02-17 13:21 UTC

DataTypeTest::tearDown() A

↳ Parent: DataTypeTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	5
rs	9.4285
cc	1
eloc	3
nc	1
nop	0

<?php

namespace DataTypes\Tests\Phpunit;

use DataTypes\DataType;
use DataTypes\Message;
use PHPUnit_Framework_TestCase;

/**
 * @covers DataTypes\DataType
 *
 * @group DataTypes
 *
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < [email protected] >
 * @author Thiemo Mättig
 */
class DataTypeTest extends PHPUnit_Framework_TestCase {

	protected function setUp() {
		parent::setUp();

		Message::registerTextFunction( function( $key, $languageCode ) {

			return implode( '|', func_get_args() );
		} );
	}

	protected function tearDown() {
		Message::registerTextFunction( null );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		parent::tearDown();
	}

	/**
	 * @dataProvider invalidConstructorArgumentsProvider
	 */
	public function testConstructorThrowsException( $propertyType, $valueType ) {
		$this->setExpectedException( 'InvalidArgumentException' );
		new DataType( $propertyType, $valueType );
	}

	public function invalidConstructorArgumentsProvider() {
		return array(
			array( 'propertyType', null ),
			array( 'propertyType', false ),
			array( null, 'valueType' ),
			array( false, 'valueType' ),
		);
	}

	public function testGetId() {
		$type = new DataType( 'propertyType', 'valueType' );
		$this->assertSame( 'propertyType', $type->getId() );
	}

	public function testGetDataValueType() {
		$type = new DataType( 'propertyType', 'valueType' );
		$this->assertSame( 'valueType', $type->getDataValueType() );
	}

	public function testGetLabel() {
		$type = new DataType( 'propertyType', 'valueType' );
		$this->assertSame( 'datatypes-type-propertyType|en', $type->getLabel( 'en' ) );
	}

	public function testToArray() {
		$type = new DataType( 'propertyType', 'valueType' );
		$this->assertSame( array( 'dataValueType' => 'valueType' ), $type->toArray() );
	}

}


1			<?php
2
3			namespace DataTypes\Tests\Phpunit;
4
5			use DataTypes\DataType;
6			use DataTypes\Message;
7			use PHPUnit_Framework_TestCase;
8
9			/**
10			* @covers DataTypes\DataType
11			*
12			* @group DataTypes
13			*
14			* @licence GNU GPL v2+
15			* @author Jeroen De Dauw < [email protected] >
16			* @author Thiemo Mättig
17			*/
18			class DataTypeTest extends PHPUnit_Framework_TestCase {
19
20			protected function setUp() {
21			parent::setUp();
22
23			Message::registerTextFunction( function( $key, $languageCode ) {
			0 ignored issues – show Unused Code introduced 2016-01-12 11:21 UTC by Report Bug Copy Issue Report The parameter `$key` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-01-12 11:21 UTC by Report Bug Copy Issue Report The parameter `$languageCode` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
24			return implode( '\|', func_get_args() );
25			} );
26			}
27
28			protected function tearDown() {
29			Message::registerTextFunction( null );
			0 ignored issues – show Documentation introduced 2016-02-17 13:25 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30
31			parent::tearDown();
32			}
33
34			/**
35			* @dataProvider invalidConstructorArgumentsProvider
36			*/
37			public function testConstructorThrowsException( $propertyType, $valueType ) {
38			$this->setExpectedException( 'InvalidArgumentException' );
39			new DataType( $propertyType, $valueType );
40			}
41
42			public function invalidConstructorArgumentsProvider() {
43			return array(
44			array( 'propertyType', null ),
45			array( 'propertyType', false ),
46			array( null, 'valueType' ),
47			array( false, 'valueType' ),
48			);
49			}
50
51			public function testGetId() {
52			$type = new DataType( 'propertyType', 'valueType' );
53			$this->assertSame( 'propertyType', $type->getId() );
54			}
55
56			public function testGetDataValueType() {
57			$type = new DataType( 'propertyType', 'valueType' );
58			$this->assertSame( 'valueType', $type->getDataValueType() );
59			}
60
61			public function testGetLabel() {
62			$type = new DataType( 'propertyType', 'valueType' );
63			$this->assertSame( 'datatypes-type-propertyType\|en', $type->getLabel( 'en' ) );
64			}
65
66			public function testToArray() {
67			$type = new DataType( 'propertyType', 'valueType' );
68			$this->assertSame( array( 'dataValueType' => 'valueType' ), $type->toArray() );
69			}
70
71			}
72

wmde / DataTypes

Push — tearDown ( d20aa4 )

DataTypeTest::tearDown() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like