DataTypes\Tests\Phpunit\DataTypeTest

Complexity

Total Complexity

8

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	5
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	11	1
A	tearDown()	0	5	1
A	testConstructorThrowsException()	0	4	1
A	invalidConstructorArgumentsProvider()	0	12	1
A	testGetId()	0	4	1
A	testGetDataValueType()	0	4	1
A	testGetLabel()	0	4	1
A	testToArray()	0	4	1

<?php

namespace DataTypes\Tests\Phpunit;

use DataTypes\DataType;
use DataTypes\Message;
use PHPUnit_Framework_TestCase;
use ReflectionClass;

/**
 * @covers DataTypes\DataType
 *
 * @group DataTypes
 *
 * @license GPL-2.0+
 * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 * @author Thiemo Mättig
 */
class DataTypeTest extends PHPUnit_Framework_TestCase {

	/**
	 * @var callable|null
	 */
	private $textFunction;

	protected function setUp() {
		parent::setUp();

		$class = new ReflectionClass( 'DataTypes\Message' );
		$properties = $class->getStaticProperties();
		$this->textFunction = $properties['textFunction'];

		Message::registerTextFunction( function( $key, $languageCode ) {

The parameter $key is not used and could be removed.

The parameter $languageCode is not used and could be removed.

			return implode( '|', func_get_args() );
		} );
	}

	protected function tearDown() {
		Message::registerTextFunction( $this->textFunction );

It seems like $this->textFunction can also be of type null; however, DataTypes\Message::registerTextFunction() does only seem to accept callable, maybe add an additional type check?

		parent::tearDown();
	}

	/**
	 * @dataProvider invalidConstructorArgumentsProvider
	 */
	public function testConstructorThrowsException( $propertyType, $valueType ) {
		$this->setExpectedException( 'InvalidArgumentException' );
		new DataType( $propertyType, $valueType );
	}

	public function invalidConstructorArgumentsProvider() {
		return array(
			array( 'propertyType', '' ),
			array( 'propertyType', null ),
			array( 'propertyType', false ),
			array( 'propertyType', 1 ),
			array( '', 'valueType' ),
			array( null, 'valueType' ),
			array( false, 'valueType' ),
			array( 0, 'valueType' ),
		);
	}

	public function testGetId() {
		$type = new DataType( 'propertyType', 'valueType' );
		$this->assertSame( 'propertyType', $type->getId() );
	}

	public function testGetDataValueType() {
		$type = new DataType( 'propertyType', 'valueType' );
		$this->assertSame( 'valueType', $type->getDataValueType() );
	}

	public function testGetLabel() {
		$type = new DataType( 'propertyType', 'valueType' );
		$this->assertSame( 'datatypes-type-propertyType|en', $type->getLabel( 'en' ) );
	}

	public function testToArray() {
		$type = new DataType( 'propertyType', 'valueType' );
		$this->assertSame( array( 'dataValueType' => 'valueType' ), $type->toArray() );
	}

}