Refund::execute() - Code Metrics - Inspection of "Moip ♥ Magento 2" - wirecardBrasil/magento2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — [email protected] ( 8d386f...1b717f )

by Bruno

created 2021-07-08 12:22 UTC

Refund::execute() C

↳ Parent: Refund

Complexity

Conditions	14
Paths	20

Size

Total Lines	91
Code Lines	62

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	14
eloc	62
c	3
b	0
f	0
nc	20
nop	0
dl	0
loc	91
rs	6.2666

How to fix Long Method Complexity

<?php
/**
 * Copyright © Wirecard Brasil. All rights reserved.
 *
 * @author    Bruno Elisei <[email protected]>
 * See COPYING.txt for license details.
 */
declare(strict_types=1);

namespace Moip\Magento2\Controller\Webhooks;

use Exception;
use Magento\Framework\Api\SearchCriteriaBuilder;
filter:
    dependency_paths: ["lib/*"]
use Magento\Framework\App\Action\Action;
filter:
    dependency_paths: ["lib/*"]
use Magento\Framework\App\Action\Context;
filter:
    dependency_paths: ["lib/*"]
use Magento\Framework\App\CsrfAwareActionInterface as Crsf;
filter:
    dependency_paths: ["lib/*"]
use Magento\Framework\App\Request\InvalidRequestException;
filter:
    dependency_paths: ["lib/*"]
use Magento\Framework\App\RequestInterface;
filter:
    dependency_paths: ["lib/*"]
use Magento\Framework\Controller\Result\JsonFactory;
filter:
    dependency_paths: ["lib/*"]
use Magento\Framework\Serialize\Serializer\Json;
filter:
    dependency_paths: ["lib/*"]
use Magento\Payment\Model\Method\Logger;
filter:
    dependency_paths: ["lib/*"]
use Magento\Sales\Api\CreditmemoRepositoryInterface;
filter:
    dependency_paths: ["lib/*"]
use Magento\Sales\Api\Data\OrderInterfaceFactory;
filter:
    dependency_paths: ["lib/*"]
use Magento\Sales\Model\Order\Creditmemo;
filter:
    dependency_paths: ["lib/*"]
use Magento\Sales\Model\Order\CreditmemoFactory;
filter:
    dependency_paths: ["lib/*"]
use Magento\Sales\Model\Order\Invoice;
filter:
    dependency_paths: ["lib/*"]
use Magento\Sales\Model\Service\CreditmemoService;
filter:
    dependency_paths: ["lib/*"]
use Magento\Store\Model\StoreManagerInterface;
filter:
    dependency_paths: ["lib/*"]
use Moip\Magento2\Gateway\Config\Config;

/**
 * Class Refund - Receives communication for refunded payment.
 */
class Refund extends Action implements Crsf
{
    /**
     * createCsrfValidationException.
     *
     * @param RequestInterface $request
     *
     * @return null
     */
    public function createCsrfValidationException(RequestInterface $request): InvalidRequestException
    {
        if ($request) {

            return null;

        }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }

    /**
     * validateForCsrf.
     *
     * @param RequestInterface $request
     *
     * @return bool true
     */
    public function validateForCsrf(RequestInterface $request): bool
    {
        if ($request) {

            return true;
        }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }

    /**
     * @var logger
     */
    protected $logger;

    /**
     * @var orderFactory
filter:
    dependency_paths: ["lib/*"]
     */
    protected $orderFactory;

    /**
     * @var resultJsonFactory
filter:
    dependency_paths: ["lib/*"]
     */
    protected $resultJsonFactory;

    /**
     * @var storeManager
filter:
    dependency_paths: ["lib/*"]
     */
    protected $storeManager;

    /**
     * @var Json
     */
    protected $json;

    /**
     * @var CreditmemoRepositoryInterface
     */
    private $creditmemoRepository;

    /**
     * @var schCriteriaBuilder
filter:
    dependency_paths: ["lib/*"]
     */
    protected $schCriteriaBuilder;

    /**
     * @param Context               $context
     * @param logger                $logger
     * @param Config                $config
     * @param OrderInterfaceFactory $orderFactory
     * @param JsonFactory           $resultJsonFactory
     * @param Json                  $json
     */
    public function __construct(
        Context $context,
        Config $config,
        Logger $logger,
        OrderInterfaceFactory $orderFactory,
        CreditmemoFactory $creditmemoFactory,
        CreditmemoService $creditmemoService,
        Invoice $invoice,
        StoreManagerInterface $storeManager,
        JsonFactory $resultJsonFactory,
        Json $json,
        CreditmemoRepositoryInterface $creditmemoRepository,
        SearchCriteriaBuilder $schCriteriaBuilder
    ) {
        parent::__construct($context);
        $this->config = $config;

        $this->logger = $logger;
        $this->orderFactory = $orderFactory;
        $this->creditmemoFactory = $creditmemoFactory;

        $this->creditmemoService = $creditmemoService;

        $this->invoice = $invoice;

        $this->storeManager = $storeManager;
        $this->resultJsonFactory = $resultJsonFactory;
        $this->json = $json;
        $this->creditmemoRepository = $creditmemoRepository;
        $this->schCriteriaBuilder = $schCriteriaBuilder;
    }

    /**
     * Command Refund.
     *
     * @return json
     */
    public function execute()
    {
        if (!$this->getRequest()->isPost()) {
            $resultPage = $this->resultJsonFactory->create();
            $resultPage->setHttpResponseCode(404);

            return $resultPage;
        }

        $resultPage = $this->resultJsonFactory->create();
        $response = $this->getRequest()->getContent();
        $originalNotification = $this->json->unserialize($response);
        $authorization = $this->getRequest()->getHeader('Authorization');
        $storeId = $this->storeManager->getStore()->getId();
        $storeCaptureToken = $this->config->getMerchantGatewayRefundToken($storeId);

        if ($storeCaptureToken === $authorization) {
            $resource = $originalNotification['resource'];
            $extRefundId = $resource['refund']['id'];
            $extStatus = $resource['refund']['status'];

            $creditmemos = $this->getCreditMemoByTransactionId($extRefundId);
            if (count($creditmemos)) {
                foreach ($creditmemos as $creditmemo) {
                    if ($extStatus === 'REQUESTED') {
                        $creditmemo->setState(Creditmemo::STATE_OPEN);
                    } elseif ($extStatus === 'COMPLETED') {
                        $creditmemo->setState(Creditmemo::STATE_REFUNDED);
                    } elseif ($extStatus === 'FAILED') {
                        $creditmemo->setState(Creditmemo::STATE_CANCELED);
                    }

                    try {
                        $creditmemo->save();
                    } catch (\Exception $exc) {
                        $resultPage->setHttpResponseCode(500);
                        $resultPage->setJsonData(
                            $this->json->serialize([
                                'error'   => 400,
                                'message' => $exc->getMessage(),
                            ])
                        );
                    }

                    continue;
                }
            } else {
                $extOrderId = $resource['refund']['_links']['order']['title'];
                $creditmemo = $this->createNewCreditMemo($extOrderId, $extRefundId);
                if ($creditmemo) {

                    if ($extStatus === 'REQUESTED') {
                        $creditmemo->setState(Creditmemo::STATE_OPEN);
                    } elseif ($extStatus === 'COMPLETED') {
                        $creditmemo->setState(Creditmemo::STATE_REFUNDED);
                    } elseif ($extStatus === 'FAILED') {
                        $creditmemo->setState(Creditmemo::STATE_CANCELED);
                    }

                    try {
                        $this->creditmemoService->refund($creditmemo);
                    } catch (\Exception $exc) {
                        $resultPage->setHttpResponseCode(500);
                        $resultPage->setJsonData(
                            $this->json->serialize([
                                'error'   => 400,
                                'message' => $exc->getMessage(),
                            ])
                        );
                    }
                } else {
                    return $resultPage->setJsonData(
                        $this->json->serialize([
                            'error'   => 404,
                            'message' => 'The transaction could not be refund',
                        ])
                    );
                }
            }

            return $resultPage->setJsonData(
                $this->json->serialize([
                    'success'    => 1,
                    'extOrderId' => $extRefundId,
                    'state'      => $creditmemo->getState(),

                ])
            );
        }

        $resultPage->setHttpResponseCode(401);

        return $resultPage;
    }

    /**
     * Get Creditmemo.
     *
     * @params $extOrderId
     *
     * @return creditmemo
     */
    public function getCreditMemoByTransactionId(string $transactionId)
    {
        $searchCriteria = $this->schCriteriaBuilder
            ->addFilter('transaction_id', $transactionId)->create();

        try {
            $creditmemos = $this->creditmemoRepository->getList($searchCriteria);
            $creditmemoRecords = $creditmemos->getItems();
        } catch (Exception $exception) {
            $this->logger->critical($exception->getMessage());
            $creditmemoRecords = null;
        }

        return $creditmemoRecords;
    }

    /**
     * Create new creditmemo.
     *
     * @params $extOrderId
     * @parmas $extRefundId
     *
     * @return creditmemo
     */
    public function createNewCreditMemo(string $extOrderId, string $extRefundId)
    {
        $order = $this->orderFactory->create()->load($extOrderId, 'ext_order_id');
        $creditmemo = null;

        $payment = $order->getPayment();
        $invoices = $order->getInvoiceCollection();

        if ($invoices) {
            foreach ($invoices as $invoiceLoad) {
                $invoiceincrementid = $invoiceLoad->getIncrementId();
            }
            $invoiceobj = $this->invoice->loadByIncrementId($invoiceincrementid);

            $creditmemo = $this->creditmemoFactory->createByOrder($order);
            $payment->setTransactionId($extRefundId);
            $creditmemo->setInvoice($invoiceobj);
        }

        return $creditmemo;
    }
}


1			<?php
2			/**
3			* Copyright © Wirecard Brasil. All rights reserved.
4			*
5			* @author Bruno Elisei <[email protected]>
6			* See COPYING.txt for license details.
7			*/
8			declare(strict_types=1);
9
10			namespace Moip\Magento2\Controller\Webhooks;
11
12			use Exception;
13			use Magento\Framework\Api\SearchCriteriaBuilder;
			0 ignored issues – show Bug introduced 2021-07-08 12:25 UTC by Report Bug Copy Issue Report The type `Magento\Framework\Api\SearchCriteriaBuilder` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
14			use Magento\Framework\App\Action\Action;
			0 ignored issues – show Bug introduced 2020-12-09 14:45 UTC by Report Bug Copy Issue Report The type `Magento\Framework\App\Action\Action` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
15			use Magento\Framework\App\Action\Context;
			0 ignored issues – show Bug introduced 2020-12-09 14:45 UTC by Report Bug Copy Issue Report The type `Magento\Framework\App\Action\Context` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
16			use Magento\Framework\App\CsrfAwareActionInterface as Crsf;
			0 ignored issues – show Bug introduced 2020-12-09 14:45 UTC by Report Bug Copy Issue Report The type `Magento\Framework\App\CsrfAwareActionInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
17			use Magento\Framework\App\Request\InvalidRequestException;
			0 ignored issues – show Bug introduced 2020-12-09 14:45 UTC by Report Bug Copy Issue Report The type `Magento\Framework\App\Re...InvalidRequestException` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
18			use Magento\Framework\App\RequestInterface;
			0 ignored issues – show Bug introduced 2020-12-09 14:45 UTC by Report Bug Copy Issue Report The type `Magento\Framework\App\RequestInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
19			use Magento\Framework\Controller\Result\JsonFactory;
			0 ignored issues – show Bug introduced 2020-12-09 14:45 UTC by Report Bug Copy Issue Report The type `Magento\Framework\Controller\Result\JsonFactory` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
20			use Magento\Framework\Serialize\Serializer\Json;
			0 ignored issues – show Bug introduced 2021-06-22 13:52 UTC by Report Bug Copy Issue Report The type `Magento\Framework\Serialize\Serializer\Json` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
21			use Magento\Payment\Model\Method\Logger;
			0 ignored issues – show Bug introduced 2020-12-09 14:45 UTC by Report Bug Copy Issue Report The type `Magento\Payment\Model\Method\Logger` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
22			use Magento\Sales\Api\CreditmemoRepositoryInterface;
			0 ignored issues – show Bug introduced 2021-07-08 12:25 UTC by Report Bug Copy Issue Report The type `Magento\Sales\Api\CreditmemoRepositoryInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
23			use Magento\Sales\Api\Data\OrderInterfaceFactory;
			0 ignored issues – show Bug introduced 2020-12-09 14:45 UTC by Report Bug Copy Issue Report The type `Magento\Sales\Api\Data\OrderInterfaceFactory` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
24			use Magento\Sales\Model\Order\Creditmemo;
			0 ignored issues – show Bug introduced 2021-07-08 12:25 UTC by Report Bug Copy Issue Report The type `Magento\Sales\Model\Order\Creditmemo` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
25			use Magento\Sales\Model\Order\CreditmemoFactory;
			0 ignored issues – show Bug introduced 2020-12-09 14:45 UTC by Report Bug Copy Issue Report The type `Magento\Sales\Model\Order\CreditmemoFactory` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
26			use Magento\Sales\Model\Order\Invoice;
			0 ignored issues – show Bug introduced 2020-12-09 14:45 UTC by Report Bug Copy Issue Report The type `Magento\Sales\Model\Order\Invoice` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...

wirecardBrasil / magento2

Push — [email protected] ( 8d386f...1b717f )

Refund::execute() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like