Wingsline\Blog\Http\Controllers\AccountController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	update()	0	19	3
A	edit()	0	5	1

<?php

namespace Wingsline\Blog\Http\Controllers;

use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Foundation\Validation\ValidatesRequests;
use Illuminate\Routing\Controller as BaseController;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Hash;
use Wingsline\Blog\Http\Requests\AccountEditRequest;

class AccountController extends BaseController
{
    use AuthorizesRequests;
    use DispatchesJobs;
    use ValidatesRequests;

    /**
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function edit()
    {
        $user = Auth::user();

        return view('blog::account.edit', compact('user'));
    }

    public function update(AccountEditRequest $request)
    {
        $user = Auth::user();
        $validated = $request->validated();
        $user->fill([
            'name' => $validated['name'],
            'email' => $validated['email'],
        ]);

        if (null !== $validated['password']) {
            $user->password = Hash::make($validated['password']);

Accessing password on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        $user->save();
        if (\count($user->getChanges())) {
            flash()->success('Account updated.');
        }

        return redirect()->route('admin.account.edit');
    }
}