MySQLTest::testPdoIsNullOnErrorConnection() - Code Metrics - Inspection of "novo diretorio dev + melhorias gerais" - winframework/winphp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 659231...788af6 )

by Wanderson

created 2016-08-26 21:22 UTC

MySQLTest::testPdoIsNullOnErrorConnection() A

↳ Parent: MySQLTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	12
rs	9.4285
cc	1
eloc	9
nc	1
nop	0

<?php

namespace Win\Connection;

use Win\Helper\Url;
use Win\Mvc\Application;

class MySQLTest extends \PHPUnit_Framework_TestCase {

	public function testPdoIsNullOnErrorConnection() {
		$dbConfig = [
			'host' => 'localhost',
			'user' => 'no-name',
			'pass' => 'no-pass',
			'dbname' => 'database-doesnt-exist'
		];

		new Application();
		$db = new MySQL($dbConfig);
		$this->assertNull($db->getPDO());
	}

	public function testRedirectToPage500() {
		$dbConfig = [
			'host' => 'localhost',
			'user' => 'no-name',
			'pass' => 'no-pass',
			'dbname' => 'database-doesnt-exist'
		];

		Url::instance()->setUrl('my-page/test');
		$app = new Application();
		$this->assertEquals($app->getPage(), 'my-page');

		new MySQL($dbConfig);
		$this->assertEquals($app->getPage(), '503');
	}

	public function testConnectionWithSuccess() {
		static::startMySQLConnection();
		$this->assertTrue(MySQL::instance()->getPDO() instanceof \PDO);
	}

	/**
	 * @return \PDO
	 */
	static function startMySQLConnection() {

		require BASE_PATH . '/app/config/database.php';
		$db['dbname'] = 'win_test';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		$mysql = new MySQL($db);
		return $mysql->getPDO();
	}

}


1			<?php
2
3			namespace Win\Connection;
4
5			use Win\Helper\Url;
6			use Win\Mvc\Application;
7
8			class MySQLTest extends \PHPUnit_Framework_TestCase {
9
10			public function testPdoIsNullOnErrorConnection() {
11			$dbConfig = [
12			'host' => 'localhost',
13			'user' => 'no-name',
14			'pass' => 'no-pass',
15			'dbname' => 'database-doesnt-exist'
16			];
17
18			new Application();
19			$db = new MySQL($dbConfig);
20			$this->assertNull($db->getPDO());
21			}
22
23			public function testRedirectToPage500() {
24			$dbConfig = [
25			'host' => 'localhost',
26			'user' => 'no-name',
27			'pass' => 'no-pass',
28			'dbname' => 'database-doesnt-exist'
29			];
30
31			Url::instance()->setUrl('my-page/test');
32			$app = new Application();
33			$this->assertEquals($app->getPage(), 'my-page');
34
35			new MySQL($dbConfig);
36			$this->assertEquals($app->getPage(), '503');
37			}
38
39			public function testConnectionWithSuccess() {
40			static::startMySQLConnection();
41			$this->assertTrue(MySQL::instance()->getPDO() instanceof \PDO);
42			}
43
44			/**
45			* @return \PDO
46			*/
47			static function startMySQLConnection() {
			0 ignored issues – show Best Practice introduced 2016-08-26 21:27 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
48			require BASE_PATH . '/app/config/database.php';
49			$db['dbname'] = 'win_test';
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-08-26 21:27 UTC by Report Bug Copy Issue Report `$db` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$db = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
50			$mysql = new MySQL($db);
51			return $mysql->getPDO();
52			}
53
54			}
55

winframework / winphp

Push — master ( 659231...788af6 )

MySQLTest::testPdoIsNullOnErrorConnection() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like