UserDAO - Code Metrics - Inspection of "add DAO" - winframework/winphp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c823eb...e0ab14 )

by Wanderson

created 2016-08-13 19:58 UTC

UserDAO A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	3
c	1
b	0
f	1
lcom	0
cbo	2
dl	0
loc	34
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	mapObject()	0	9	2
A	mapRow()	0	6	1

<?php

namespace User;

use Win\DesignPattern\DAO;

/**
 * User DAO
 */
class UserDAO extends DAO {

	const TABLE = 'user';
	const ALIAS = 'Usuário';

	/** @var User */
	protected $obj;

	/**
	 * @param array $row
	 * @return \User\User
	 */
	public function mapObject(array $row) {
		$obj = new \User\User();
		if ($row) {

			$obj->setId($row['id']);
			$obj->setEmail($row['email']);
			$obj->setPass($row['pass']);
		}
		return $obj;
	}

	/**
	 * @param User $obj
	 * @return mixed[]
	 */
	public function mapRow($obj) {
		$row['id'] = $obj->getId();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		$row['email'] = $obj->getEmail();
		$row['pass'] = $obj->getPass();
		return $row;
	}

}


1			<?php
2
3			namespace User;
4
5			use Win\DesignPattern\DAO;
6
7			/**
8			* User DAO
9			*/
10			class UserDAO extends DAO {
11
12			const TABLE = 'user';
13			const ALIAS = 'Usuário';
14
15			/** @var User */
16			protected $obj;
17
18			/**
19			* @param array $row
20			* @return \User\User
21			*/
22			public function mapObject(array $row) {
23			$obj = new \User\User();
24			if ($row) {
			0 ignored issues – show Bug Best Practice introduced 2016-08-13 20:01 UTC by Report Bug Copy Issue Report The expression `$row` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
25			$obj->setId($row['id']);
26			$obj->setEmail($row['email']);
27			$obj->setPass($row['pass']);
28			}
29			return $obj;
30			}
31
32			/**
33			* @param User $obj
34			* @return mixed[]
35			*/
36			public function mapRow($obj) {
37			$row['id'] = $obj->getId();
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-08-13 20:01 UTC by Report Bug Copy Issue Report `$row` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$row = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
38			$row['email'] = $obj->getEmail();
39			$row['pass'] = $obj->getPass();
40			return $row;
41			}
42
43			}
44

winframework / winphp

Push — master ( c823eb...e0ab14 )

UserDAO A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like