User - Code Metrics - Inspection of "add Sistema login com recuperação de senha" - winframework/winphp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e32bea...07ff99 )

by Wanderson

created 2016-08-16 23:18 UTC

User B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	263
Duplicated Lines	0 %

Coupling/Cohesion

Components	3
Dependencies	4

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
wmc	44
c	2
b	0
f	1
lcom	3
cbo	4
dl	0
loc	263
rs	8.3396

36 Methods

Rating	Name	Size	Complexity
A	logout()	4	1
A	toSession()	13	1
A	fromSession()	11	1
A	__construct()	20	2
A	getId()	3	1
A	isActive()	3	1
A	isLogged()	3	1
A	getAccessLevel()	3	1
A	isMaster()	3	1
A	getGroup()	6	2
A	getGroupId()	3	1
A	getPerson()	6	2
A	getName()	3	1
A	getEmail()	3	1
A	getPassword()	3	1
A	getPasswordHash()	3	1
A	getRecoreryHash()	3	1
A	getImage()	3	1
A	getLastLogin()	3	1
A	setId()	3	1
A	setActive()	3	1
A	setAccessLevel()	3	1
A	setGroup()	3	1
A	setGroupId()	3	1
A	setPerson()	3	1
A	setName()	3	1
A	setEmail()	3	1
A	setPassword()	4	1
A	setPasswordHash()	3	1
A	setRecoreryHash()	3	1
A	setLastLogin()	3	1
A	setImage()	3	1
A	login()	16	2
A	requireLogin()	5	2
A	requireMaster()	5	3
A	sendRecoveryHash()	20	2

How to fix Complexity

<?php

namespace Win\Authentication;

use Win\Authentication\UserDAO;
use Win\Helper\Url;
use Win\Mvc\Block;
use Win\Mailer\Email;

/**
 * Usuários do sistema
 */
class User {

	const ACCESS_DISALLOWED = 0;
	const ACCESS_ALLOWED = 1;
	const ACCESS_ADMIN = 2;

	private $id;
	private $isActive;
	private $isLogged;
	private $accessLevel;
	private $name;
	private $email;
	private $password;
	private $passwordHash;
	private $recoreryHash;
	private $image;
	private $lastLogin;

	/** @var Group */
	private $group;
	private $groupId;

	/** @var Person */
	private $person;

	public function __construct() {
		$this->id = 0;
		$this->isActive = true;
		$this->isLogged = false;
		$this->accessLevel = self::ACCESS_DISALLOWED;
		$this->group = null;
		$this->groupId = 0;
		$this->person = null;
		$this->name = '';
		$this->email = '';
		$this->password = '********';
		$this->passwordHash = '';
		$this->recoreryHash = null;
		$this->image = null;
		$this->lastLogin = null;

		if (isset($_SESSION['user'])) {
			$this->fromSession();
		}
	}

	public function getId() {
		return $this->id;
	}

	public function isActive() {
		return $this->isActive;
	}

	public function isLogged() {
		return $this->isLogged;
	}

	public function getAccessLevel() {
		return $this->accessLevel;
	}

	/** @return boolean */
	public function isMaster() {
		return ($this->accessLevel == self::ACCESS_ADMIN);
	}

	public function getGroup() {
		if (is_null($this->group)) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
			// groupDAO
		}
		return $this->group;
	}

	public function getGroupId() {
		return $this->groupId;
	}

	public function getPerson() {
		if (is_null($this->person)) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
			// personDAO
		}
		return $this->person;
	}

	public function getName() {
		return $this->name;
	}

	public function getEmail() {
		return $this->email;
	}

	public function getPassword() {
		return $this->password;
	}

	public function getPasswordHash() {
		return $this->passwordHash;
	}

	public function getRecoreryHash() {
		return $this->recoreryHash;
	}

	public function getImage() {
		return $this->image;
	}

	public function getLastLogin() {
		return $this->lastLogin;
	}

	public function setId($id) {
		$this->id = (int) $id;
	}

	public function setActive($active) {
		$this->isActive = (boolean) $active;
	}

	public function setAccessLevel($accessLevel) {
		$this->accessLevel = (int) $accessLevel;
	}

	public function setGroup(Group $group) {
		$this->group = $group;
	}

	public function setGroupId($groupId) {
		$this->groupId = (int) $groupId;
	}

	public function setPerson(Person $person) {
		$this->person = $person;
	}

	public function setName($name) {
		$this->name = $name;
	}

	public function setEmail($email) {
		$this->email = $email;
	}

	public function setPassword($password) {
		$this->password = $password;
		$this->passwordHash = md5($password);
	}

	public function setPasswordHash($passwordHash) {
		$this->passwordHash = $passwordHash;
	}

	public function setRecoreryHash($recoreryHash) {
		$this->recoreryHash = $recoreryHash;
	}

	public function setLastLogin($lastLogin) {
		$this->lastLogin = $lastLogin;
	}

	public function setImage($image) {
		$this->image = $image;
	}

	/**
	 * Tenta realizar login
	 * @return boolean
	 */
	public function login() {
		$filters = [
			'is_active = ?' => true,
			'access_level > ?' => 0,
			'email = ?' => $this->email,
			'password_hash = ?' => $this->passwordHash
		];
		$uDAO = new UserDAO();
		$user = $uDAO->fetch($filters);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		if ($user->getId() > 0) {
			$this->toSession($user);
			$this->fromSession();
			$uDAO->updateLastLogin($user);
		}
		return $this->isLogged;
	}

	/**
	 * Realiza logout
	 */
	public function logout() {
		unset($_SESSION['user']);
		$this->__construct();
	}

	/** Objeto > Sessão */
	private function toSession(User $user) {
		$user->isLogged = TRUE;
		$_SESSION['user'] = [
			'logged' => $user->isLogged(),
			'id' => $user->getId(),
			'access_level' => $user->getAccessLevel(),
			'group_id' => $user->getGroupId(),
			'name' => $user->getName(),
			'email' => $user->getEmail(),
			'image' => $user->getImage(),
			'last_login' => $user->getLastLogin()
		];
	}

	/** Objeto < Sessão */
	private function fromSession() {
		$session = $_SESSION['user'];
		$this->isLogged = true;
		$this->id = $session['id'];
		$this->accessLevel = $session['access_level'];
		$this->groupId = $session['group_id'];
		$this->name = $session['name'];
		$this->email = $session['email'];
		$this->image = $session['image'];
		$this->lastLogin = $session['last_login'];
	}

	/** Obriga o usuário a se logar */
	public function requireLogin() {
		if (!$this->isLogged) {
			Url::instance()->redirect('login');
		}
	}

	/** Obriga o usuário a logar como ADMIN */
	public function requireMaster() {
		if (!$this->isLogged || $this->getAccessLevel() != static::ACCESS_ADMIN) {
			Url::instance()->redirect('login');
		}
	}

	/**
	 * Envia link de recuperacao de senha via Email
	 * @return boolean
	 */
	public function sendRecoveryHash() {
		$success = false;
		$filters = ['is_active = ?' => true, 'access_level > ?' => 0, 'email = ?' => $this->email];
		$uDAO = new UserDAO();
		$users = $uDAO->fetchAll($filters);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		
		if (count($users) > 0) {
			$success = true;
			$user = $users[0];
			$uDAO->updateRecoveryHash($user);
			$body = new Block('email/html/recovery-password', ['user' => $user]);

			$mail = new Email();
			$mail->setSubject('Recuperação de Senha');
			$mail->addAddress($user->getEmail(), $user->getName());
			$mail->setBody($body);
			$mail->send();
		}
		return $success;
	}

}


1			<?php
2
3			namespace Win\Authentication;
4
5			use Win\Authentication\UserDAO;
6			use Win\Helper\Url;
7			use Win\Mvc\Block;
8			use Win\Mailer\Email;
9
10			/**
11			* Usuários do sistema
12			*/
13			class User {
14
15			const ACCESS_DISALLOWED = 0;
16			const ACCESS_ALLOWED = 1;
17			const ACCESS_ADMIN = 2;
18
19			private $id;
20			private $isActive;
21			private $isLogged;
22			private $accessLevel;
23			private $name;
24			private $email;
25			private $password;
26			private $passwordHash;
27			private $recoreryHash;
28			private $image;
29			private $lastLogin;
30
31			/** @var Group */
32			private $group;
33			private $groupId;
34
35			/** @var Person */
36			private $person;
37
38			public function __construct() {
39			$this->id = 0;
40			$this->isActive = true;
41			$this->isLogged = false;
42			$this->accessLevel = self::ACCESS_DISALLOWED;
43			$this->group = null;
44			$this->groupId = 0;
45			$this->person = null;
46			$this->name = '';
47			$this->email = '';
48			$this->password = '********';
49			$this->passwordHash = '';
50			$this->recoreryHash = null;
51			$this->image = null;
52			$this->lastLogin = null;
53
54			if (isset($_SESSION['user'])) {
55			$this->fromSession();
56			}
57			}
58
59			public function getId() {
60			return $this->id;
61			}
62
63			public function isActive() {
64			return $this->isActive;
65			}
66
67			public function isLogged() {
68			return $this->isLogged;
69			}
70
71			public function getAccessLevel() {
72			return $this->accessLevel;
73			}
74
75			/** @return boolean */
76			public function isMaster() {
77			return ($this->accessLevel == self::ACCESS_ADMIN);
78			}
79
80			public function getGroup() {
81			if (is_null($this->group)) {
			0 ignored issues – show Unused Code introduced 2016-08-16 02:26 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
82			// groupDAO
83			}
84			return $this->group;
85			}
86
87			public function getGroupId() {
88			return $this->groupId;
89			}
90
91			public function getPerson() {
92			if (is_null($this->person)) {
			0 ignored issues – show Unused Code introduced 2016-08-16 02:26 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
93			// personDAO
94			}
95			return $this->person;
96			}
97
98			public function getName() {
99			return $this->name;
100			}
101
102			public function getEmail() {
103			return $this->email;
104			}
105
106			public function getPassword() {
107			return $this->password;
108			}
109
110			public function getPasswordHash() {
111			return $this->passwordHash;
112			}
113
114			public function getRecoreryHash() {
115			return $this->recoreryHash;
116			}
117
118			public function getImage() {
119			return $this->image;
120			}
121
122			public function getLastLogin() {
123			return $this->lastLogin;
124			}
125
126			public function setId($id) {
127			$this->id = (int) $id;
128			}
129
130			public function setActive($active) {
131			$this->isActive = (boolean) $active;
132			}
133
134			public function setAccessLevel($accessLevel) {
135			$this->accessLevel = (int) $accessLevel;
136			}
137
138			public function setGroup(Group $group) {
139			$this->group = $group;
140			}
141
142			public function setGroupId($groupId) {
143			$this->groupId = (int) $groupId;
144			}
145
146			public function setPerson(Person $person) {
147			$this->person = $person;
148			}
149
150			public function setName($name) {
151			$this->name = $name;
152			}
153
154			public function setEmail($email) {
155			$this->email = $email;
156			}
157
158			public function setPassword($password) {
159			$this->password = $password;
160			$this->passwordHash = md5($password);
161			}
162
163			public function setPasswordHash($passwordHash) {
164			$this->passwordHash = $passwordHash;
165			}
166
167			public function setRecoreryHash($recoreryHash) {
168			$this->recoreryHash = $recoreryHash;
169			}
170
171			public function setLastLogin($lastLogin) {
172			$this->lastLogin = $lastLogin;
173			}
174
175			public function setImage($image) {
176			$this->image = $image;
177			}
178
179			/**
180			* Tenta realizar login
181			* @return boolean
182			*/
183			public function login() {
184			$filters = [
185			'is_active = ?' => true,
186			'access_level > ?' => 0,
187			'email = ?' => $this->email,
188			'password_hash = ?' => $this->passwordHash
189			];
190			$uDAO = new UserDAO();
191			$user = $uDAO->fetch($filters);
			0 ignored issues – show Documentation introduced 2016-08-16 23:21 UTC by Report Bug Copy Issue Report `$filters` is of type `array<string,boolean\|int...rd_hash = ?":"string"}>`, but the function expects a `array<integer,string>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
192			if ($user->getId() > 0) {
193			$this->toSession($user);
194			$this->fromSession();
195			$uDAO->updateLastLogin($user);
196			}
197			return $this->isLogged;
198			}
199
200			/**
201			* Realiza logout
202			*/
203			public function logout() {
204			unset($_SESSION['user']);
205			$this->__construct();
206			}
207
208			/** Objeto > Sessão */
209			private function toSession(User $user) {
210			$user->isLogged = TRUE;
211			$_SESSION['user'] = [
212			'logged' => $user->isLogged(),
213			'id' => $user->getId(),
214			'access_level' => $user->getAccessLevel(),
215			'group_id' => $user->getGroupId(),
216			'name' => $user->getName(),
217			'email' => $user->getEmail(),
218			'image' => $user->getImage(),
219			'last_login' => $user->getLastLogin()
220			];
221			}
222
223			/** Objeto < Sessão */
224			private function fromSession() {
225			$session = $_SESSION['user'];
226			$this->isLogged = true;
227			$this->id = $session['id'];
228			$this->accessLevel = $session['access_level'];
229			$this->groupId = $session['group_id'];
230			$this->name = $session['name'];
231			$this->email = $session['email'];
232			$this->image = $session['image'];
233			$this->lastLogin = $session['last_login'];
234			}
235
236			/** Obriga o usuário a se logar */
237			public function requireLogin() {
238			if (!$this->isLogged) {
239			Url::instance()->redirect('login');
240			}
241			}
242
243			/** Obriga o usuário a logar como ADMIN */
244			public function requireMaster() {
245			if (!$this->isLogged \|\| $this->getAccessLevel() != static::ACCESS_ADMIN) {
246			Url::instance()->redirect('login');
247			}
248			}
249
250			/**
251			* Envia link de recuperacao de senha via Email
252			* @return boolean
253			*/
254			public function sendRecoveryHash() {
255			$success = false;
256			$filters = ['is_active = ?' => true, 'access_level > ?' => 0, 'email = ?' => $this->email];
257			$uDAO = new UserDAO();
258			$users = $uDAO->fetchAll($filters);
			0 ignored issues – show Documentation introduced 2016-08-16 23:21 UTC by Report Bug Copy Issue Report `$filters` is of type `array<string,boolean\|int...,"email = ?":"string"}>`, but the function expects a `array<integer,string>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
259
260			if (count($users) > 0) {
261			$success = true;
262			$user = $users[0];
263			$uDAO->updateRecoveryHash($user);
264			$body = new Block('email/html/recovery-password', ['user' => $user]);
265
266			$mail = new Email();
267			$mail->setSubject('Recuperação de Senha');
268			$mail->addAddress($user->getEmail(), $user->getName());
269			$mail->setBody($body);
270			$mail->send();
271			}
272			return $success;
273			}
274
275			}
276

winframework / winphp

Push — master ( e32bea...07ff99 )

User B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

36 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like