Header::set() - Code Metrics - Inspection of "add link para public" - winframework/winphp - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — tests1.5 (1e45fa)

by Wanderson

created 2018-08-25 19:19 UTC

Header::set() A

↳ Parent: Header

Complexity

Conditions	1
Paths	1

Size

Total Lines	2
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	2
dl	0
loc	2
rs	10
c	0
b	0
f	0

<?php

namespace Win\Request;

use Win\Data\Data;

/**
 * Header HTTP
 */
class Header extends Data {

	private static $headers = [];

	public static function getAll() {
		return static::$headers;

	}

	public static function set($key, $value) {
		static::$headers[$key] = $value;

	}

	/**
	 * Adiciona no 'HTTP Header' os valores que foram adicionados
	 * @codeCoverageIgnore
	 */
	public static function run() {
		foreach (static::$headers as $key => $value) {

			header($key . ':' . $value);
		}
		if (key_exists('location', static::$headers)) {
			die();

		}
	}

}


1			<?php
2
3			namespace Win\Request;
4
5			use Win\Data\Data;
6
7			/**
8			* Header HTTP
9			*/
10			class Header extends Data {
11
12			private static $headers = [];
13
14			public static function getAll() {
15			return static::$headers;
			0 ignored issues – show Bug introduced 2018-08-25 19:21 UTC by Report Bug Copy Issue Report Since `$headers` is declared private, accessing it with `static` will lead to errors in possible sub-classes; you can either use `self`, or increase the visibility of `$headers` to at least protected. Loading history...
16			}
17
18			public static function set($key, $value) {
19			static::$headers[$key] = $value;
			0 ignored issues – show Bug introduced 2018-08-25 19:21 UTC by Report Bug Copy Issue Report Since `$headers` is declared private, accessing it with `static` will lead to errors in possible sub-classes; you can either use `self`, or increase the visibility of `$headers` to at least protected. Loading history...
20			}
21
22			/**
23			* Adiciona no 'HTTP Header' os valores que foram adicionados
24			* @codeCoverageIgnore
25			*/
26			public static function run() {
27			foreach (static::$headers as $key => $value) {
			0 ignored issues – show Bug introduced 2018-08-25 19:21 UTC by Report Bug Copy Issue Report Since `$headers` is declared private, accessing it with `static` will lead to errors in possible sub-classes; you can either use `self`, or increase the visibility of `$headers` to at least protected. Loading history...
28			header($key . ':' . $value);
29			}
30			if (key_exists('location', static::$headers)) {
31			die();
			1 ignored issue – show Best Practice introduced 2018-08-25 19:21 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history...
32			}
33			}
34
35			}
36

winframework / winphp

Branch — tests1.5 (1e45fa)

Header::set() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like