MySQL::validateConnection() - Code Metrics - Inspection of "add conexao com banco de dados" - winframework/winphp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c62a3a...c823eb )

by Wanderson

created 2016-08-13 18:31 UTC

MySQL::validateConnection() A

↳ Parent: MySQL

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	7
rs	9.4285
cc	2
eloc	5
nc	2
nop	0

<?php

namespace Win\Connection;

/**
 * Conexão com banco de dados MySQL
 *
 */
use PDO;
use Win\Mvc\Application;
use Win\Mvc\View;

class MySQL implements DataBase {

	/** @var \static */
	static private $instance;

	/** @var \PDO */
	protected $pdo;

	public function getPDO() {
		return $this->pdo;
	}

	/**
	 * @return static
	 */
	static function instance() {

		return static::$instance;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
	}

	/**
	 * Cria uma conexão com um banco de dados
	 * @param string[] $dbConfig
	 */
	public function __construct($dbConfig) {
		static::$instance = $this;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}

		$errorLevel = error_reporting(0);
		$this->pdo = new PDO('mysql:host=' . $dbConfig['host'] . ';dbname=' . $dbConfig['dbname'], $dbConfig['user'], $dbConfig['pass']);
		error_reporting($errorLevel);

		$this->validateConnection();
	}

	private function validateConnection() {
		if ($this->pdo->errorCode()) {
			$data['error'] = $this->pdo->errorInfo();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			Application::app()->view = new View('500', $data);
			Application::app()->setTitle('Problemas de Conexão');
		}
	}

}


1			<?php
2
3			namespace Win\Connection;
4
5			/**
6			* Conexão com banco de dados MySQL
7			*
8			*/
9			use PDO;
10			use Win\Mvc\Application;
11			use Win\Mvc\View;
12
13			class MySQL implements DataBase {
14
15			/** @var \static */
16			static private $instance;
17
18			/** @var \PDO */
19			protected $pdo;
20
21			public function getPDO() {
22			return $this->pdo;
23			}
24
25			/**
26			* @return static
27			*/
28			static function instance() {
			0 ignored issues – show Best Practice introduced 2016-08-13 18:34 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
29			return static::$instance;
			0 ignored issues – show Bug introduced 2016-08-13 18:34 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
30			}
31
32			/**
33			* Cria uma conexão com um banco de dados
34			* @param string[] $dbConfig
35			*/
36			public function __construct($dbConfig) {
37			static::$instance = $this;
			0 ignored issues – show Bug introduced 2016-08-13 18:34 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history... Documentation Bug introduced 2016-08-13 18:34 UTC by Report Bug Copy Issue Report It seems like `$this` of type `this<Win\Connection\MySQL>` is incompatible with the declared type `object<static>` of property `$instance`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
38
39			$errorLevel = error_reporting(0);
40			$this->pdo = new PDO('mysql:host=' . $dbConfig['host'] . ';dbname=' . $dbConfig['dbname'], $dbConfig['user'], $dbConfig['pass']);
41			error_reporting($errorLevel);
42
43			$this->validateConnection();
44			}
45
46			private function validateConnection() {
47			if ($this->pdo->errorCode()) {
48			$data['error'] = $this->pdo->errorInfo();
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-08-13 18:34 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
49			Application::app()->view = new View('500', $data);
50			Application::app()->setTitle('Problemas de Conexão');
51			}
52			}
53
54			}
55

winframework / winphp

Push — master ( c62a3a...c823eb )

MySQL::validateConnection() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like