ValidIntegersSniffTest

Complexity

Total Complexity

9

Size/Duplication

Total Lines	153
Duplicated Lines	7.84 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	1

8 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	6	1
A	testBinaryInteger()	0	12	2
A	dataBinaryInteger()	0	6	1
A	testInvalidBinaryInteger()	0	4	1
A	testInvalidOctalInteger()	0	10	1
A	dataInvalidOctalInteger()	0	7	1
A	testValidOctalInteger()	0	3	1
A	testHexNumericString()	12	12	1

<?php
/**
 * Valid Integers Sniff test file
 *
 * @package PHPCompatibility
 */


/**
 * Valid Integers Sniff tests
 *
 * @uses    BaseSniffTest
 * @package PHPCompatibility
 * @author  Juliette Reinders Folmer <phpcompatibility_nospam@adviesenzo.nl>
 */
class ValidIntegersSniffTest extends BaseSniffTest

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    const TEST_FILE = 'sniff-examples/valid_integers.php';

    /**
     * Sniffed file
     *
     * @var PHP_CodeSniffer_File
     */
    protected $_sniffFile;

    /**
     * setUp
     *
     * @return void
     */
    public function setUp()
    {
        parent::setUp();

        $this->_sniffFile = $this->sniffFile(self::TEST_FILE);
    }


    /**
     * testBinaryInteger
     *
     * @group ValidIntegers
     *
     * @dataProvider dataBinaryInteger
     *
     * @param int    $line  Line number where the error should occur.
     * @param string $octal (Start of) Binary number as a string.

There is no parameter named $octal. Was it maybe removed?

     * @param bool   $testNoViolation Whether or not to test for noViolation.
     *               Defaults to true. Set to false if another error is
     *               expected on the same line (invalid binary)
     *
     * @return void
     */
    public function testBinaryInteger($line, $binary, $testNoViolation = true)
    {
		
        $file = $this->sniffFile(self::TEST_FILE, '5.3');
        $this->assertError($file, $line, 'Binary integer literals were not present in PHP version 5.3 or earlier. Found: ' . $binary);


		if ($testNoViolation === true) {
	        $file = $this->sniffFile(self::TEST_FILE, '5.4');
	        $this->assertNoViolation($file, $line);
		}
    }

    /**
     * dataBinaryInteger
     *
     * @see testBinaryInteger()
     *
     * @return array
     */
    public function dataBinaryInteger() {
        return array(
            array(3, '0b001001101', true),
            array(4, '0b01', false),
        );
    }


    /**
     * testInvalidBinaryInteger
     *
     * @group ValidIntegers
     *
     * @return void
     */
    public function testInvalidBinaryInteger()
    {
        $this->assertError($this->_sniffFile, 4, 'Invalid binary integer detected. Found: 0b0123456');
    }


    /**
     * testInvalidOctalInteger
     *
     * @group ValidIntegers
     *
     * @dataProvider dataInvalidOctalInteger
     *
     * @param int    $line  Line number where the error should occur.
     * @param string $octal Octal number as a string.
     *
     * @return void
     */
    public function testInvalidOctalInteger($line, $octal)
    {
        $error = 'Invalid octal integer detected. Prior to PHP 7 this would lead to a truncated number. From PHP 7 onwards this causes a parse error. Found: ' . $octal;

        $file = $this->sniffFile(self::TEST_FILE, '5.4');
        $this->assertWarning($file, $line, $error);

        $file = $this->sniffFile(self::TEST_FILE, '7.0');
        $this->assertError($file, $line, $error);
    }

    /**
     * dataInvalidOctalInteger
     *
     * @see testInvalidOctalInteger()
     *
     * @return array
     */
    public function dataInvalidOctalInteger() {
        return array(
            array(7, '08'),
            array(8, '038'),
            array(9, '091'),
        );
    }


    /**
     * testValidOctalInteger
     *
     * @group ValidIntegers
     *
     * @return void
     */
    public function testValidOctalInteger() {
        $this->assertNoViolation($this->_sniffFile, 6);
    }


    /**
     * testHexNumericString
     *
     * @group ValidIntegers
     *
     * @return void
     */
    public function testHexNumericString()

This method seems to be duplicated in your project.

    {
        $error = 'The behaviour of hexadecimal numeric strings was inconsistent prior to PHP 7 and support has been removed in PHP 7. Found: \'0xaa78b5\'';

        $file = $this->sniffFile(self::TEST_FILE, '5.0');
        $this->assertWarning($file, 11, $error);
        $this->assertNoViolation($file, 12);

        $file = $this->sniffFile(self::TEST_FILE, '7.0');
        $this->assertError($file, 11, $error);
        $this->assertNoViolation($file, 12);
    }

}