PHPCompatibility_Sniffs_PHP_NewNowdocSniff

Complexity

Total Complexity

16

Size/Duplication

Total Lines	93
Duplicated Lines	6.45 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	register()	0	18	4
C	process()	6	52	12

<?php
/**
 * PHPCompatibility_Sniffs_PHP_NewNowdocSniff.
 *
 * PHP version 5.3
 *
 * @category  PHP
 * @package   PHPCompatibility
 * @author    Juliette Reinders Folmer <phpcompatibility_nospam@adviesenzo.nl>
 */

/**
 * PHPCompatibility_Sniffs_PHP_NewNowdocSniff.
 *
 * @category  PHP
 * @package   PHPCompatibility
 * @author    Juliette Reinders Folmer <phpcompatibility_nospam@adviesenzo.nl>
 */
class PHPCompatibility_Sniffs_PHP_NewNowdocSniff extends PHPCompatibility_Sniff

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * Returns an array of tokens this test wants to listen for.
     *
     * @return array
     */
    public function register()
    {
        $targets = array();

        if (PHP_VERSION_ID < 50300) {
            $targets = T_SL;

The expression T_SL; of type integer adds the type integer to the return on line 42 which is incompatible with the return type declared by the interface PHP_CodeSniffer_Sniff::register of type integer[].

        }

        if (defined('T_START_NOWDOC')) {
            $targets[] = constant('T_START_NOWDOC');
        }
        if (defined('T_END_NOWDOC')) {
            $targets[] = constant('T_END_NOWDOC');
        }

        return $targets;

    }//end register()


    /**
     * Processes this test, when one of its tokens is encountered.
     *
     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
     * @param int                  $stackPtr  The position of the current token in
     *                                        the stack passed in $tokens.
     *
     * @return int|void On older PHP versions passes a pointer to the nowdoc closer
     *                  to skip passed anything in between in regards to processing
     *                  the file for this sniff.
     */
    public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
    {
        if ($this->supportsBelow('5.2') === false) {
            return;
        }

        $tokens = $phpcsFile->getTokens();

        /*
         * In PHP 5.2 the T_NOWDOC tokens aren't recognized yet and PHPCS does not
         * backfill for it, so we have to sniff for a specific combination of tokens.
         */
        if ($tokens[$stackPtr]['type'] === 'T_SL') {
            if (isset($tokens[($stackPtr+1)]) === false || $tokens[($stackPtr+1)]['type'] !== 'T_LESS_THAN') {

This code seems to be duplicated across your project.

                return;
            }

            if (isset($tokens[($stackPtr+2)]) === false || $tokens[($stackPtr+2)]['type'] !== 'T_CONSTANT_ENCAPSED_STRING') {

This code seems to be duplicated across your project.

                return;
            }

            /*
             * Heredoc and nowdoc naming rules:
             * "it must contain only alphanumeric characters and underscores and
             *  must start with a non-digit character or underscore"
             * @link http://php.net/manual/en/language.types.string.php#language.types.string.syntax.heredoc
             */
            if (preg_match('`^\'([a-z][a-z0-9_]*)\'$`iD', $tokens[($stackPtr+2)]['content'], $matches) < 1) {
                return;
            }

            $closer = $phpcsFile->findNext(T_STRING, ($stackPtr + 3), null, false, $matches[1], true);
            // The closing identifier must begin in the first column of the line.
            if ($closer === false || $tokens[($closer - 1)]['column'] !== 1) {
                return;
            }

            // The closing identifier must be the only content on that line, except for maybe a semi-colon.
            $next = $phpcsFile->findNext(array(T_WHITESPACE, T_SEMICOLON), ($closer + 1), null, true);
            if ($tokens[$closer]['line'] === $tokens[$next]['line']) {
                return;
            }
        }

        $phpcsFile->addError('Nowdocs are not present in PHP version 5.2 or earlier.', $stackPtr, 'Found');

        if (isset($closer) !== false) {
            $phpcsFile->addError('Nowdocs are not present in PHP version 5.2 or earlier.', $closer, 'Found');

The variable $closer does not seem to be defined for all execution paths leading up to this point.

            return ($closer + 1);
        }

    }//end process()

}//end class