wimg /
PHPCompatibility
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like PHPCompatibility_Sniff often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use PHPCompatibility_Sniff, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 22 | abstract class PHPCompatibility_Sniff implements PHP_CodeSniffer_Sniff |
||
|
|
|||
| 23 | { |
||
| 24 | |||
| 25 | /* The testVersion configuration variable may be in any of the following formats: |
||
| 26 | * 1) Omitted/empty, in which case no version is specified. This effectively |
||
| 27 | * disables all the checks provided by this standard. |
||
| 28 | * 2) A single PHP version number, e.g. "5.4" in which case the standard checks that |
||
| 29 | * the code will run on that version of PHP (no deprecated features or newer |
||
| 30 | * features being used). |
||
| 31 | * 3) A range, e.g. "5.0-5.5", in which case the standard checks the code will run |
||
| 32 | * on all PHP versions in that range, and that it doesn't use any features that |
||
| 33 | * were deprecated by the final version in the list, or which were not available |
||
| 34 | * for the first version in the list. |
||
| 35 | * PHP version numbers should always be in Major.Minor format. Both "5", "5.3.2" |
||
| 36 | * would be treated as invalid, and ignored. |
||
| 37 | * This standard doesn't support checking against PHP4, so the minimum version that |
||
| 38 | * is recognised is "5.0". |
||
| 39 | */ |
||
| 40 | |||
| 41 | private function getTestVersion() |
||
| 82 | |||
| 83 | View Code Duplication | public function supportsAbove($phpVersion) |
|
| 84 | { |
||
| 85 | $testVersion = $this->getTestVersion(); |
||
| 86 | $testVersion = $testVersion[1]; |
||
| 87 | |||
| 88 | if (is_null($testVersion) |
||
| 89 | || version_compare($testVersion, $phpVersion) >= 0 |
||
| 90 | ) { |
||
| 91 | return true; |
||
| 92 | } else { |
||
| 93 | return false; |
||
| 94 | } |
||
| 95 | }//end supportsAbove() |
||
| 96 | |||
| 97 | View Code Duplication | public function supportsBelow($phpVersion) |
|
| 98 | { |
||
| 99 | $testVersion = $this->getTestVersion(); |
||
| 100 | $testVersion = $testVersion[0]; |
||
| 101 | |||
| 102 | if (!is_null($testVersion) |
||
| 103 | && version_compare($testVersion, $phpVersion) <= 0 |
||
| 104 | ) { |
||
| 105 | return true; |
||
| 106 | } else { |
||
| 107 | return false; |
||
| 108 | } |
||
| 109 | }//end supportsBelow() |
||
| 110 | |||
| 111 | /** |
||
| 112 | * Returns the name(s) of the interface(s) that the specified class implements. |
||
| 113 | * |
||
| 114 | * Returns FALSE on error or if there are no implemented interface names. |
||
| 115 | * |
||
| 116 | * {@internal Duplicate of same method as introduced in PHPCS 2.7. |
||
| 117 | * Once the minimum supported PHPCS version for this sniff library goes beyond |
||
| 118 | * that, this method can be removed and call to it replaced with |
||
| 119 | * `$phpcsFile->findImplementedInterfaceNames($stackPtr)` calls.}} |
||
| 120 | * |
||
| 121 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 122 | * @param int $stackPtr The position of the class token. |
||
| 123 | * |
||
| 124 | * @return array|false |
||
| 125 | */ |
||
| 126 | public function findImplementedInterfaceNames($phpcsFile, $stackPtr) |
||
| 169 | |||
| 170 | |||
| 171 | /** |
||
| 172 | * Checks if a function call has parameters. |
||
| 173 | * |
||
| 174 | * Expects to be passed the T_STRING stack pointer for the function call. |
||
| 175 | * If passed a T_STRING which is *not* a function call, the behaviour is unreliable. |
||
| 176 | * |
||
| 177 | * @link https://github.com/wimg/PHPCompatibility/issues/120 |
||
| 178 | * @link https://github.com/wimg/PHPCompatibility/issues/152 |
||
| 179 | * |
||
| 180 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 181 | * @param int $stackPtr The position of the function call token. |
||
| 182 | * |
||
| 183 | * @return bool |
||
| 184 | */ |
||
| 185 | public function doesFunctionCallHaveParameters(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 218 | |||
| 219 | |||
| 220 | /** |
||
| 221 | * Count the number of parameters a function call has been passed. |
||
| 222 | * |
||
| 223 | * Expects to be passed the T_STRING stack pointer for the function call. |
||
| 224 | * If passed a T_STRING which is *not* a function call, the behaviour is unreliable. |
||
| 225 | * |
||
| 226 | * @link https://github.com/wimg/PHPCompatibility/issues/111 |
||
| 227 | * @link https://github.com/wimg/PHPCompatibility/issues/114 |
||
| 228 | * @link https://github.com/wimg/PHPCompatibility/issues/151 |
||
| 229 | * |
||
| 230 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 231 | * @param int $stackPtr The position of the function call token. |
||
| 232 | * |
||
| 233 | * @return int |
||
| 234 | */ |
||
| 235 | public function getFunctionCallParameterCount(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 277 | |||
| 278 | |||
| 279 | /** |
||
| 280 | * Verify whether a token is within a class scope. |
||
| 281 | * |
||
| 282 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 283 | * @param int $stackPtr The position of the token. |
||
| 284 | * |
||
| 285 | * @return bool True if within class scope, false otherwise. |
||
| 286 | */ |
||
| 287 | public function inClassScope(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 310 | |||
| 311 | |||
| 312 | /** |
||
| 313 | * Returns the fully qualified class name for a new class instantiation. |
||
| 314 | * |
||
| 315 | * Returns an empty string if the class name could not be reliably inferred. |
||
| 316 | * |
||
| 317 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 318 | * @param int $stackPtr The position of a T_NEW token. |
||
| 319 | * |
||
| 320 | * @return string |
||
| 321 | */ |
||
| 322 | public function getFQClassNameFromNewToken(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 349 | |||
| 350 | |||
| 351 | /** |
||
| 352 | * Returns the fully qualified name of the class that the specified class extends. |
||
| 353 | * |
||
| 354 | * Returns an empty string if the class does not extend another class or if |
||
| 355 | * the class name could not be reliably inferred. |
||
| 356 | * |
||
| 357 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 358 | * @param int $stackPtr The position of a T_CLASS token. |
||
| 359 | * |
||
| 360 | * @return string |
||
| 361 | */ |
||
| 362 | public function getFQExtendedClassName(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 382 | |||
| 383 | |||
| 384 | /** |
||
| 385 | * Returns the class name for the static usage of a class. |
||
| 386 | * This can be a call to a method, the use of a property or constant. |
||
| 387 | * |
||
| 388 | * Returns an empty string if the class name could not be reliably inferred. |
||
| 389 | * |
||
| 390 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 391 | * @param int $stackPtr The position of a T_NEW token. |
||
| 392 | * |
||
| 393 | * @return string |
||
| 394 | */ |
||
| 395 | public function getFQClassNameFromDoubleColonToken(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 436 | |||
| 437 | |||
| 438 | /** |
||
| 439 | * Get the Fully Qualified name for a class/function/constant etc. |
||
| 440 | * |
||
| 441 | * Checks if a class/function/constant name is already fully qualified and |
||
| 442 | * if not, enrich it with the relevant namespace information. |
||
| 443 | * |
||
| 444 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 445 | * @param int $stackPtr The position of the token. |
||
| 446 | * @param string $name The class / function / constant name. |
||
| 447 | * |
||
| 448 | * @return string |
||
| 449 | */ |
||
| 450 | public function getFQName(PHP_CodeSniffer_File $phpcsFile, $stackPtr, $name) |
||
| 471 | |||
| 472 | |||
| 473 | /** |
||
| 474 | * Is the class/function/constant name namespaced or global ? |
||
| 475 | * |
||
| 476 | * @param string $FQName Fully Qualified name of a class, function etc. |
||
| 477 | * I.e. should always start with a `\` ! |
||
| 478 | * |
||
| 479 | * @return bool True if namespaced, false if global. |
||
| 480 | */ |
||
| 481 | public function isNamespaced($FQName) { |
||
| 488 | |||
| 489 | |||
| 490 | /** |
||
| 491 | * Determine the namespace name an arbitrary token lives in. |
||
| 492 | * |
||
| 493 | * @param PHP_CodeSniffer_File $phpcsFile Instance of phpcsFile. |
||
| 494 | * @param int $stackPtr The token position for which to determine the namespace. |
||
| 495 | * |
||
| 496 | * @return string Namespace name or empty string if it couldn't be determined or no namespace applies. |
||
| 497 | */ |
||
| 498 | public function determineNamespace(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 548 | |||
| 549 | /** |
||
| 550 | * Get the complete namespace name for a namespace declaration. |
||
| 551 | * |
||
| 552 | * For hierarchical namespaces, the name will be composed of several tokens, |
||
| 553 | * i.e. MyProject\Sub\Level which will be returned together as one string. |
||
| 554 | * |
||
| 555 | * @param PHP_CodeSniffer_File $phpcsFile Instance of phpcsFile. |
||
| 556 | * @param int|bool $stackPtr The position of a T_NAMESPACE token. |
||
| 557 | * |
||
| 558 | * @return string|false Namespace name or false if not a namespace declaration. |
||
| 559 | * Namespace name can be an empty string for global namespace declaration. |
||
| 560 | */ |
||
| 561 | public function getDeclaredNamespaceName(PHP_CodeSniffer_File $phpcsFile, $stackPtr ) |
||
| 601 | |||
| 602 | |||
| 603 | /** |
||
| 604 | * Returns the method parameters for the specified T_FUNCTION token. |
||
| 605 | * |
||
| 606 | * Each parameter is in the following format: |
||
| 607 | * |
||
| 608 | * <code> |
||
| 609 | * 0 => array( |
||
| 610 | * 'name' => '$var', // The variable name. |
||
| 611 | * 'pass_by_reference' => false, // Passed by reference. |
||
| 612 | * 'type_hint' => string, // Type hint for array or custom type |
||
| 613 | * ) |
||
| 614 | * </code> |
||
| 615 | * |
||
| 616 | * Parameters with default values have an additional array index of |
||
| 617 | * 'default' with the value of the default as a string. |
||
| 618 | * |
||
| 619 | * {@internal Duplicate of same method as contained in the `PHP_CodeSniffer_File` |
||
| 620 | * class, but with some improvements which were only introduced in PHPCS 2.7. |
||
| 621 | * Once the minimum supported PHPCS version for this sniff library goes beyond |
||
| 622 | * that, this method can be removed and calls to it replaced with |
||
| 623 | * `$phpcsFile->getMethodParameters($stackPtr)` calls.}} |
||
| 624 | * |
||
| 625 | * @param PHP_CodeSniffer_File $phpcsFile Instance of phpcsFile. |
||
| 626 | * @param int $stackPtr The position in the stack of the T_FUNCTION token |
||
| 627 | * to acquire the parameters for. |
||
| 628 | * |
||
| 629 | * @return array |
||
| 630 | * @throws PHP_CodeSniffer_Exception If the specified $stackPtr is not of |
||
| 631 | * type T_FUNCTION. |
||
| 632 | */ |
||
| 633 | public function getMethodParameters(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 778 | |||
| 779 | }//end class |
||
| 780 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.