NewScalarTypeDeclarationsSniffTest::testInvalidTypeDeclaration() - Code Metrics - Inspection of "Feature completeness `NewScalarTypeDeclarations` s..." - wimg/PHPCompatibility - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#168)

by Juliette

created 2016-08-16 13:34 UTC

testInvalidTypeDeclaration() A

↳ Parent: NewScalarTypeDeclarationsSniffTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	5
rs	9.4285
cc	1
eloc	3
nc	1
nop	3

<?php
/**
 * New type declarations test file
 *
 * @package PHPCompatibility
 */


/**
 * New type declarations test file
 *
 * @uses BaseSniffTest
 * @package PHPCompatibility
 * @author Wim Godden <[email protected]>
 */
class NewScalarTypeDeclarationsSniffTest extends BaseSniffTest
namespace YourVendor;

class YourClass { }
{
    const TEST_FILE = 'sniff-examples/new_scalar_type_declarations.php';

    /**
     * testNewTypeDeclaration
     *
     * @group TypeDeclarations
     *
     * @dataProvider dataNewTypeDeclaration
     *
     * @param string $type The scalar type.
     * @param int    $line Line number on which to expect an error.
     *
     * @return void
     */
    public function testNewTypeDeclaration($type, $lastVersionBefore, $line, $okVersion)
    {
        $file = $this->sniffFile(self::TEST_FILE, $lastVersionBefore);
        $this->assertError($file, $line, "'{$type}' type declaration is not present in PHP version {$lastVersionBefore} or earlier");

        $file = $this->sniffFile(self::TEST_FILE, $okVersion);
        $this->assertNoViolation($file, $line);
    }

    /**
     * Data provider.
     *
     * @see testNewTypeDeclaration()
     *
     * @return array
     */
    public function dataNewTypeDeclaration()
    {
        return array(
            array('array', '5.0', 4, '5.1'),
            array('array', '5.0', 5, '5.1'),
            array('callable', '5.3', 9, '5.4'),
            array('bool', '5.6', 13, '7.0'),
            array('int', '5.6', 14, '7.0'),
            array('float', '5.6', 15, '7.0'),
            array('string', '5.6', 16, '7.0'),
        );
    }


    /**
     * testInvalidTypeDeclaration
     *
     * @group TypeDeclarations
     *
     * @dataProvider dataInvalidTypeDeclaration
     *
     * @param string $type The scalar type.
     * @param int    $line Line number on which to expect an error.
     *
     * @return void
     */
    public function testInvalidTypeDeclaration($type, $alternative, $line)
    {
        $file = $this->sniffFile(self::TEST_FILE);
        $this->assertError($file, $line, "'{$type}' is not a valid type declaration. Did you mean {$alternative} ?");
    }

    /**
     * Data provider.
     *
     * @see testInvalidTypeDeclaration()
     *
     * @return array
     */
    public function dataInvalidTypeDeclaration()
    {
        return array(
            array('boolean', 'bool', 20),
            array('integer', 'int', 21),
            array('parent', 'self', 24),
            array('static', 'self', 25),
        );
    }


    /**
     * testInvalidSelfTypeDeclaration
     *
     * @group TypeDeclarations
     *
     * @dataProvider dataInvalidSelfTypeDeclaration
     *
     * @param int $line Line number on which to expect an error.
     *
     * @return void
     */
    public function testInvalidSelfTypeDeclaration($line)
    {
        $file = $this->sniffFile(self::TEST_FILE);
        $this->assertError($file, $line, "'self' type cannot be used outside of class scope");
    }

    /**
     * Data provider.
     *
     * @see testInvalidSelfTypeDeclaration()
     *
     * @return array
     */
    public function dataInvalidSelfTypeDeclaration()
    {
        return array(
            array(37),
            array(44),
        );
    }


    /**
     * testTypeDeclaration
     *
     * @group TypeDeclarations
     *
     * @dataProvider dataTypeDeclaration
     *
     * @param int  $line            Line number on which to expect an error.
     * @param bool $testNoViolation Whether or not to test noViolation for PHP 5.0.
     *                              This covers the remaining few cases not covered
     *                              by the above tests.
     *
     * @return void
     */
    public function testTypeDeclaration($line, $testNoViolation = false)

    {
        $file = $this->sniffFile(self::TEST_FILE, '4.4');
        $this->assertError($file, $line, 'Type hints were not present in PHP 4.4 or earlier');

        if ($testNoViolation === true) {
            $file = $this->sniffFile(self::TEST_FILE, '5.0');
            $this->assertNoViolation($file, $line);
        }
    }

    /**
     * Data provider.
     *
     * @see testTypeDeclaration()
     *
     * @return array
     */
    public function dataTypeDeclaration()
    {
        return array(
            array(4),
            array(5),
            array(9),
            array(13),
            array(14),
            array(15),
            array(16),
            array(20),
            array(21),
            array(24),
            array(25),
            array(29, true),
            array(34, true),
            array(37),
            array(41, true),
            array(44),
        );
    }
}



1		<?php
2		/**
3		* New type declarations test file
4		*
5		* @package PHPCompatibility
6		*/
7
8
9		/**
10		* New type declarations test file
11		*
12		* @uses BaseSniffTest
13		* @package PHPCompatibility
14		* @author Wim Godden <[email protected]>
15		*/
16		class NewScalarTypeDeclarationsSniffTest extends BaseSniffTest
		0 ignored issues – show Coding Style Compatibility introduced 2016-08-04 22:56 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
17		{
18		const TEST_FILE = 'sniff-examples/new_scalar_type_declarations.php';
19
20		/**
21		* testNewTypeDeclaration
22		*
23		* @group TypeDeclarations
24		*
25		* @dataProvider dataNewTypeDeclaration
26		*
27		* @param string $type The scalar type.
28		* @param int $line Line number on which to expect an error.
29		*
30		* @return void
31		*/
32		public function testNewTypeDeclaration($type, $lastVersionBefore, $line, $okVersion)
33		{
34		$file = $this->sniffFile(self::TEST_FILE, $lastVersionBefore);
35		$this->assertError($file, $line, "'{$type}' type declaration is not present in PHP version {$lastVersionBefore} or earlier");
36
37		$file = $this->sniffFile(self::TEST_FILE, $okVersion);
38		$this->assertNoViolation($file, $line);
39		}
40
41		/**
42		* Data provider.
43		*
44		* @see testNewTypeDeclaration()
45		*
46		* @return array
47		*/
48		public function dataNewTypeDeclaration()
49		{
50		return array(
51		array('array', '5.0', 4, '5.1'),
52		array('array', '5.0', 5, '5.1'),
53		array('callable', '5.3', 9, '5.4'),
54		array('bool', '5.6', 13, '7.0'),
55		array('int', '5.6', 14, '7.0'),
56		array('float', '5.6', 15, '7.0'),
57		array('string', '5.6', 16, '7.0'),
58		);
59		}
60
61
62		/**
63		* testInvalidTypeDeclaration
64		*
65		* @group TypeDeclarations
66		*
67		* @dataProvider dataInvalidTypeDeclaration
68		*
69		* @param string $type The scalar type.
70		* @param int $line Line number on which to expect an error.
71		*
72		* @return void
73		*/
74		public function testInvalidTypeDeclaration($type, $alternative, $line)
75		{
76		$file = $this->sniffFile(self::TEST_FILE);
77		$this->assertError($file, $line, "'{$type}' is not a valid type declaration. Did you mean {$alternative} ?");
78		}
79
80		/**
81		* Data provider.
82		*
83		* @see testInvalidTypeDeclaration()
84		*
85		* @return array
86		*/
87		public function dataInvalidTypeDeclaration()
88		{
89		return array(
90		array('boolean', 'bool', 20),
91		array('integer', 'int', 21),
92		array('parent', 'self', 24),
93		array('static', 'self', 25),
94		);
95		}
96
97
98		/**
99		* testInvalidSelfTypeDeclaration
100		*
101		* @group TypeDeclarations
102		*
103		* @dataProvider dataInvalidSelfTypeDeclaration
104		*
105		* @param int $line Line number on which to expect an error.
106		*
107		* @return void
108		*/
109		public function testInvalidSelfTypeDeclaration($line)
110		{
111		$file = $this->sniffFile(self::TEST_FILE);
112		$this->assertError($file, $line, "'self' type cannot be used outside of class scope");
113		}
114
115		/**
116		* Data provider.
117		*
118		* @see testInvalidSelfTypeDeclaration()
119		*
120		* @return array
121		*/
122		public function dataInvalidSelfTypeDeclaration()
123		{
124		return array(
125		array(37),
126		array(44),
127		);
128		}
129
130
131		/**
132		* testTypeDeclaration
133		*
134		* @group TypeDeclarations
135		*
136		* @dataProvider dataTypeDeclaration
137		*
138		* @param int $line Line number on which to expect an error.
139		* @param bool $testNoViolation Whether or not to test noViolation for PHP 5.0.
140		* This covers the remaining few cases not covered
141		* by the above tests.
142		*
143		* @return void
144		*/
145	View Code Duplication	public function testTypeDeclaration($line, $testNoViolation = false)
		0 ignored issues – show Duplication introduced 2016-08-14 13:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
146		{
147		$file = $this->sniffFile(self::TEST_FILE, '4.4');
148		$this->assertError($file, $line, 'Type hints were not present in PHP 4.4 or earlier');
149
150		if ($testNoViolation === true) {
151		$file = $this->sniffFile(self::TEST_FILE, '5.0');
152		$this->assertNoViolation($file, $line);
153		}
154		}
155
156		/**
157		* Data provider.
158		*
159		* @see testTypeDeclaration()
160		*
161		* @return array
162		*/
163		public function dataTypeDeclaration()
164		{
165		return array(
166		array(4),
167		array(5),
168		array(9),
169		array(13),
170		array(14),
171		array(15),
172		array(16),
173		array(20),
174		array(21),
175		array(24),
176		array(25),
177		array(29, true),
178		array(34, true),
179		array(37),
180		array(41, true),
181		array(44),
182		);
183		}
184		}
185
186

wimg / PHPCompatibility

Pull Request — master (#168)

testInvalidTypeDeclaration() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like