NewAnonymousClassesSniff::process() - Code Metrics - Inspection of "Merge pull request #110 from wimg/php70" - wimg/PHPCompatibility - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7ae454...e4aaf3 )

by Wim

created 2016-06-28 13:06 UTC

NewAnonymousClassesSniff::process() A

↳ Parent: NewAnonymousClassesSniff

Complexity

Conditions	4
Paths	3

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
cc	4
eloc	10
c	2
b	0
f	1
nc	3
nop	2
dl	0
loc	15
rs	9.2

<?php
/**
 * PHPCompatibility_Sniffs_PHP_NewAnonymousClasses.
 *
 * PHP version 7.0
 *
 * @category  PHP
 * @package   PHPCompatibility
 * @author    Wim Godden <[email protected]>
 */

/**
 * PHPCompatibility_Sniffs_PHP_NewAnonymousClasses.
 *
 * Anonymous classes are supported in PHP 7.0
 *
 * @category  PHP
 * @package   PHPCompatibility
 * @author    Wim Godden <[email protected]>
 */
class PHPCompatibility_Sniffs_PHP_NewAnonymousClassesSniff extends PHPCompatibility_Sniff
{
    /**
     * Returns an array of tokens this test wants to listen for.
     *
     * @return array
     */
    public function register()
    {
        if (version_compare(PHP_CodeSniffer::VERSION, '2.3.4') >= 0) {
            return array(T_NEW);
        } else {
            return array();
        }
    }//end register()


    /**
     * Processes this test, when one of its tokens is encountered.
     *
     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
     * @param int                  $stackPtr  The position of the current token in the
     *                                        stack passed in $tokens.
     *
     * @return void
     */
    public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
    {
        $tokens = $phpcsFile->getTokens();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $whitespace = $phpcsFile->findNext(T_WHITESPACE, $stackPtr + 1, $stackPtr + 2);
        $class = $phpcsFile->findNext(T_ANON_CLASS, $stackPtr + 2, $stackPtr + 3);
        if ($whitespace == false || $class == false) {

            return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }
        
        if ($this->supportsAbove('7.0')) {
            return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        } else {
            $phpcsFile->addError('Anonymous classes are not supported in PHP 5.6 or earlier', $stackPtr);
        }
    }//end process()


}//end class


1			<?php
2			/**
3			* PHPCompatibility_Sniffs_PHP_NewAnonymousClasses.
4			*
5			* PHP version 7.0
6			*
7			* @category PHP
8			* @package PHPCompatibility
9			* @author Wim Godden <[email protected]>
10			*/
11
12			/**
13			* PHPCompatibility_Sniffs_PHP_NewAnonymousClasses.
14			*
15			* Anonymous classes are supported in PHP 7.0
16			*
17			* @category PHP
18			* @package PHPCompatibility
19			* @author Wim Godden <[email protected]>
20			*/
21			class PHPCompatibility_Sniffs_PHP_NewAnonymousClassesSniff extends PHPCompatibility_Sniff
22			{
23			/**
24			* Returns an array of tokens this test wants to listen for.
25			*
26			* @return array
27			*/
28			public function register()
29			{
30			if (version_compare(PHP_CodeSniffer::VERSION, '2.3.4') >= 0) {
31			return array(T_NEW);
32			} else {
33			return array();
34			}
35			}//end register()
36
37
38			/**
39			* Processes this test, when one of its tokens is encountered.
40			*
41			* @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
42			* @param int $stackPtr The position of the current token in the
43			* stack passed in $tokens.
44			*
45			* @return void
46			*/
47			public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
48			{
49			$tokens = $phpcsFile->getTokens();
			0 ignored issues – show Unused Code introduced 2016-06-24 10:00 UTC by Report Bug Copy Issue Report `$tokens` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
50			$whitespace = $phpcsFile->findNext(T_WHITESPACE, $stackPtr + 1, $stackPtr + 2);
51			$class = $phpcsFile->findNext(T_ANON_CLASS, $stackPtr + 2, $stackPtr + 3);
52			if ($whitespace == false \|\| $class == false) {
			0 ignored issues – show Bug Best Practice introduced 2016-06-24 10:00 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$whitespace` of type `integer\|false` against `false`; this is ambiguous if the integer can be zero. Consider using a strict comparison `===` instead. Loading history... Bug Best Practice introduced 2016-06-24 10:00 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$class` of type `integer\|false` against `false`; this is ambiguous if the integer can be zero. Consider using a strict comparison `===` instead. Loading history...
53			return false;
			0 ignored issues – show Bug Best Practice introduced 2016-06-24 10:00 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type declared by the interface `PHP_CodeSniffer_Sniff::process` of type `null\|integer`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
54			}
55
56			if ($this->supportsAbove('7.0')) {
57			return false;
			0 ignored issues – show Bug Best Practice introduced 2016-06-24 10:00 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type declared by the interface `PHP_CodeSniffer_Sniff::process` of type `null\|integer`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
58			} else {
59			$phpcsFile->addError('Anonymous classes are not supported in PHP 5.6 or earlier', $stackPtr);
60			}
61			}//end process()
62
63
64			}//end class
65

wimg / PHPCompatibility

Push — master ( 7ae454...e4aaf3 )

NewAnonymousClassesSniff::process() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like