PHPCompatibility_Sniffs_PHP_NewNowdocSniff - Code Metrics - Inspection of "PHP 5.3: Detect NOWDOC syntax" - wimg/PHPCompatibility - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#335)

by Juliette

created 2017-01-26 10:59 UTC

PHPCompatibility_Sniffs_PHP_NewNowdocSniff A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	80
Duplicated Lines	7.5 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
wmc	14
lcom	0
cbo	2
dl	6
loc	80
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	register()	0	16	3
C	process()	6	41	11

How to fix Duplicated Code

<?php
/**
 * PHPCompatibility_Sniffs_PHP_NewNowdocSniff.
 *
 * PHP version 5.3
 *
 * @category  PHP
 * @package   PHPCompatibility
 * @author    Juliette Reinders Folmer <[email protected]>
 */

/**
 * PHPCompatibility_Sniffs_PHP_NewNowdocSniff.
 *
 * @category  PHP
 * @package   PHPCompatibility
 * @author    Juliette Reinders Folmer <[email protected]>
 */
class PHPCompatibility_Sniffs_PHP_NewNowdocSniff extends PHPCompatibility_Sniff
namespace YourVendor;

class YourClass { }
{

    /**
     * Returns an array of tokens this test wants to listen for.
     *
     * @return array
     */
    public function register()
    {
        $targets = array(
            T_SL,
        );

        if (defined('T_START_NOWDOC')) {
            $targets[] = constant('T_START_NOWDOC');
        }
        if (defined('T_END_NOWDOC')) {
            $targets[] = constant('T_END_NOWDOC');
        }

        return $targets;

    }//end register()


    /**
     * Processes this test, when one of its tokens is encountered.
     *
     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
     * @param int                  $stackPtr  The position of the current token in
     *                                        the stack passed in $tokens.
     *
     * @return int|void On older PHP versions passes a pointer to the nowdoc closer
     *                  to skip passed anything in between in regards to processing
     *                  the file for this sniff.
     */
    public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
    {
        if ($this->supportsBelow('5.2') === false) {
            return;
        }

        $tokens    = $phpcsFile->getTokens();
        $tokenType = $tokens[$stackPtr]['type'];
        $isOldPhp  = (PHP_VERSION_ID < 50300);

        /*
         * In PHP 5.2 the T_NOWDOC tokens aren't recognized yet and PHPCS does not
         * backfill for it, so we have to sniff for a specific combination of tokens.
         */
        if ($isOldPhp === true && $tokenType === 'T_SL' ) {
            if (isset($tokens[($stackPtr+1)]) === false || $tokens[($stackPtr+1)]['type'] !== 'T_LESS_THAN') {

                return;
            }

            if (isset($tokens[($stackPtr+2)]) === false || $tokens[($stackPtr+2)]['type'] !== 'T_CONSTANT_ENCAPSED_STRING') {

                return;
            }

            if (preg_match('`^\'([a-z][a-z0-9_]*)\'$`iD', $tokens[($stackPtr+2)]['content'], $matches ) < 1) {
                return;
            }

            $closer = $phpcsFile->findNext(T_STRING, ($stackPtr + 3), null, false, $matches[1], true);
            if ($closer === false) {
                return;
            }
        }

        $phpcsFile->addError( 'Nowdocs are not present in PHP version 5.2 or earlier.', $stackPtr, 'Found' );

        if (isset($closer) !== false) {
            $phpcsFile->addError( 'Nowdocs are not present in PHP version 5.2 or earlier.', $closer, 'Found' );
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            return ($closer + 1);
        }

    }//end process()

}//end class


1		<?php
2		/**
3		* PHPCompatibility_Sniffs_PHP_NewNowdocSniff.
4		*
5		* PHP version 5.3
6		*
7		* @category PHP
8		* @package PHPCompatibility
9		* @author Juliette Reinders Folmer <[email protected]>
10		*/
11
12		/**
13		* PHPCompatibility_Sniffs_PHP_NewNowdocSniff.
14		*
15		* @category PHP
16		* @package PHPCompatibility
17		* @author Juliette Reinders Folmer <[email protected]>
18		*/
19		class PHPCompatibility_Sniffs_PHP_NewNowdocSniff extends PHPCompatibility_Sniff
		0 ignored issues – show Coding Style Compatibility introduced 2017-01-26 11:06 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
20		{
21
22		/**
23		* Returns an array of tokens this test wants to listen for.
24		*
25		* @return array
26		*/
27		public function register()
28		{
29		$targets = array(
30		T_SL,
31		);
32
33		if (defined('T_START_NOWDOC')) {
34		$targets[] = constant('T_START_NOWDOC');
35		}
36		if (defined('T_END_NOWDOC')) {
37		$targets[] = constant('T_END_NOWDOC');
38		}
39
40		return $targets;
41
42		}//end register()
43
44
45		/**
46		* Processes this test, when one of its tokens is encountered.
47		*
48		* @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
49		* @param int $stackPtr The position of the current token in
50		* the stack passed in $tokens.
51		*
52		* @return int\|void On older PHP versions passes a pointer to the nowdoc closer
53		* to skip passed anything in between in regards to processing
54		* the file for this sniff.
55		*/
56		public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
57		{
58		if ($this->supportsBelow('5.2') === false) {
59		return;
60		}
61
62		$tokens = $phpcsFile->getTokens();
63		$tokenType = $tokens[$stackPtr]['type'];
64		$isOldPhp = (PHP_VERSION_ID < 50300);
65
66		/*
67		* In PHP 5.2 the T_NOWDOC tokens aren't recognized yet and PHPCS does not
68		* backfill for it, so we have to sniff for a specific combination of tokens.
69		*/
70		if ($isOldPhp === true && $tokenType === 'T_SL' ) {
71	View Code Duplication	if (isset($tokens[($stackPtr+1)]) === false \|\| $tokens[($stackPtr+1)]['type'] !== 'T_LESS_THAN') {
		1 ignored issue – show Duplication introduced 2017-01-26 11:06 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
72		return;
73		}
74
75	View Code Duplication	if (isset($tokens[($stackPtr+2)]) === false \|\| $tokens[($stackPtr+2)]['type'] !== 'T_CONSTANT_ENCAPSED_STRING') {
		1 ignored issue – show Duplication introduced 2017-01-26 11:06 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
76		return;
77		}
78
79		if (preg_match('`^\'([a-z][a-z0-9_]*)\'$`iD', $tokens[($stackPtr+2)]['content'], $matches ) < 1) {
80		return;
81		}
82
83		$closer = $phpcsFile->findNext(T_STRING, ($stackPtr + 3), null, false, $matches[1], true);
84		if ($closer === false) {
85		return;
86		}
87		}
88
89		$phpcsFile->addError( 'Nowdocs are not present in PHP version 5.2 or earlier.', $stackPtr, 'Found' );
90
91		if (isset($closer) !== false) {
92		$phpcsFile->addError( 'Nowdocs are not present in PHP version 5.2 or earlier.', $closer, 'Found' );
		1 ignored issue – show Bug introduced 2017-01-26 11:06 UTC by Report Bug Copy Issue Report The variable `$closer` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
93		return ($closer + 1);
94		}
95
96		}//end process()
97
98		}//end class
99

wimg / PHPCompatibility

Pull Request — master (#335)

PHPCompatibility_Sniffs_PHP_NewNowdocSniff A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like