wimg /
PHPCompatibility
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like PHPCompatibility_Sniff often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use PHPCompatibility_Sniff, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 22 | abstract class PHPCompatibility_Sniff implements PHP_CodeSniffer_Sniff |
||
|
|
|||
| 23 | { |
||
| 24 | |||
| 25 | /* The testVersion configuration variable may be in any of the following formats: |
||
| 26 | * 1) Omitted/empty, in which case no version is specified. This effectively |
||
| 27 | * disables all the checks provided by this standard. |
||
| 28 | * 2) A single PHP version number, e.g. "5.4" in which case the standard checks that |
||
| 29 | * the code will run on that version of PHP (no deprecated features or newer |
||
| 30 | * features being used). |
||
| 31 | * 3) A range, e.g. "5.0-5.5", in which case the standard checks the code will run |
||
| 32 | * on all PHP versions in that range, and that it doesn't use any features that |
||
| 33 | * were deprecated by the final version in the list, or which were not available |
||
| 34 | * for the first version in the list. |
||
| 35 | * PHP version numbers should always be in Major.Minor format. Both "5", "5.3.2" |
||
| 36 | * would be treated as invalid, and ignored. |
||
| 37 | * This standard doesn't support checking against PHP4, so the minimum version that |
||
| 38 | * is recognised is "5.0". |
||
| 39 | */ |
||
| 40 | |||
| 41 | private function getTestVersion() |
||
| 42 | { |
||
| 43 | /** |
||
| 44 | * var $arrTestVersions will hold an array containing min/max version of PHP |
||
| 45 | * that we are checking against (see above). If only a single version |
||
| 46 | * number is specified, then this is used as both the min and max. |
||
| 47 | */ |
||
| 48 | static $arrTestVersions = array(); |
||
| 49 | |||
| 50 | $testVersion = trim(PHP_CodeSniffer::getConfigData('testVersion')); |
||
| 51 | |||
| 52 | if (!isset($arrTestVersions[$testVersion]) && !empty($testVersion)) { |
||
| 53 | |||
| 54 | $arrTestVersions[$testVersion] = array(null, null); |
||
| 55 | if (preg_match('/^\d+\.\d+$/', $testVersion)) { |
||
| 56 | $arrTestVersions[$testVersion] = array($testVersion, $testVersion); |
||
| 57 | } |
||
| 58 | elseif (preg_match('/^(\d+\.\d+)\s*-\s*(\d+\.\d+)$/', $testVersion, |
||
| 59 | $matches)) |
||
| 60 | { |
||
| 61 | if (version_compare($matches[1], $matches[2], '>')) { |
||
| 62 | trigger_error("Invalid range in testVersion setting: '" |
||
| 63 | . $testVersion . "'", E_USER_WARNING); |
||
| 64 | } |
||
| 65 | else { |
||
| 66 | $arrTestVersions[$testVersion] = array($matches[1], $matches[2]); |
||
| 67 | } |
||
| 68 | } |
||
| 69 | elseif (!$testVersion == '') { |
||
| 70 | trigger_error("Invalid testVersion setting: '" . $testVersion |
||
| 71 | . "'", E_USER_WARNING); |
||
| 72 | } |
||
| 73 | } |
||
| 74 | |||
| 75 | if (isset($arrTestVersions[$testVersion])) { |
||
| 76 | return $arrTestVersions[$testVersion]; |
||
| 77 | } |
||
| 78 | else { |
||
| 79 | return array(null, null); |
||
| 80 | } |
||
| 81 | } |
||
| 82 | |||
| 83 | View Code Duplication | public function supportsAbove($phpVersion) |
|
| 84 | { |
||
| 85 | $testVersion = $this->getTestVersion(); |
||
| 86 | $testVersion = $testVersion[1]; |
||
| 87 | |||
| 88 | if (is_null($testVersion) |
||
| 89 | || version_compare($testVersion, $phpVersion) >= 0 |
||
| 90 | ) { |
||
| 91 | return true; |
||
| 92 | } else { |
||
| 93 | return false; |
||
| 94 | } |
||
| 95 | }//end supportsAbove() |
||
| 96 | |||
| 97 | View Code Duplication | public function supportsBelow($phpVersion) |
|
| 98 | { |
||
| 99 | $testVersion = $this->getTestVersion(); |
||
| 100 | $testVersion = $testVersion[0]; |
||
| 101 | |||
| 102 | if (!is_null($testVersion) |
||
| 103 | && version_compare($testVersion, $phpVersion) <= 0 |
||
| 104 | ) { |
||
| 105 | return true; |
||
| 106 | } else { |
||
| 107 | return false; |
||
| 108 | } |
||
| 109 | }//end supportsBelow() |
||
| 110 | |||
| 111 | /** |
||
| 112 | * Returns the name(s) of the interface(s) that the specified class implements. |
||
| 113 | * |
||
| 114 | * Returns FALSE on error or if there are no implemented interface names. |
||
| 115 | * |
||
| 116 | * {@internal Duplicate of same method as introduced in PHPCS 2.7. |
||
| 117 | * Once the minimum supported PHPCS version for this sniff library goes beyond |
||
| 118 | * that, this method can be removed and call to it replaced with |
||
| 119 | * `$phpcsFile->findImplementedInterfaceNames($stackPtr)` calls.}} |
||
| 120 | * |
||
| 121 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 122 | * @param int $stackPtr The position of the class token. |
||
| 123 | * |
||
| 124 | * @return array|false |
||
| 125 | */ |
||
| 126 | public function findImplementedInterfaceNames($phpcsFile, $stackPtr) |
||
| 169 | |||
| 170 | |||
| 171 | /** |
||
| 172 | * Checks if a function call has parameters. |
||
| 173 | * |
||
| 174 | * Expects to be passed the T_STRING stack pointer for the function call. |
||
| 175 | * If passed a T_STRING which is *not* a function call, the behaviour is unreliable. |
||
| 176 | * |
||
| 177 | * @link https://github.com/wimg/PHPCompatibility/issues/120 |
||
| 178 | * @link https://github.com/wimg/PHPCompatibility/issues/152 |
||
| 179 | * |
||
| 180 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 181 | * @param int $stackPtr The position of the function call token. |
||
| 182 | * |
||
| 183 | * @return bool |
||
| 184 | */ |
||
| 185 | public function doesFunctionCallHaveParameters(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 218 | |||
| 219 | |||
| 220 | /** |
||
| 221 | * Count the number of parameters a function call has been passed. |
||
| 222 | * |
||
| 223 | * Expects to be passed the T_STRING stack pointer for the function call. |
||
| 224 | * If passed a T_STRING which is *not* a function call, the behaviour is unreliable. |
||
| 225 | * |
||
| 226 | * @link https://github.com/wimg/PHPCompatibility/issues/111 |
||
| 227 | * @link https://github.com/wimg/PHPCompatibility/issues/114 |
||
| 228 | * @link https://github.com/wimg/PHPCompatibility/issues/151 |
||
| 229 | * |
||
| 230 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 231 | * @param int $stackPtr The position of the function call token. |
||
| 232 | * |
||
| 233 | * @return int |
||
| 234 | */ |
||
| 235 | public function getFunctionCallParameterCount(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 277 | |||
| 278 | |||
| 279 | /** |
||
| 280 | * Verify whether a token is within a scoped condition. |
||
| 281 | * |
||
| 282 | * If the optional $validScopes parameter has been passed, the function |
||
| 283 | * will check that the token has at least one condition which is of a |
||
| 284 | * type defined in $validScopes. |
||
| 285 | * |
||
| 286 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 287 | * @param int $stackPtr The position of the token. |
||
| 288 | * @param array|int $validScopes Optional. Array of valid scopes |
||
| 289 | * or int value of a valid scope. |
||
| 290 | * |
||
| 291 | * @return bool Without the optional $scopeTypes: True if within a scope, false otherwise. |
||
| 292 | * If the $scopeTypes are set: True if *one* of the conditions is a |
||
| 293 | * valid scope, false otherwise. |
||
| 294 | */ |
||
| 295 | public function tokenHasScope(PHP_CodeSniffer_File $phpcsFile, $stackPtr, $validScopes = null) |
||
| 333 | |||
| 334 | |||
| 335 | /** |
||
| 336 | * Verify whether a token is within a class scope. |
||
| 337 | * |
||
| 338 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 339 | * @param int $stackPtr The position of the token. |
||
| 340 | * @param bool $strict Whether to strictly check for the T_CLASS |
||
| 341 | * scope or also accept interfaces and traits |
||
| 342 | * as scope. |
||
| 343 | * |
||
| 344 | * @return bool True if within class scope, false otherwise. |
||
| 345 | */ |
||
| 346 | public function inClassScope(PHP_CodeSniffer_File $phpcsFile, $stackPtr, $strict = true) |
||
| 356 | |||
| 357 | |||
| 358 | /** |
||
| 359 | * Returns the fully qualified class name for a new class instantiation. |
||
| 360 | * |
||
| 361 | * Returns an empty string if the class name could not be reliably inferred. |
||
| 362 | * |
||
| 363 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 364 | * @param int $stackPtr The position of a T_NEW token. |
||
| 365 | * |
||
| 366 | * @return string |
||
| 367 | */ |
||
| 368 | public function getFQClassNameFromNewToken(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 395 | |||
| 396 | |||
| 397 | /** |
||
| 398 | * Returns the fully qualified name of the class that the specified class extends. |
||
| 399 | * |
||
| 400 | * Returns an empty string if the class does not extend another class or if |
||
| 401 | * the class name could not be reliably inferred. |
||
| 402 | * |
||
| 403 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 404 | * @param int $stackPtr The position of a T_CLASS token. |
||
| 405 | * |
||
| 406 | * @return string |
||
| 407 | */ |
||
| 408 | public function getFQExtendedClassName(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 428 | |||
| 429 | |||
| 430 | /** |
||
| 431 | * Returns the class name for the static usage of a class. |
||
| 432 | * This can be a call to a method, the use of a property or constant. |
||
| 433 | * |
||
| 434 | * Returns an empty string if the class name could not be reliably inferred. |
||
| 435 | * |
||
| 436 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 437 | * @param int $stackPtr The position of a T_NEW token. |
||
| 438 | * |
||
| 439 | * @return string |
||
| 440 | */ |
||
| 441 | public function getFQClassNameFromDoubleColonToken(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 482 | |||
| 483 | |||
| 484 | /** |
||
| 485 | * Get the Fully Qualified name for a class/function/constant etc. |
||
| 486 | * |
||
| 487 | * Checks if a class/function/constant name is already fully qualified and |
||
| 488 | * if not, enrich it with the relevant namespace information. |
||
| 489 | * |
||
| 490 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 491 | * @param int $stackPtr The position of the token. |
||
| 492 | * @param string $name The class / function / constant name. |
||
| 493 | * |
||
| 494 | * @return string |
||
| 495 | */ |
||
| 496 | public function getFQName(PHP_CodeSniffer_File $phpcsFile, $stackPtr, $name) |
||
| 517 | |||
| 518 | |||
| 519 | /** |
||
| 520 | * Is the class/function/constant name namespaced or global ? |
||
| 521 | * |
||
| 522 | * @param string $FQName Fully Qualified name of a class, function etc. |
||
| 523 | * I.e. should always start with a `\` ! |
||
| 524 | * |
||
| 525 | * @return bool True if namespaced, false if global. |
||
| 526 | */ |
||
| 527 | public function isNamespaced($FQName) { |
||
| 534 | |||
| 535 | |||
| 536 | /** |
||
| 537 | * Determine the namespace name an arbitrary token lives in. |
||
| 538 | * |
||
| 539 | * @param PHP_CodeSniffer_File $phpcsFile Instance of phpcsFile. |
||
| 540 | * @param int $stackPtr The token position for which to determine the namespace. |
||
| 541 | * |
||
| 542 | * @return string Namespace name or empty string if it couldn't be determined or no namespace applies. |
||
| 543 | */ |
||
| 544 | public function determineNamespace(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 594 | |||
| 595 | /** |
||
| 596 | * Get the complete namespace name for a namespace declaration. |
||
| 597 | * |
||
| 598 | * For hierarchical namespaces, the name will be composed of several tokens, |
||
| 599 | * i.e. MyProject\Sub\Level which will be returned together as one string. |
||
| 600 | * |
||
| 601 | * @param PHP_CodeSniffer_File $phpcsFile Instance of phpcsFile. |
||
| 602 | * @param int|bool $stackPtr The position of a T_NAMESPACE token. |
||
| 603 | * |
||
| 604 | * @return string|false Namespace name or false if not a namespace declaration. |
||
| 605 | * Namespace name can be an empty string for global namespace declaration. |
||
| 606 | */ |
||
| 607 | public function getDeclaredNamespaceName(PHP_CodeSniffer_File $phpcsFile, $stackPtr ) |
||
| 647 | |||
| 648 | |||
| 649 | /** |
||
| 650 | * Returns the method parameters for the specified T_FUNCTION token. |
||
| 651 | * |
||
| 652 | * Each parameter is in the following format: |
||
| 653 | * |
||
| 654 | * <code> |
||
| 655 | * 0 => array( |
||
| 656 | * 'name' => '$var', // The variable name. |
||
| 657 | * 'pass_by_reference' => false, // Passed by reference. |
||
| 658 | * 'type_hint' => string, // Type hint for array or custom type |
||
| 659 | * ) |
||
| 660 | * </code> |
||
| 661 | * |
||
| 662 | * Parameters with default values have an additional array index of |
||
| 663 | * 'default' with the value of the default as a string. |
||
| 664 | * |
||
| 665 | * {@internal Duplicate of same method as contained in the `PHP_CodeSniffer_File` |
||
| 666 | * class, but with some improvements which were only introduced in PHPCS 2.7. |
||
| 667 | * Once the minimum supported PHPCS version for this sniff library goes beyond |
||
| 668 | * that, this method can be removed and calls to it replaced with |
||
| 669 | * `$phpcsFile->getMethodParameters($stackPtr)` calls.}} |
||
| 670 | * |
||
| 671 | * @param PHP_CodeSniffer_File $phpcsFile Instance of phpcsFile. |
||
| 672 | * @param int $stackPtr The position in the stack of the T_FUNCTION token |
||
| 673 | * to acquire the parameters for. |
||
| 674 | * |
||
| 675 | * @return array |
||
| 676 | * @throws PHP_CodeSniffer_Exception If the specified $stackPtr is not of |
||
| 677 | * type T_FUNCTION. |
||
| 678 | */ |
||
| 679 | public function getMethodParameters(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 824 | |||
| 825 | }//end class |
||
| 826 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.