PregReplaceEModifierSniff::processRegexPattern() - Code Metrics - Inspection of "Docs: Remove trailing space in empty XML tag" - wimg/PHPCompatibility - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#490)

by Gary

created 2017-07-21 08:03 UTC

PregReplaceEModifierSniff::processRegexPattern() C

↳ Parent: PregReplaceEModifierSniff

Complexity

Conditions	11
Paths	80

Size

Total Lines	63
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	63
rs	6.1137
c	0
b	0
f	0
cc	11
eloc	32
nc	80
nop	4

How to fix Long Method Complexity

<?php
/**
 * \PHPCompatibility\Sniffs\PHP\PregReplaceEModifierSniff.
 *
 * PHP version 5.5
 *
 * @category  PHP
 * @package   PHPCompatibility
 * @author    Wim Godden <[email protected]>
 * @copyright 2014 Cu.be Solutions bvba
 */

namespace PHPCompatibility\Sniffs\PHP;

use PHPCompatibility\Sniff;

/**
 * \PHPCompatibility\Sniffs\PHP\PregReplaceEModifierSniff.
 *
 * Check for usage of the `e` modifier with PCRE functions which is deprecated since PHP 5.5
 * and removed as of PHP 7.0.
 *
 * PHP version 5.5
 *
 * @category  PHP
 * @package   PHPCompatibility
 * @author    Wim Godden <[email protected]>
 * @copyright 2014 Cu.be Solutions bvba
 */
class PregReplaceEModifierSniff extends Sniff
{

    /**
     * Functions to check for.
     *
     * @var array
     */
    protected $functions = array(
        'preg_replace' => true,
        'preg_filter'  => true,
    );

    /**
     * Regex bracket delimiters.
     *
     * @var array
     */
    protected $doublesSeparators = array(
        '{' => '}',
        '[' => ']',
        '(' => ')',
        '<' => '>',
    );

    /**
     * Returns an array of tokens this test wants to listen for.
     *
     * @return array
     */
    public function register()
    {
        return array(T_STRING);
    }//end register()

    /**
     * Processes this test, when one of its tokens is encountered.
     *
     * @param \PHP_CodeSniffer_File $phpcsFile The file being scanned.
     * @param int                   $stackPtr  The position of the current token in the
     *                                         stack passed in $tokens.
     *
     * @return void
     */
    public function process(\PHP_CodeSniffer_File $phpcsFile, $stackPtr)
    {
        if ($this->supportsAbove('5.5') === false) {
            return;
        }

        $tokens         = $phpcsFile->getTokens();
        $functionName   = $tokens[$stackPtr]['content'];
        $functionNameLc = strtolower($functionName);

        // Bow out if not one of the functions we're targetting.
        if (isset($this->functions[$functionNameLc]) === false) {
            return;
        }

        // Get the first parameter in the function call as that should contain the regex(es).
        $firstParam = $this->getFunctionCallParameter($phpcsFile, $stackPtr, 1);
        if ($firstParam === false) {
            return;
        }

        // Differentiate between an array of patterns passed and a single pattern.
        $nextNonEmpty = $phpcsFile->findNext(\PHP_CodeSniffer_Tokens::$emptyTokens, $firstParam['start'], ($firstParam['end'] +1), true);
        if ($nextNonEmpty !== false && ($tokens[$nextNonEmpty]['code'] === T_ARRAY || $tokens[$nextNonEmpty]['code'] === T_OPEN_SHORT_ARRAY)) {
            $arrayValues = $this->getFunctionCallParameters($phpcsFile, $nextNonEmpty);
            foreach ($arrayValues as $value) {
                $hasKey = $phpcsFile->findNext(T_DOUBLE_ARROW, $value['start'], ($value['end'] + 1));
                if ($hasKey !== false) {
                    $value['start'] = ($hasKey + 1);
                    $value['raw']   = trim($phpcsFile->getTokensAsString($value['start'], (($value['end'] + 1) - $value['start'])));
                }

                $this->processRegexPattern($value, $phpcsFile, $value['end'], $functionName);
            }

        } else {
            $this->processRegexPattern($firstParam, $phpcsFile, $stackPtr, $functionName);
        }

    }//end process()


    /**
     * Analyse a potential regex pattern for usage of the /e modifier.
     *
     * @param array                 $pattern      Array containing the start and end token
     *                                            pointer of the potential regex pattern and
     *                                            the raw string value of the pattern.
     * @param \PHP_CodeSniffer_File $phpcsFile    The file being scanned.
     * @param int                   $stackPtr     The position of the current token in the
     *                                            stack passed in $tokens.
     * @param string                $functionName The function which contained the pattern.
     *
     * @return void
     */
    protected function processRegexPattern($pattern, \PHP_CodeSniffer_File $phpcsFile, $stackPtr, $functionName)
    {
        $tokens = $phpcsFile->getTokens();

        /*
         * The pattern might be build up of a combination of strings, variables
         * and function calls. We are only concerned with the strings.
         */
        $regex = '';
        for ($i = $pattern['start']; $i <= $pattern['end']; $i++) {
            if (in_array($tokens[$i]['code'], \PHP_CodeSniffer_Tokens::$stringTokens, true) === true) {
                $content = $this->stripQuotes($tokens[$i]['content']);
                if ($tokens[$i]['code'] === T_DOUBLE_QUOTED_STRING) {
                    $content = $this->stripVariables($content);
                }

                $regex .= trim($content);
            }
        }

        // Deal with multi-line regexes which were broken up in several string tokens.
        if ($tokens[$pattern['start']]['line'] !== $tokens[$pattern['end']]['line']) {
            $regex = $this->stripQuotes($regex);
        }

        if ($regex === '') {
            // No string token found in the first parameter, so skip it (e.g. if variable passed in).
            return;
        }

        $regexFirstChar = substr($regex, 0, 1);

        // Make sure that the character identified as the delimiter is valid.
        // Otherwise, it is a false positive caused by the string concatenation.
        if (preg_match('`[a-z0-9\\\\ ]`i', $regexFirstChar) === 1) {
            return;
        }

        if (isset($this->doublesSeparators[$regexFirstChar])) {
            $regexEndPos = strrpos($regex, $this->doublesSeparators[$regexFirstChar]);
        } else {
            $regexEndPos = strrpos($regex, $regexFirstChar);
        }

        if ($regexEndPos !== false) {
            $modifiers = substr($regex, $regexEndPos + 1);

            if (strpos($modifiers, 'e') !== false) {
                $error     = '%s() - /e modifier is deprecated since PHP 5.5';
                $isError   = false;
                $errorCode = 'Deprecated';
                $data      = array($functionName);

                if ($this->supportsAbove('7.0')) {
                    $error    .= ' and removed since PHP 7.0';
                    $isError   = true;
                    $errorCode = 'Removed';
                }

                $this->addMessage($phpcsFile, $error, $stackPtr, $isError, $errorCode, $data);
            }
        }
    }//end processRegexPattern()

}//end class


1			<?php
2			/**
3			* \PHPCompatibility\Sniffs\PHP\PregReplaceEModifierSniff.
4			*
5			* PHP version 5.5
6			*
7			* @category PHP
8			* @package PHPCompatibility
9			* @author Wim Godden <[email protected]>
10			* @copyright 2014 Cu.be Solutions bvba
11			*/
12
13			namespace PHPCompatibility\Sniffs\PHP;
14
15			use PHPCompatibility\Sniff;
16
17			/**
18			* \PHPCompatibility\Sniffs\PHP\PregReplaceEModifierSniff.
19			*
20			* Check for usage of the `e` modifier with PCRE functions which is deprecated since PHP 5.5
21			* and removed as of PHP 7.0.
22			*
23			* PHP version 5.5
24			*
25			* @category PHP
26			* @package PHPCompatibility
27			* @author Wim Godden <[email protected]>
28			* @copyright 2014 Cu.be Solutions bvba
29			*/
30			class PregReplaceEModifierSniff extends Sniff
31			{
32
33			/**
34			* Functions to check for.
35			*
36			* @var array
37			*/
38			protected $functions = array(
39			'preg_replace' => true,
40			'preg_filter' => true,
41			);
42
43			/**
44			* Regex bracket delimiters.
45			*
46			* @var array
47			*/
48			protected $doublesSeparators = array(
49			'{' => '}',
50			'[' => ']',
51			'(' => ')',
52			'<' => '>',
53			);
54
55			/**
56			* Returns an array of tokens this test wants to listen for.
57			*
58			* @return array
59			*/
60			public function register()
61			{
62			return array(T_STRING);
63			}//end register()
64
65			/**
66			* Processes this test, when one of its tokens is encountered.
67			*
68			* @param \PHP_CodeSniffer_File $phpcsFile The file being scanned.
69			* @param int $stackPtr The position of the current token in the
70			* stack passed in $tokens.
71			*
72			* @return void
73			*/
74			public function process(\PHP_CodeSniffer_File $phpcsFile, $stackPtr)
75			{
76			if ($this->supportsAbove('5.5') === false) {
77			return;
78			}
79
80			$tokens = $phpcsFile->getTokens();
81			$functionName = $tokens[$stackPtr]['content'];
82			$functionNameLc = strtolower($functionName);
83
84			// Bow out if not one of the functions we're targetting.
85			if (isset($this->functions[$functionNameLc]) === false) {
86			return;
87			}
88
89			// Get the first parameter in the function call as that should contain the regex(es).
90			$firstParam = $this->getFunctionCallParameter($phpcsFile, $stackPtr, 1);
91			if ($firstParam === false) {
92			return;
93			}
94
95			// Differentiate between an array of patterns passed and a single pattern.
96			$nextNonEmpty = $phpcsFile->findNext(\PHP_CodeSniffer_Tokens::$emptyTokens, $firstParam['start'], ($firstParam['end'] +1), true);
97			if ($nextNonEmpty !== false && ($tokens[$nextNonEmpty]['code'] === T_ARRAY \|\| $tokens[$nextNonEmpty]['code'] === T_OPEN_SHORT_ARRAY)) {
98			$arrayValues = $this->getFunctionCallParameters($phpcsFile, $nextNonEmpty);
99			foreach ($arrayValues as $value) {
100			$hasKey = $phpcsFile->findNext(T_DOUBLE_ARROW, $value['start'], ($value['end'] + 1));
101			if ($hasKey !== false) {
102			$value['start'] = ($hasKey + 1);
103			$value['raw'] = trim($phpcsFile->getTokensAsString($value['start'], (($value['end'] + 1) - $value['start'])));
104			}
105
106			$this->processRegexPattern($value, $phpcsFile, $value['end'], $functionName);
107			}
108
109			} else {
110			$this->processRegexPattern($firstParam, $phpcsFile, $stackPtr, $functionName);
111			}
112
113			}//end process()
114
115
116			/**
117			* Analyse a potential regex pattern for usage of the /e modifier.
118			*
119			* @param array $pattern Array containing the start and end token
120			* pointer of the potential regex pattern and
121			* the raw string value of the pattern.
122			* @param \PHP_CodeSniffer_File $phpcsFile The file being scanned.
123			* @param int $stackPtr The position of the current token in the
124			* stack passed in $tokens.
125			* @param string $functionName The function which contained the pattern.
126			*
127			* @return void
128			*/
129			protected function processRegexPattern($pattern, \PHP_CodeSniffer_File $phpcsFile, $stackPtr, $functionName)
130			{
131			$tokens = $phpcsFile->getTokens();
132
133			/*
134			* The pattern might be build up of a combination of strings, variables
135			* and function calls. We are only concerned with the strings.
136			*/
137			$regex = '';
138			for ($i = $pattern['start']; $i <= $pattern['end']; $i++) {
139			if (in_array($tokens[$i]['code'], \PHP_CodeSniffer_Tokens::$stringTokens, true) === true) {
140			$content = $this->stripQuotes($tokens[$i]['content']);
141			if ($tokens[$i]['code'] === T_DOUBLE_QUOTED_STRING) {
142			$content = $this->stripVariables($content);
143			}
144
145			$regex .= trim($content);
146			}
147			}
148
149			// Deal with multi-line regexes which were broken up in several string tokens.
150			if ($tokens[$pattern['start']]['line'] !== $tokens[$pattern['end']]['line']) {
151			$regex = $this->stripQuotes($regex);
152			}
153
154			if ($regex === '') {
155			// No string token found in the first parameter, so skip it (e.g. if variable passed in).
156			return;
157			}
158
159			$regexFirstChar = substr($regex, 0, 1);
160
161			// Make sure that the character identified as the delimiter is valid.
162			// Otherwise, it is a false positive caused by the string concatenation.
163			if (preg_match('`[a-z0-9\\\\ ]`i', $regexFirstChar) === 1) {
164			return;
165			}
166
167			if (isset($this->doublesSeparators[$regexFirstChar])) {
168			$regexEndPos = strrpos($regex, $this->doublesSeparators[$regexFirstChar]);
169			} else {
170			$regexEndPos = strrpos($regex, $regexFirstChar);
171			}
172
173			if ($regexEndPos !== false) {
174			$modifiers = substr($regex, $regexEndPos + 1);
175
176			if (strpos($modifiers, 'e') !== false) {
177			$error = '%s() - /e modifier is deprecated since PHP 5.5';
178			$isError = false;
179			$errorCode = 'Deprecated';
180			$data = array($functionName);
181
182			if ($this->supportsAbove('7.0')) {
183			$error .= ' and removed since PHP 7.0';
184			$isError = true;
185			$errorCode = 'Removed';
186			}
187
188			$this->addMessage($phpcsFile, $error, $stackPtr, $isError, $errorCode, $data);
189			}
190			}
191			}//end processRegexPattern()
192
193			}//end class
194

wimg / PHPCompatibility

Pull Request — master (#490)

PregReplaceEModifierSniff::processRegexPattern() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like