Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 16 | class RemovedFunctionParameterSniffTest extends BaseSniffTest |
||
|
|
|||
| 17 | { |
||
| 18 | |||
| 19 | const TEST_FILE = 'sniff-examples/removed_function_parameter.php'; |
||
| 20 | |||
| 21 | /** |
||
| 22 | * testRemovedParameter |
||
| 23 | * |
||
| 24 | * @dataProvider dataRemovedParameter |
||
| 25 | * |
||
| 26 | * @param string $functionName Function name. |
||
| 27 | * @param string $parameterName Parameter name. |
||
| 28 | * @param string $removedIn The PHP version in which the parameter was removed. |
||
| 29 | * @param array $lines The line numbers in the test file which apply to this class. |
||
| 30 | * @param string $okVersion A PHP version in which the parameter was ok to be used. |
||
| 31 | * |
||
| 32 | * @return void |
||
| 33 | */ |
||
| 34 | View Code Duplication | public function testRemovedParameter($functionName, $parameterName, $removedIn, $lines, $okVersion) |
|
| 46 | |||
| 47 | /** |
||
| 48 | * Data provider. |
||
| 49 | * |
||
| 50 | * @see testRemovedParameter() |
||
| 51 | * |
||
| 52 | * @return array |
||
| 53 | */ |
||
| 54 | public function dataRemovedParameter() |
||
| 61 | |||
| 62 | |||
| 63 | /** |
||
| 64 | * testValidParameter |
||
| 65 | * |
||
| 66 | * @dataProvider dataValidParameter |
||
| 67 | * |
||
| 68 | * @param int $line The line number. |
||
| 69 | * |
||
| 70 | * @return void |
||
| 71 | */ |
||
| 72 | public function testValidParameter($line) |
||
| 77 | |||
| 78 | /** |
||
| 79 | * Data provider. |
||
| 80 | * |
||
| 81 | * @see testValidParameter() |
||
| 82 | * |
||
| 83 | * @return array |
||
| 84 | */ |
||
| 85 | View Code Duplication | public function dataValidParameter() |
|
| 99 | |||
| 100 | } |
||
| 101 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.