Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 16 | class RemovedGlobalVariablesSniffTest extends BaseSniffTest |
||
| 17 | { |
||
| 18 | /** |
||
| 19 | * HTTP_RAW_POST_DATA |
||
| 20 | * |
||
| 21 | * @return void |
||
| 22 | */ |
||
| 23 | public function testHttpRawPostData() |
||
| 24 | { |
||
| 25 | $file = $this->sniffFile('sniff-examples/removed_global_variables.php', '5.5'); |
||
| 26 | $this->assertNoViolation($file); |
||
| 27 | |||
| 28 | $file = $this->sniffFile('sniff-examples/removed_global_variables.php', '5.6'); |
||
| 29 | $this->assertWarning($file, 3, 'Global variable \'$HTTP_RAW_POST_DATA\' is deprecated since PHP 5.6 - use php://input instead'); |
||
| 30 | |||
| 31 | $file = $this->sniffFile('sniff-examples/removed_global_variables.php', '7.0'); |
||
| 32 | $this->assertError($file, 3, 'Global variable \'$HTTP_RAW_POST_DATA\' is deprecated since PHP 5.6 and removed since PHP 7.0 - use php://input instead'); |
||
| 33 | } |
||
| 34 | } |
||
| 35 |