wimg /
PHPCompatibility
| Conditions | 17 |
| Paths | 25 |
| Total Lines | 86 |
| Code Lines | 40 |
| Lines | 6 |
| Ratio | 6.98 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 58 | public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 59 | { |
||
| 60 | if ($this->supportsBelow('5.2') === false) { |
||
| 61 | return; |
||
| 62 | } |
||
| 63 | |||
| 64 | $tokens = $phpcsFile->getTokens(); |
||
| 65 | ini_set( 'xdebug.overload_var_dump', 1 ); |
||
| 66 | |||
| 67 | static $dumped = false; |
||
| 68 | if($dumped === false) { |
||
| 69 | echo "\n"; |
||
| 70 | foreach( $tokens as $ptr => $token ) { |
||
| 71 | if ( ! isset( $token['length'] ) ) { |
||
| 72 | $token['length'] = strlen($token['content']); |
||
| 73 | } |
||
| 74 | echo $ptr . ' :: L' . $token['line'] . ' :: C' . $token['column'] . ' :: ' . $token['type'] . ' :: (' . $token['length'] . ') :: ' . $token['content'] . "\n"; |
||
| 75 | // if ( $token['code'] === T_WHILE || $token['code'] === T_DO || $token['code'] === T_FUNCTION ) { |
||
| 76 | // var_dump( $token ); |
||
| 77 | // } |
||
| 78 | } |
||
| 79 | unset( $ptr, $token ); |
||
| 80 | $dumped = true; |
||
| 81 | var_dump( $tokens[$stackPtr] ); |
||
| 82 | } |
||
| 83 | |||
| 84 | /* |
||
| 85 | * In PHP 5.2 the T_NOWDOC tokens aren't recognized yet and PHPCS does not |
||
| 86 | * backfill for it, so we have to sniff for a specific combination of tokens. |
||
| 87 | */ |
||
| 88 | if ($tokens[$stackPtr]['code'] === T_SL) { |
||
| 89 | View Code Duplication | if (isset($tokens[($stackPtr+1)]) === false || $tokens[($stackPtr + 1)]['code'] !== T_LESS_THAN) { |
|
|
1 ignored issue
–
show
|
|||
| 90 | return; |
||
| 91 | } |
||
| 92 | |||
| 93 | View Code Duplication | if (isset($tokens[($stackPtr+2)]) === false || $tokens[($stackPtr + 2)]['code'] !== T_CONSTANT_ENCAPSED_STRING) { |
|
|
1 ignored issue
–
show
|
|||
| 94 | return; |
||
| 95 | } |
||
| 96 | |||
| 97 | /* |
||
| 98 | * Heredoc and nowdoc naming rules: |
||
| 99 | * "it must contain only alphanumeric characters and underscores and |
||
| 100 | * must start with a non-digit character or underscore" |
||
| 101 | * @link http://php.net/manual/en/language.types.string.php#language.types.string.syntax.heredoc |
||
| 102 | */ |
||
| 103 | if (preg_match('`^\'([a-z][a-z0-9_]*)\'$`iD', $tokens[($stackPtr + 2)]['content'], $matches) < 1) { |
||
| 104 | return; |
||
| 105 | } |
||
| 106 | |||
| 107 | $closer = null; |
||
| 108 | |||
| 109 | for ($i = ($stackPtr + 3); $i < $phpcsFile->numTokens; $i++) { |
||
| 110 | $maybeCloser = $phpcsFile->findNext(T_STRING, $i, null, false, $matches[1]); |
||
| 111 | if ($maybeCloser === false) { |
||
| 112 | return; |
||
| 113 | } |
||
| 114 | |||
| 115 | // The closing identifier must begin in the first column of the line. |
||
| 116 | if ($tokens[$maybeCloser]['column'] !== 1) { |
||
| 117 | continue; |
||
| 118 | } |
||
| 119 | |||
| 120 | // The closing identifier must be the only content on that line, except for maybe a semi-colon. |
||
| 121 | $next = $phpcsFile->findNext(array(T_WHITESPACE, T_SEMICOLON), ($maybeCloser + 1), null, true); |
||
| 122 | if ($tokens[$maybeCloser]['line'] === $tokens[$next]['line']) { |
||
| 123 | continue; |
||
| 124 | } |
||
| 125 | |||
| 126 | $closer = $maybeCloser; |
||
| 127 | break; |
||
| 128 | } |
||
| 129 | |||
| 130 | if (isset($closer) === false) { |
||
| 131 | // No valid closer found. |
||
| 132 | return; |
||
| 133 | } |
||
| 134 | } |
||
| 135 | |||
| 136 | $phpcsFile->addError('Nowdocs are not present in PHP version 5.2 or earlier.', $stackPtr, 'Found'); |
||
| 137 | |||
| 138 | if (isset($closer) !== false) { |
||
| 139 | $phpcsFile->addError('Nowdocs are not present in PHP version 5.2 or earlier.', $closer, 'Found'); |
||
|
1 ignored issue
–
show
|
|||
| 140 | return ($closer + 1); |
||
| 141 | } |
||
| 142 | |||
| 143 | }//end process() |
||
| 144 | |||
| 146 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.