PregReplaceEModifierSniffTest::dataNoViolation() - Code Metrics - Inspection of "Improve `PregReplaceEModifier` Sniff (code review)..." - wimg/PHPCompatibility - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#201)

by Juliette

created 2016-08-22 21:21 UTC

PregReplaceEModifierSniffTest::dataNoViolation() B

↳ Parent: PregReplaceEModifierSniffTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	29
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	29
rs	8.8571
cc	1
eloc	21
nc	1
nop	0

<?php
/**
 * preg_replace() /e modifier sniff test file
 *
 * @package PHPCompatibility
 */


/**
 * preg_replace() /e modifier sniff tests
 *
 * @uses BaseSniffTest
 * @package PHPCompatibility
 * @author Jansen Price <[email protected]>
 */
class PregReplaceEModifierSniffTest extends BaseSniffTest
namespace YourVendor;

class YourClass { }
{

    const TEST_FILE = 'sniff-examples/preg_replace_e_modifier.php';

    /**
     * testDeprecatedEModifier
     *
     * @group pregReplaceEModifier
     *
     * @dataProvider dataDeprecatedEModifier
     *
     * @param int    $line         Line number where the error should occur.
     * @param string $functionName Function name.
     *
     * @return void
     */
    public function testDeprecatedEModifier($line, $functionName = 'preg_replace')

    {
        $file = $this->sniffFile(self::TEST_FILE, '5.4');
        $this->assertNoViolation($file, $line);

        $file = $this->sniffFile(self::TEST_FILE, '5.5');
        $this->assertError($file, $line, "{$functionName}() - /e modifier is deprecated since PHP 5.5");

        $file = $this->sniffFile(self::TEST_FILE, '7.0');
        $this->assertError($file, $line, "{$functionName}() - /e modifier is forbidden since PHP 7.0");
    }

    /**
     * dataDeprecatedEModifier
     *
     * @see testDeprecatedEModifier()
     *
     * @return array
     */
    public function dataDeprecatedEModifier() {
        return array(
            // preg_replace()
            array(50),
            array(51),
            array(54),
            array(55),
            array(58),
            array(59),
            array(60),
            array(63),
            array(78),
            array(84),

            // Bracket delimiters.
            array(99),
            array(100),
            array(104),
            array(106),
            array(108),

            // preg_filter()
            array(114, 'preg_filter'),
            array(115, 'preg_filter'),
            array(118, 'preg_filter'),
            array(119, 'preg_filter'),
            array(122, 'preg_filter'),
            array(123, 'preg_filter'),
            array(124, 'preg_filter'),
            array(127, 'preg_filter'),
            array(142, 'preg_filter'),
            array(148, 'preg_filter'),
        );
    }


    /**
     * testNoViolation
     *
     * @group pregReplaceEModifier
     *
     * @dataProvider dataNoViolation
     *
     * @param int $line Line number where no error should occur.
     *
     * @return void
     */
    public function testNoViolation($line)
    {
        $file = $this->sniffFile(self::TEST_FILE, '5.4');
        $this->assertNoViolation($file, $line);

        $file = $this->sniffFile(self::TEST_FILE, '5.5');
        $this->assertNoViolation($file, $line);

        $file = $this->sniffFile(self::TEST_FILE, '7.0');
        $this->assertNoViolation($file, $line);
    }

    /**
     * dataNoViolation
     *
     * @see testNoViolation()
     *
     * @return array
     */
    public function dataNoViolation() {
        return array(
            // No or only valid modifiers.
            array(9),
            array(10),
            array(13),
            array(14),
            array(17),
            array(18),
            array(21),
            array(24),
            array(39),
            array(45),

            // Untestable regex (variable, constant, function call).
            array(94),
            array(95),
            array(96),

            // Bracket delimiters.
            array(101),
            array(102),
            array(103),
            array(105),
            array(107),
            array(109),

        );
    }

}


1		<?php
2		/**
3		* preg_replace() /e modifier sniff test file
4		*
5		* @package PHPCompatibility
6		*/
7
8
9		/**
10		* preg_replace() /e modifier sniff tests
11		*
12		* @uses BaseSniffTest
13		* @package PHPCompatibility
14		* @author Jansen Price <[email protected]>
15		*/
16		class PregReplaceEModifierSniffTest extends BaseSniffTest
		0 ignored issues – show Coding Style Compatibility introduced 2016-08-04 22:56 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
17		{
18
19		const TEST_FILE = 'sniff-examples/preg_replace_e_modifier.php';
20
21		/**
22		* testDeprecatedEModifier
23		*
24		* @group pregReplaceEModifier
25		*
26		* @dataProvider dataDeprecatedEModifier
27		*
28		* @param int $line Line number where the error should occur.
29		* @param string $functionName Function name.
30		*
31		* @return void
32		*/
33	View Code Duplication	public function testDeprecatedEModifier($line, $functionName = 'preg_replace')
		0 ignored issues – show Duplication introduced 2016-08-22 21:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		{
35		$file = $this->sniffFile(self::TEST_FILE, '5.4');
36		$this->assertNoViolation($file, $line);
37
38		$file = $this->sniffFile(self::TEST_FILE, '5.5');
39		$this->assertError($file, $line, "{$functionName}() - /e modifier is deprecated since PHP 5.5");
40
41		$file = $this->sniffFile(self::TEST_FILE, '7.0');
42		$this->assertError($file, $line, "{$functionName}() - /e modifier is forbidden since PHP 7.0");
43		}
44
45		/**
46		* dataDeprecatedEModifier
47		*
48		* @see testDeprecatedEModifier()
49		*
50		* @return array
51		*/
52		public function dataDeprecatedEModifier() {
53		return array(
54		// preg_replace()
55		array(50),
56		array(51),
57		array(54),
58		array(55),
59		array(58),
60		array(59),
61		array(60),
62		array(63),
63		array(78),
64		array(84),
65
66		// Bracket delimiters.
67		array(99),
68		array(100),
69		array(104),
70		array(106),
71		array(108),
72
73		// preg_filter()
74		array(114, 'preg_filter'),
75		array(115, 'preg_filter'),
76		array(118, 'preg_filter'),
77		array(119, 'preg_filter'),
78		array(122, 'preg_filter'),
79		array(123, 'preg_filter'),
80		array(124, 'preg_filter'),
81		array(127, 'preg_filter'),
82		array(142, 'preg_filter'),
83		array(148, 'preg_filter'),
84		);
85		}
86
87
88		/**
89		* testNoViolation
90		*
91		* @group pregReplaceEModifier
92		*
93		* @dataProvider dataNoViolation
94		*
95		* @param int $line Line number where no error should occur.
96		*
97		* @return void
98		*/
99		public function testNoViolation($line)
100		{
101		$file = $this->sniffFile(self::TEST_FILE, '5.4');
102		$this->assertNoViolation($file, $line);
103
104		$file = $this->sniffFile(self::TEST_FILE, '5.5');
105		$this->assertNoViolation($file, $line);
106
107		$file = $this->sniffFile(self::TEST_FILE, '7.0');
108		$this->assertNoViolation($file, $line);
109		}
110
111		/**
112		* dataNoViolation
113		*
114		* @see testNoViolation()
115		*
116		* @return array
117		*/
118		public function dataNoViolation() {
119		return array(
120		// No or only valid modifiers.
121		array(9),
122		array(10),
123		array(13),
124		array(14),
125		array(17),
126		array(18),
127		array(21),
128		array(24),
129		array(39),
130		array(45),
131
132		// Untestable regex (variable, constant, function call).
133		array(94),
134		array(95),
135		array(96),
136
137		// Bracket delimiters.
138		array(101),
139		array(102),
140		array(103),
141		array(105),
142		array(107),
143		array(109),
144
145		);
146		}
147
148		}
149

wimg / PHPCompatibility

Pull Request — master (#201)

PregReplaceEModifierSniffTest::dataNoViolation() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like