willyb321 / elite-journal

app/lib/utils.js

/**
 * @file Utils
 */
/**
 * @module Utils
 */

import {menu} from '../main/index';

/**
 * Get menu item by label.
 * @param label {string} The label of the menu item to search for.
 * @returns {Electron.MenuItem} - The full menu item. Can change things like checked etc.
 */
export function getMenuItem (label) {
	for (let i = 0; i < menu.items.length; i++) {
		const menuItem = menu.items[i].submenu.items.find(item => item.label === label);
		if (menuItem) return menuItem
	}

There is no return statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding return undefined; explicitly.

}