willdurand / Hateoas

src/Hateoas/Factory/LinkFactory.php

<?php

namespace Hateoas\Factory;

use Hateoas\Configuration\Relation;
use Hateoas\Configuration\Route;
use Hateoas\Expression\ExpressionEvaluator;
use Hateoas\Model\Link;
use Hateoas\UrlGenerator\UrlGeneratorRegistry;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface as SymfonyUrlGeneratorInterface;

/**
 * @author Adrien Brault <adrien.brault@gmail.com>
 */
class LinkFactory
{
    /**
     * @var ExpressionEvaluator
     */
    private $expressionEvaluator;

    /**
     * @var UrlGeneratorRegistry
     */
    private $urlGeneratorRegistry;

    /**
     * @param ExpressionEvaluator  $expressionEvaluator
     * @param UrlGeneratorRegistry $urlGeneratorRegistry
     */
    public function __construct(ExpressionEvaluator $expressionEvaluator, UrlGeneratorRegistry $urlGeneratorRegistry)
    {
        $this->expressionEvaluator  = $expressionEvaluator;
        $this->urlGeneratorRegistry = $urlGeneratorRegistry;
    }

    /**
     * @param object   $object
     * @param Relation $relation
     *
     * @return Link
     */
    public function createLink($object, Relation $relation)
    {
        $rel =  $this->expressionEvaluator->evaluate($relation->getName(), $object);
        $href = $relation->getHref();

        if ($href instanceof Route) {
            if (!$this->urlGeneratorRegistry->hasGenerators()) {
                throw new \RuntimeException('You cannot use a route without an url generator.');
            }

            $name       = $this->expressionEvaluator->evaluate($href->getName(), $object);
            $parameters = is_array($href->getParameters())
                ? $this->expressionEvaluator->evaluateArray($href->getParameters(), $object)
                : $this->expressionEvaluator->evaluate($href->getParameters(), $object)
            ;
            $isAbsolute = $this->expressionEvaluator->evaluate($href->isAbsolute(), $object)

$href->isAbsolute() is of type boolean, but the function expects a string.

                ? SymfonyUrlGeneratorInterface::ABSOLUTE_PATH
                : SymfonyUrlGeneratorInterface::ABSOLUTE_URL
            ;

            if (!is_array($parameters)) {
                throw new \RuntimeException(
                    sprintf(
                        'The route parameters should be an array, %s given. Maybe you forgot to wrap the expression in expr(...).',
                        gettype($parameters)
                    )
                );
            }

            $href = $this->urlGeneratorRegistry
                ->get($href->getGenerator())
                ->generate($name, $parameters, $isAbsolute)

It seems like $name defined by $this->expressionEvaluator->evaluate($href->getName(), $object) on line 53 can also be of type array; however, Hateoas\UrlGenerator\UrlGeneratorInterface::generate() does only seem to accept string, maybe add an additional type check?

            ;
        } else {
            $href = $this->expressionEvaluator->evaluate($href, $object);
        }

        $attributes = $this->expressionEvaluator->evaluateArray($relation->getAttributes(), $object);

        return new Link($rel, $href, $attributes);

It seems like $rel defined by $this->expressionEvaluator->evaluate($relation->getName(), $object) on line 45 can also be of type array; however, Hateoas\Model\Link::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $href defined by $this->expressionEvaluator->evaluate($href, $object) on line 77 can also be of type array; however, Hateoas\Model\Link::__construct() does only seem to accept string, maybe add an additional type check?

    }
}