Issues in SymfonyUrlGenerator.php - All Issues - Inspection of "PHP 7 ready" - willdurand/Hateoas - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1978d2...e2f699 )

by William

created 2015-12-09 12:36 UTC

src/Hateoas/UrlGenerator/SymfonyUrlGenerator.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Hateoas\UrlGenerator;

use Symfony\Component\Routing\Generator\UrlGeneratorInterface as SymfonyUrlGeneratorInterface;

/**
 * @author Adrien Brault <[email protected]>
 */
class SymfonyUrlGenerator implements UrlGeneratorInterface
{
    /**
     * @var SymfonyUrlGeneratorInterface
     */
    private $urlGenerator;

    public function __construct(SymfonyUrlGeneratorInterface $urlGenerator)
    {
        $this->urlGenerator = $urlGenerator;
    }

    /**
     * {@inheritdoc}
     */
    public function generate($name, array $parameters, $absolute = false)
    {
        return $this->urlGenerator->generate($name, $parameters, $absolute);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


GitHub Access Token became invalid

Push — master ( 1978d2...e2f699 )

src/Hateoas/UrlGenerator/SymfonyUrlGenerator.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1			<?php
2
3			namespace Hateoas\UrlGenerator;
4
5			use Symfony\Component\Routing\Generator\UrlGeneratorInterface as SymfonyUrlGeneratorInterface;
6
7			/**
8			* @author Adrien Brault <[email protected]>
9			*/
10			class SymfonyUrlGenerator implements UrlGeneratorInterface
11			{
12			/**
13			* @var SymfonyUrlGeneratorInterface
14			*/
15			private $urlGenerator;
16
17			public function __construct(SymfonyUrlGeneratorInterface $urlGenerator)
18			{
19			$this->urlGenerator = $urlGenerator;
20			}
21
22			/**
23			* {@inheritdoc}
24			*/
25			public function generate($name, array $parameters, $absolute = false)
26			{
27			return $this->urlGenerator->generate($name, $parameters, $absolute);
			0 ignored issues – show Documentation introduced 2015-12-04 15:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$absolute` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
28			}
29			}
30

willdurand / Hateoas

GitHub Access Token became invalid

Push — master ( 1978d2...e2f699 )

src/Hateoas/UrlGenerator/SymfonyUrlGenerator.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like