willdurand /
Hateoas
| Conditions | 3 |
| Paths | 4 |
| Total Lines | 96 |
| Code Lines | 76 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 17 | public function testUser() |
||
| 18 | { |
||
| 19 | $driver = $this->createDriver(); |
||
| 20 | $class = new \ReflectionClass('Hateoas\Tests\Fixtures\User'); |
||
| 21 | $classMetadata = $driver->loadMetadataForClass($class); |
||
| 22 | |||
| 23 | $this->assertInstanceOf('Hateoas\Configuration\Metadata\ClassMetadata', $classMetadata); |
||
| 24 | |||
| 25 | /** @var $relations Relation[] */ |
||
| 26 | $relations = $classMetadata->getRelations(); |
||
| 27 | |||
| 28 | $this->assertInternalType('array', $relations); |
||
| 29 | foreach ($relations as $relation) { |
||
| 30 | $this->assertInstanceOf('Hateoas\Configuration\Relation', $relation); |
||
| 31 | } |
||
| 32 | |||
| 33 | $i = 0; |
||
| 34 | |||
| 35 | $relation = $relations[$i++]; |
||
| 36 | $this->assertSame('self', $relation->getName()); |
||
| 37 | $this->assertSame('http://hateoas.web/user/42', $relation->getHref()); |
||
| 38 | $this->assertSame(['type' => 'application/json'], $relation->getAttributes()); |
||
| 39 | $this->assertNull($relation->getEmbedded()); |
||
| 40 | $this->assertNull($relation->getExclusion()); |
||
| 41 | |||
| 42 | $relation = $relations[$i++]; |
||
| 43 | $this->assertSame('foo', $relation->getName()); |
||
| 44 | $this->assertInstanceOf('Hateoas\Configuration\Route', $relation->getHref()); |
||
| 45 | $this->assertSame('user_get', $relation->getHref()->getName()); |
||
| 46 | $this->assertSame(['id' => 'expr(object.getId())'], $relation->getHref()->getParameters()); |
||
| 47 | $this->assertFalse($relation->getHref()->isAbsolute()); |
||
| 48 | $this->assertInstanceOf('Hateoas\Configuration\Embedded', $relation->getEmbedded()); |
||
| 49 | $this->assertSame('expr(object.getFoo())', $relation->getEmbedded()->getContent()); |
||
| 50 | $this->assertNull($relation->getEmbedded()->getXmlElementName()); |
||
| 51 | $this->assertNull($relation->getEmbedded()->getExclusion()); |
||
| 52 | |||
| 53 | $relation = $relations[$i++]; |
||
| 54 | $this->assertSame('bar', $relation->getName()); |
||
| 55 | $this->assertSame('foo', $relation->getHref()); |
||
| 56 | $this->assertInstanceOf('Hateoas\Configuration\Embedded', $relation->getEmbedded()); |
||
| 57 | $this->assertSame('data', $relation->getEmbedded()->getContent()); |
||
| 58 | $this->assertSame('barTag', $relation->getEmbedded()->getXmlElementName()); |
||
| 59 | $this->assertNull($relation->getEmbedded()->getExclusion()); |
||
| 60 | |||
| 61 | $relation = $relations[$i++]; |
||
| 62 | $this->assertSame('baz', $relation->getName()); |
||
| 63 | $this->assertInstanceOf('Hateoas\Configuration\Route', $relation->getHref()); |
||
| 64 | $this->assertSame('user_get', $relation->getHref()->getName()); |
||
| 65 | $this->assertSame(['id' => 'expr(object.getId())'], $relation->getHref()->getParameters()); |
||
| 66 | $this->assertTrue($relation->getHref()->isAbsolute()); |
||
| 67 | $this->assertNull($relation->getExclusion()); |
||
| 68 | |||
| 69 | $relation = $relations[$i++]; |
||
| 70 | $this->assertSame('boom', $relation->getName()); |
||
| 71 | $this->assertInstanceOf('Hateoas\Configuration\Route', $relation->getHref()); |
||
| 72 | $this->assertSame('user_get', $relation->getHref()->getName()); |
||
| 73 | $this->assertSame(['id' => 'expr(object.getId())'], $relation->getHref()->getParameters()); |
||
| 74 | $this->assertFalse($relation->getHref()->isAbsolute()); |
||
| 75 | $this->assertNull($relation->getExclusion()); |
||
| 76 | |||
| 77 | $relation = $relations[$i++]; |
||
| 78 | $this->assertSame('badaboom', $relation->getName()); |
||
| 79 | $this->assertNull($relation->getHref()); |
||
| 80 | $this->assertInstanceOf('Hateoas\Configuration\Embedded', $relation->getEmbedded()); |
||
| 81 | $this->assertSame('expr(object.getFoo())', $relation->getEmbedded()->getContent()); |
||
| 82 | $this->assertNull($relation->getExclusion()); |
||
| 83 | |||
| 84 | $relation = $relations[$i++]; |
||
| 85 | $this->assertSame('hello', $relation->getName()); |
||
| 86 | $this->assertSame('/hello', $relation->getHref()); |
||
| 87 | $this->assertInstanceOf('Hateoas\Configuration\Exclusion', $relation->getExclusion()); |
||
| 88 | $this->assertSame(['group1', 'group2'], $relation->getExclusion()->getGroups()); |
||
| 89 | $this->assertSame(1.0, $relation->getExclusion()->getSinceVersion()); |
||
| 90 | $this->assertSame(2.2, $relation->getExclusion()->getUntilVersion()); |
||
| 91 | $this->assertSame(42, $relation->getExclusion()->getMaxDepth()); |
||
| 92 | $this->assertSame('foo', $relation->getExclusion()->getExcludeIf()); |
||
| 93 | $this->assertInstanceOf('Hateoas\Configuration\Embedded', $relation->getEmbedded()); |
||
| 94 | $this->assertSame('hello', $relation->getEmbedded()->getContent()); |
||
| 95 | $this->assertInstanceOf('Hateoas\Configuration\Exclusion', $relation->getEmbedded()->getExclusion()); |
||
| 96 | $this->assertSame(['group3', 'group4'], $relation->getEmbedded()->getExclusion()->getGroups()); |
||
| 97 | $this->assertSame(1.1, $relation->getEmbedded()->getExclusion()->getSinceVersion()); |
||
| 98 | $this->assertSame(2.3, $relation->getEmbedded()->getExclusion()->getUntilVersion()); |
||
| 99 | $this->assertSame(43, $relation->getEmbedded()->getExclusion()->getMaxDepth()); |
||
| 100 | $this->assertSame('bar', $relation->getEmbedded()->getExclusion()->getExcludeIf()); |
||
| 101 | |||
| 102 | /** @var $relations RelationProvider[] */ |
||
| 103 | $relationProviders = $classMetadata->getRelationProviders(); |
||
| 104 | |||
| 105 | $this->assertInternalType('array', $relationProviders); |
||
| 106 | foreach ($relationProviders as $relationProvider) { |
||
| 107 | $this->assertInstanceOf('Hateoas\Configuration\RelationProvider', $relationProvider); |
||
| 108 | } |
||
| 109 | |||
| 110 | $relationProvider = current($relationProviders); |
||
| 111 | $this->assertSame('getRelations', $relationProvider->getName()); |
||
| 112 | } |
||
| 113 | |||
| 123 |
