Hateoas\Tests\Expression\LinkExpressionFunctionTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	3
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testEvaluate()	0	14	1
A	testCompile()	0	18	1
A	mockHelper()	0	17	1

<?php

namespace Hateoas\Tests\Expression;

use Hateoas\Expression\ExpressionEvaluator;
use Hateoas\Expression\LinkExpressionFunction;
use Symfony\Component\ExpressionLanguage\ExpressionLanguage;

class LinkExpressionFunctionTest extends \PHPUnit_Framework_TestCase
{
    public function testEvaluate()
    {
        $object = new \StdClass();

        $linkHelperMock = $this->mockHelper('/foo', $object, 'self', false);

        $expressionEvaluator = new ExpressionEvaluator(new ExpressionLanguage());
        $expressionEvaluator->registerFunction(new LinkExpressionFunction($linkHelperMock));

        $this->assertEquals(
            '/foo',
            $expressionEvaluator->evaluate('expr(link(object, "self", false))', $object)
        );
    }

    public function testCompile()
    {
        $object = new \StdClass();

        $linkHelperMock = $this->mockHelper('/foo', $object, 'self', false);

        $expressionLanguage = new ExpressionLanguage();
        $expressionEvaluator = new ExpressionEvaluator($expressionLanguage);
        $expressionEvaluator->registerFunction(new LinkExpressionFunction($linkHelperMock));

        $compiledExpression = $expressionLanguage->compile('link(object, "self", false)', array('object', 'link_helper'));

        // setup variables for expression eval
        $object = $object;

Why assign $object to itself?

        $link_helper = $linkHelperMock;

$link_helper is not used, you could remove the assignment.

        $this->assertEquals('/foo', eval(sprintf('return %s;', $compiledExpression)));

It is generally not recommended to use eval unless absolutely required.

    }

    /**
     * @param string $result
     * @param \stdClass $expectedObject
     * @param string $expectedRel
     * @param boolean $expectedAbsolute
     *
     * @return \Hateoas\Helper\LinkHelper
     */
    private function mockHelper($result, $expectedObject, $expectedRel, $expectedAbsolute)

The parameter $result is not used and could be removed.

    {
        $linkHelperMock = $this
            ->getMockBuilder('Hateoas\Helper\LinkHelper')
            ->disableOriginalConstructor()
            ->getMock()
        ;

        $linkHelperMock
            ->expects($this->once())
            ->method('getLinkHref')
            ->will($this->returnValue('/foo'))
            ->with($expectedObject, $expectedRel, $expectedAbsolute)
        ;

        return $linkHelperMock;
    }
}