Issues in ResourcesOOUI.php (master) - Issues in master - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4122)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

resources/ResourcesOOUI.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Bartosz Dziewoński 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Definition of OOjs UI ResourceLoader modules.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 * http://www.gnu.org/copyleft/gpl.html
 *
 * @file
 */

if ( !defined( 'MEDIAWIKI' ) ) {
	die( 'Not an entry point.' );
}

// WARNING: OOjs-UI is NOT TESTED with older browsers and is likely to break
// if loaded in browsers that don't support ES5
return call_user_func( function () {
	$themes = ExtensionRegistry::getInstance()->getAttribute( 'SkinOOUIThemes' );
	// We only use the theme names for file names, and they are lowercase
	$themes = array_map( 'strtolower', $themes );
	$themes['default'] = 'mediawiki';

	// Helper function to generate paths to files used in 'skinStyles' and 'skinScripts'.
	$getSkinSpecific = function ( $module, $ext = 'css' ) use ( $themes ) {
		return array_combine(
			array_keys( $themes ),
			array_map( function ( $theme ) use ( $module, $ext ) {
				$module = $module ? "$module-" : '';
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)
				// TODO Allow extensions to specify this path somehow
				return "resources/lib/oojs-ui/oojs-ui-$module$theme.$ext";
			}, array_values( $themes ) )
		);
	};

	$modules = [];

	// Omnibus module.
	$modules['oojs-ui'] = [
		'dependencies' => [
			'oojs-ui-core',
			'oojs-ui-widgets',
			'oojs-ui-toolbars',
			'oojs-ui-windows',
		],
		'targets' => [ 'desktop', 'mobile' ],
	];

	// The core JavaScript library.
	$modules['oojs-ui-core'] = [
		'scripts' => [
			'resources/lib/oojs-ui/oojs-ui-core.js',
			'resources/src/oojs-ui-local.js',
		],
		'skinScripts' => $getSkinSpecific( null, 'js' ),
		'dependencies' => [
			'es5-shim',
			'oojs',
			'oojs-ui-core.styles',
			'oojs-ui.styles.icons',
			'oojs-ui.styles.indicators',
			'oojs-ui.styles.textures',
			'mediawiki.language',
		],
		'targets' => [ 'desktop', 'mobile' ],
	];
	// This contains only the styles required by core widgets.
	$modules['oojs-ui-core.styles'] = [
		'position' => 'top',
		'styles' => 'resources/src/oojs-ui-local.css', // HACK, see inside the file
		'skinStyles' => $getSkinSpecific( 'core' ),
		'targets' => [ 'desktop', 'mobile' ],
	];

	// Additional widgets and layouts module.
	$modules['oojs-ui-widgets'] = [
		'scripts' => 'resources/lib/oojs-ui/oojs-ui-widgets.js',
		'skinStyles' => $getSkinSpecific( 'widgets' ),
		'dependencies' => 'oojs-ui-core',
		'messages' => [
			'ooui-outline-control-move-down',
			'ooui-outline-control-move-up',
			'ooui-outline-control-remove',
			'ooui-selectfile-button-select',
			'ooui-selectfile-dragdrop-placeholder',
			'ooui-selectfile-not-supported',
			'ooui-selectfile-placeholder',
		],
		'targets' => [ 'desktop', 'mobile' ],
	];
	// Toolbar and tools module.
	$modules['oojs-ui-toolbars'] = [
		'scripts' => 'resources/lib/oojs-ui/oojs-ui-toolbars.js',
		'skinStyles' => $getSkinSpecific( 'toolbars' ),
		'dependencies' => 'oojs-ui-core',
		'messages' => [
			'ooui-toolbar-more',
			'ooui-toolgroup-collapse',
			'ooui-toolgroup-expand',
		],
		'targets' => [ 'desktop', 'mobile' ],
	];
	// Windows and dialogs module.
	$modules['oojs-ui-windows'] = [
		'scripts' => 'resources/lib/oojs-ui/oojs-ui-windows.js',
		'skinStyles' => $getSkinSpecific( 'windows' ),
		'dependencies' => 'oojs-ui-core',
		'messages' => [
			'ooui-dialog-message-accept',
			'ooui-dialog-message-reject',
			'ooui-dialog-process-continue',
			'ooui-dialog-process-dismiss',
			'ooui-dialog-process-error',
			'ooui-dialog-process-retry',
		],
		'targets' => [ 'desktop', 'mobile' ],
	];

	$imageSets = [
		// Comments for greppability
		'icons', // oojs-ui.styles.icons
		'indicators', // oojs-ui.styles.indicators
		'textures', // oojs-ui.styles.textures
		'icons-accessibility', // oojs-ui.styles.icons-accessibility
		'icons-alerts', // oojs-ui.styles.icons-alerts
		'icons-content', // oojs-ui.styles.icons-content
		'icons-editing-advanced', // oojs-ui.styles.icons-editing-advanced
		'icons-editing-core', // oojs-ui.styles.icons-editing-core
		'icons-editing-list', // oojs-ui.styles.icons-editing-list
		'icons-editing-styling', // oojs-ui.styles.icons-editing-styling
		'icons-interactions', // oojs-ui.styles.icons-interactions
		'icons-layout', // oojs-ui.styles.icons-layout
		'icons-location', // oojs-ui.styles.icons-location
		'icons-media', // oojs-ui.styles.icons-media
		'icons-moderation', // oojs-ui.styles.icons-moderation
		'icons-movement', // oojs-ui.styles.icons-movement
		'icons-user', // oojs-ui.styles.icons-user
		'icons-wikimedia', // oojs-ui.styles.icons-wikimedia
	];
	$rootPath = 'resources/lib/oojs-ui/themes';

	foreach ( $imageSets as $name ) {
		$module = [
			'position' => 'top',
			'class' => 'ResourceLoaderOOUIImageModule',
			'name' => $name,
			'rootPath' => $rootPath,
		];

		if ( substr( $name, 0, 5 ) === 'icons' ) {
			$module['selectorWithoutVariant'] = '.oo-ui-icon-{name}, .mw-ui-icon-{name}:before';
			$module['selectorWithVariant'] = '
				.oo-ui-image-{variant}.oo-ui-icon-{name}, .mw-ui-icon-{name}-{variant}:before,
				/* Hack for Flow, see T110051 */
				.mw-ui-hovericon:hover .mw-ui-icon-{name}-{variant}-hover:before,
				.mw-ui-hovericon.mw-ui-icon-{name}-{variant}-hover:hover:before';
		}

		$modules["oojs-ui.styles.$name"] = $module;
	}

	return $modules;
} );


Issues (4122)

Security Analysis not enabled

resources/ResourcesOOUI.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Change not visible in outer-scope

Change visible in outer-scope

1			<?php
2			/**
3			* Definition of OOjs UI ResourceLoader modules.
4			*
5			* This program is free software; you can redistribute it and/or modify
6			* it under the terms of the GNU General Public License as published by
7			* the Free Software Foundation; either version 2 of the License, or
8			* (at your option) any later version.
9			*
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13			* GNU General Public License for more details.
14			*
15			* You should have received a copy of the GNU General Public License along
16			* with this program; if not, write to the Free Software Foundation, Inc.,
17			* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18			* http://www.gnu.org/copyleft/gpl.html
19			*
20			* @file
21			*/
22
23			if ( !defined( 'MEDIAWIKI' ) ) {
24			die( 'Not an entry point.' );
25			}
26
27			// WARNING: OOjs-UI is NOT TESTED with older browsers and is likely to break
28			// if loaded in browsers that don't support ES5
29			return call_user_func( function () {
30			$themes = ExtensionRegistry::getInstance()->getAttribute( 'SkinOOUIThemes' );
31			// We only use the theme names for file names, and they are lowercase
32			$themes = array_map( 'strtolower', $themes );
33			$themes['default'] = 'mediawiki';
34
35			// Helper function to generate paths to files used in 'skinStyles' and 'skinScripts'.
36			$getSkinSpecific = function ( $module, $ext = 'css' ) use ( $themes ) {
37			return array_combine(
38			array_keys( $themes ),
39			array_map( function ( $theme ) use ( $module, $ext ) {
40			$module = $module ? "$module-" : '';
			0 ignored issues – show Bug introduced 2016-02-23 18:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different name than the imported variable `$module`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
41			// TODO Allow extensions to specify this path somehow
42			return "resources/lib/oojs-ui/oojs-ui-$module$theme.$ext";
43			}, array_values( $themes ) )
44			);
45			};
46
47			$modules = [];
48
49			// Omnibus module.
50			$modules['oojs-ui'] = [
51			'dependencies' => [
52			'oojs-ui-core',
53			'oojs-ui-widgets',
54			'oojs-ui-toolbars',
55			'oojs-ui-windows',
56			],
57			'targets' => [ 'desktop', 'mobile' ],
58			];
59
60			// The core JavaScript library.
61			$modules['oojs-ui-core'] = [
62			'scripts' => [
63			'resources/lib/oojs-ui/oojs-ui-core.js',
64			'resources/src/oojs-ui-local.js',
65			],
66			'skinScripts' => $getSkinSpecific( null, 'js' ),
67			'dependencies' => [
68			'es5-shim',
69			'oojs',
70			'oojs-ui-core.styles',
71			'oojs-ui.styles.icons',
72			'oojs-ui.styles.indicators',
73			'oojs-ui.styles.textures',
74			'mediawiki.language',
75			],
76			'targets' => [ 'desktop', 'mobile' ],
77			];
78			// This contains only the styles required by core widgets.
79			$modules['oojs-ui-core.styles'] = [
80			'position' => 'top',
81			'styles' => 'resources/src/oojs-ui-local.css', // HACK, see inside the file
82			'skinStyles' => $getSkinSpecific( 'core' ),
83			'targets' => [ 'desktop', 'mobile' ],
84			];
85
86			// Additional widgets and layouts module.
87			$modules['oojs-ui-widgets'] = [
88			'scripts' => 'resources/lib/oojs-ui/oojs-ui-widgets.js',
89			'skinStyles' => $getSkinSpecific( 'widgets' ),
90			'dependencies' => 'oojs-ui-core',
91			'messages' => [
92			'ooui-outline-control-move-down',
93			'ooui-outline-control-move-up',
94			'ooui-outline-control-remove',
95			'ooui-selectfile-button-select',
96			'ooui-selectfile-dragdrop-placeholder',
97			'ooui-selectfile-not-supported',
98			'ooui-selectfile-placeholder',
99			],
100			'targets' => [ 'desktop', 'mobile' ],
101			];
102			// Toolbar and tools module.
103			$modules['oojs-ui-toolbars'] = [
104			'scripts' => 'resources/lib/oojs-ui/oojs-ui-toolbars.js',
105			'skinStyles' => $getSkinSpecific( 'toolbars' ),
106			'dependencies' => 'oojs-ui-core',
107			'messages' => [
108			'ooui-toolbar-more',
109			'ooui-toolgroup-collapse',
110			'ooui-toolgroup-expand',
111			],
112			'targets' => [ 'desktop', 'mobile' ],
113			];
114			// Windows and dialogs module.
115			$modules['oojs-ui-windows'] = [
116			'scripts' => 'resources/lib/oojs-ui/oojs-ui-windows.js',
117			'skinStyles' => $getSkinSpecific( 'windows' ),
118			'dependencies' => 'oojs-ui-core',
119			'messages' => [
120			'ooui-dialog-message-accept',
121			'ooui-dialog-message-reject',
122			'ooui-dialog-process-continue',
123			'ooui-dialog-process-dismiss',
124			'ooui-dialog-process-error',
125			'ooui-dialog-process-retry',
126			],
127			'targets' => [ 'desktop', 'mobile' ],
128			];
129
130			$imageSets = [
131			// Comments for greppability
132			'icons', // oojs-ui.styles.icons
133			'indicators', // oojs-ui.styles.indicators
134			'textures', // oojs-ui.styles.textures
135			'icons-accessibility', // oojs-ui.styles.icons-accessibility
136			'icons-alerts', // oojs-ui.styles.icons-alerts
137			'icons-content', // oojs-ui.styles.icons-content
138			'icons-editing-advanced', // oojs-ui.styles.icons-editing-advanced
139			'icons-editing-core', // oojs-ui.styles.icons-editing-core
140			'icons-editing-list', // oojs-ui.styles.icons-editing-list
141			'icons-editing-styling', // oojs-ui.styles.icons-editing-styling
142			'icons-interactions', // oojs-ui.styles.icons-interactions
143			'icons-layout', // oojs-ui.styles.icons-layout
144			'icons-location', // oojs-ui.styles.icons-location
145			'icons-media', // oojs-ui.styles.icons-media
146			'icons-moderation', // oojs-ui.styles.icons-moderation
147			'icons-movement', // oojs-ui.styles.icons-movement
148			'icons-user', // oojs-ui.styles.icons-user
149			'icons-wikimedia', // oojs-ui.styles.icons-wikimedia
150			];
151			$rootPath = 'resources/lib/oojs-ui/themes';
152
153			foreach ( $imageSets as $name ) {
154			$module = [
155			'position' => 'top',
156			'class' => 'ResourceLoaderOOUIImageModule',
157			'name' => $name,
158			'rootPath' => $rootPath,
159			];
160
161			if ( substr( $name, 0, 5 ) === 'icons' ) {
162			$module['selectorWithoutVariant'] = '.oo-ui-icon-{name}, .mw-ui-icon-{name}:before';
163			$module['selectorWithVariant'] = '
164			.oo-ui-image-{variant}.oo-ui-icon-{name}, .mw-ui-icon-{name}-{variant}:before,
165			/* Hack for Flow, see T110051 */
166			.mw-ui-hovericon:hover .mw-ui-icon-{name}-{variant}-hover:before,
167			.mw-ui-hovericon.mw-ui-icon-{name}-{variant}-hover:hover:before';
168			}
169
170			$modules["oojs-ui.styles.$name"] = $module;
171			}
172
173			return $modules;
174			} );
175

wikimedia / mediawiki

Issues (4122)

Security Analysis not enabled

resources/ResourcesOOUI.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like