Issues (4122)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

maintenance/rebuildtextindex.php (1 issue)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/**
3
 * Rebuild search index table from scratch.  This may take several
4
 * hours, depending on the database size and server configuration.
5
 *
6
 * Postgres is trigger-based and should never need rebuilding.
7
 *
8
 * This program is free software; you can redistribute it and/or modify
9
 * it under the terms of the GNU General Public License as published by
10
 * the Free Software Foundation; either version 2 of the License, or
11
 * (at your option) any later version.
12
 *
13
 * This program is distributed in the hope that it will be useful,
14
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16
 * GNU General Public License for more details.
17
 *
18
 * You should have received a copy of the GNU General Public License along
19
 * with this program; if not, write to the Free Software Foundation, Inc.,
20
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
21
 * http://www.gnu.org/copyleft/gpl.html
22
 *
23
 * @file
24
 * @ingroup Maintenance
25
 * @todo document
26
 */
27
28
require_once __DIR__ . '/Maintenance.php';
29
30
/**
31
 * Maintenance script that rebuilds search index table from scratch.
32
 *
33
 * @ingroup Maintenance
34
 */
35
class RebuildTextIndex extends Maintenance {
36
	const RTI_CHUNK_SIZE = 500;
37
38
	/**
39
	 * @var Database
40
	 */
41
	private $db;
42
43
	public function __construct() {
44
		parent::__construct();
45
		$this->addDescription( 'Rebuild search index table from scratch' );
46
	}
47
48
	public function getDbType() {
49
		return Maintenance::DB_ADMIN;
50
	}
51
52
	public function execute() {
53
		// Shouldn't be needed for Postgres
54
		$this->db = $this->getDB( DB_MASTER );
55
		if ( $this->db->getType() == 'postgres' ) {
56
			$this->error( "This script is not needed when using Postgres.\n", true );
57
		}
58
59
		if ( $this->db->getType() == 'sqlite' ) {
60
			if ( !DatabaseSqlite::getFulltextSearchModule() ) {
61
				$this->error( "Your version of SQLite module for PHP doesn't "
62
					. "support full-text search (FTS3).\n", true );
63
			}
64
			if ( !$this->db->checkForEnabledSearch() ) {
0 ignored issues
show
It seems like you code against a specific sub-type and not the parent class Database as the method checkForEnabledSearch() does only exist in the following sub-classes of Database: DatabaseSqlite. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
65
				$this->error( "Your database schema is not configured for "
66
					. "full-text search support. Run update.php.\n", true );
67
			}
68
		}
69
70
		if ( $this->db->getType() == 'mysql' ) {
71
			$this->dropMysqlTextIndex();
72
			$this->clearSearchIndex();
73
			$this->populateSearchIndex();
74
			$this->createMysqlTextIndex();
75
		} else {
76
			$this->clearSearchIndex();
77
			$this->populateSearchIndex();
78
		}
79
80
		$this->output( "Done.\n" );
81
	}
82
83
	/**
84
	 * Populates the search index with content from all pages
85
	 */
86
	protected function populateSearchIndex() {
87
		$res = $this->db->select( 'page', 'MAX(page_id) AS count' );
88
		$s = $this->db->fetchObject( $res );
89
		$count = $s->count;
90
		$this->output( "Rebuilding index fields for {$count} pages...\n" );
91
		$n = 0;
92
93
		$fields = array_merge(
94
			Revision::selectPageFields(),
95
			Revision::selectFields(),
96
			Revision::selectTextFields()
97
		);
98
99
		while ( $n < $count ) {
100
			if ( $n ) {
101
				$this->output( $n . "\n" );
102
			}
103
			$end = $n + self::RTI_CHUNK_SIZE - 1;
104
105
			$res = $this->db->select( [ 'page', 'revision', 'text' ], $fields,
106
				[ "page_id BETWEEN $n AND $end", 'page_latest = rev_id', 'rev_text_id = old_id' ],
107
				__METHOD__
108
			);
109
110
			foreach ( $res as $s ) {
111
				try {
112
					$title = Title::makeTitle( $s->page_namespace, $s->page_title );
113
114
					$rev = new Revision( $s );
115
					$content = $rev->getContent();
116
117
					$u = new SearchUpdate( $s->page_id, $title, $content );
118
					$u->doUpdate();
119
				} catch ( MWContentSerializationException $ex ) {
120
					$this->output( "Failed to deserialize content of revision {$s->rev_id} of page "
121
						. "`" . $title->getPrefixedDBkey() . "`!\n" );
122
				}
123
			}
124
			$n += self::RTI_CHUNK_SIZE;
125
		}
126
	}
127
128
	/**
129
	 * (MySQL only) Drops fulltext index before populating the table.
130
	 */
131 View Code Duplication
	private function dropMysqlTextIndex() {
132
		$searchindex = $this->db->tableName( 'searchindex' );
133
		if ( $this->db->indexExists( 'searchindex', 'si_title', __METHOD__ ) ) {
134
			$this->output( "Dropping index...\n" );
135
			$sql = "ALTER TABLE $searchindex DROP INDEX si_title, DROP INDEX si_text";
136
			$this->db->query( $sql, __METHOD__ );
137
		}
138
	}
139
140
	/**
141
	 * (MySQL only) Adds back fulltext index after populating the table.
142
	 */
143 View Code Duplication
	private function createMysqlTextIndex() {
144
		$searchindex = $this->db->tableName( 'searchindex' );
145
		$this->output( "\nRebuild the index...\n" );
146
		$sql = "ALTER TABLE $searchindex ADD FULLTEXT si_title (si_title), " .
147
			"ADD FULLTEXT si_text (si_text)";
148
		$this->db->query( $sql, __METHOD__ );
149
	}
150
151
	/**
152
	 * Deletes everything from search index.
153
	 */
154
	private function clearSearchIndex() {
155
		$this->output( 'Clearing searchindex table...' );
156
		$this->db->delete( 'searchindex', '*', __METHOD__ );
157
		$this->output( "Done\n" );
158
	}
159
}
160
161
$maintClass = "RebuildTextIndex";
162
require_once RUN_MAINTENANCE_IF_MAIN;
163