Issues in orphans.php (master) - Issues in master - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4122)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

maintenance/orphans.php (6 issues)

Labels

Severity

Minor 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Look for 'orphan' revisions hooked to pages which don't exist and
 * 'childless' pages with no revisions.
 * Then, kill the poor widows and orphans.
 * Man this is depressing.
 *
 * Copyright © 2005 Brion Vibber <[email protected]>
 * https://www.mediawiki.org/
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 * http://www.gnu.org/copyleft/gpl.html
 *
 * @file
 * @author <[email protected]>
 * @ingroup Maintenance
 */

require_once __DIR__ . '/Maintenance.php';

/**
 * Maintenance script that looks for 'orphan' revisions hooked to pages which
 * don't exist and 'childless' pages with no revisions.
 *
 * @ingroup Maintenance
 */
class Orphans extends Maintenance {
	public function __construct() {
		parent::__construct();
		$this->addDescription( "Look for 'orphan' revisions hooked to pages which don't exist\n" .
			"and 'childless' pages with no revisions\n" .
			"Then, kill the poor widows and orphans\n" .
			"Man this is depressing"
		);
		$this->addOption( 'fix', 'Actually fix broken entries' );
	}

	public function execute() {
		$this->checkOrphans( $this->hasOption( 'fix' ) );
		$this->checkSeparation( $this->hasOption( 'fix' ) );
		# Does not work yet, do not use
		# $this->checkWidows( $this->hasOption( 'fix' ) );
	}

	/**
	 * Lock the appropriate tables for the script
	 * @param Database $db
	 * @param string $extraTable The name of any extra tables to lock (eg: text)
	 */
	private function lockTables( $db, $extraTable = [] ) {
		$tbls = [ 'page', 'revision', 'redirect' ];
		if ( $extraTable ) {
			$tbls = array_merge( $tbls, $extraTable );
		}
		$db->lockTables( [], $tbls, __METHOD__, false );
	}

	/**
	 * Check for orphan revisions
	 * @param bool $fix Whether to fix broken revisions when found
	 */
	private function checkOrphans( $fix ) {
		$dbw = $this->getDB( DB_MASTER );
		$page = $dbw->tableName( 'page' );
		$revision = $dbw->tableName( 'revision' );

		if ( $fix ) {
			$this->lockTables( $dbw );
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
		}

		$this->output( "Checking for orphan revision table entries... "
			. "(this may take a while on a large wiki)\n" );
		$result = $dbw->query( "
			SELECT *
			FROM $revision LEFT OUTER JOIN $page ON rev_page=page_id
			WHERE page_id IS NULL
		" );
		$orphans = $result->numRows();
		if ( $orphans > 0 ) {
			global $wgContLang;

			$this->output( "$orphans orphan revisions...\n" );
			$this->output( sprintf(
				"%10s %10s %14s %20s %s\n",
				'rev_id', 'rev_page', 'rev_timestamp', 'rev_user_text', 'rev_comment'
			) );

			foreach ( $result as $row ) {
				$comment = ( $row->rev_comment == '' )
					? ''
					: '(' . $wgContLang->truncate( $row->rev_comment, 40 ) . ')';
				$this->output( sprintf( "%10d %10d %14s %20s %s\n",
					$row->rev_id,
					$row->rev_page,
					$row->rev_timestamp,
					$wgContLang->truncate( $row->rev_user_text, 17 ),
					$comment ) );
				if ( $fix ) {
					$dbw->delete( 'revision', [ 'rev_id' => $row->rev_id ] );
				}
			}
			if ( !$fix ) {
				$this->output( "Run again with --fix to remove these entries automatically.\n" );
			}
		} else {
			$this->output( "No orphans! Yay!\n" );
		}

		if ( $fix ) {
			$dbw->unlockTables( __METHOD__ );
		}
	}

	/**
	 * @param bool $fix
	 * @todo DON'T USE THIS YET! It will remove entries which have children,
	 *       but which aren't properly attached (eg if page_latest is bogus
	 *       but valid revisions do exist)
	 */
	private function checkWidows( $fix ) {
		$dbw = $this->getDB( DB_MASTER );
		$page = $dbw->tableName( 'page' );
		$revision = $dbw->tableName( 'revision' );

		if ( $fix ) {
			$this->lockTables( $dbw );
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
		}

		$this->output( "\nChecking for childless page table entries... "
			. "(this may take a while on a large wiki)\n" );
		$result = $dbw->query( "
			SELECT *
			FROM $page LEFT OUTER JOIN $revision ON page_latest=rev_id
			WHERE rev_id IS NULL
		" );
		$widows = $result->numRows();
		if ( $widows > 0 ) {
			$this->output( "$widows childless pages...\n" );
			$this->output( sprintf( "%10s %11s %2s %s\n", 'page_id', 'page_latest', 'ns', 'page_title' ) );
			foreach ( $result as $row ) {
				printf( "%10d %11d %2d %s\n",
					$row->page_id,
					$row->page_latest,
					$row->page_namespace,
					$row->page_title );
				if ( $fix ) {
					$dbw->delete( 'page', [ 'page_id' => $row->page_id ] );
				}
			}
			if ( !$fix ) {
				$this->output( "Run again with --fix to remove these entries automatically.\n" );
			}
		} else {
			$this->output( "No childless pages! Yay!\n" );
		}

		if ( $fix ) {
			$dbw->unlockTables( __METHOD__ );
		}
	}

	/**
	 * Check for pages where page_latest is wrong
	 * @param bool $fix Whether to fix broken entries
	 */
	private function checkSeparation( $fix ) {
		$dbw = $this->getDB( DB_MASTER );
		$page = $dbw->tableName( 'page' );
		$revision = $dbw->tableName( 'revision' );

		if ( $fix ) {
			$this->lockTables( $dbw, [ 'user', 'text' ] );
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
		}

		$this->output( "\nChecking for pages whose page_latest links are incorrect... "
			. "(this may take a while on a large wiki)\n" );
		$result = $dbw->query( "
			SELECT *
			FROM $page LEFT OUTER JOIN $revision ON page_latest=rev_id
		" );
		$found = 0;
		foreach ( $result as $row ) {
			$result2 = $dbw->query( "
				SELECT MAX(rev_timestamp) as max_timestamp
				FROM $revision
				WHERE rev_page=$row->page_id
			" );
			$row2 = $dbw->fetchObject( $result2 );
			if ( $row2 ) {
				if ( $row->rev_timestamp != $row2->max_timestamp ) {
					if ( $found == 0 ) {
						$this->output( sprintf( "%10s %10s %14s %14s\n",
							'page_id', 'rev_id', 'timestamp', 'max timestamp' ) );
					}
					++$found;
					$this->output( sprintf( "%10d %10d %14s %14s\n",
						$row->page_id,
						$row->page_latest,
						$row->rev_timestamp,
						$row2->max_timestamp ) );
					if ( $fix ) {
						# ...
						$maxId = $dbw->selectField(
							'revision',
							'rev_id',
							[
								'rev_page' => $row->page_id,
								'rev_timestamp' => $row2->max_timestamp ] );
						$this->output( "... updating to revision $maxId\n" );
						$maxRev = Revision::newFromId( $maxId );
						$title = Title::makeTitle( $row->page_namespace, $row->page_title );
						$article = WikiPage::factory( $title );
						$article->updateRevisionOn( $dbw, $maxRev );
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
					}
				}
			} else {
				$this->output( "wtf\n" );
			}
		}

		if ( $found ) {
			$this->output( "Found $found pages with incorrect latest revision.\n" );
		} else {
			$this->output( "No pages with incorrect latest revision. Yay!\n" );
		}
		if ( !$fix && $found > 0 ) {
			$this->output( "Run again with --fix to remove these entries automatically.\n" );
		}

		if ( $fix ) {
			$dbw->unlockTables( __METHOD__ );
		}
	}
}

$maintClass = "Orphans";
require_once RUN_MAINTENANCE_IF_MAIN;


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-02-23 18:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 39 and the first side effect is on line 31. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* Look for 'orphan' revisions hooked to pages which don't exist and
4			* 'childless' pages with no revisions.
5			* Then, kill the poor widows and orphans.
6			* Man this is depressing.
7			*
8			* Copyright © 2005 Brion Vibber <[email protected]>
9			* https://www.mediawiki.org/
10			*
11			* This program is free software; you can redistribute it and/or modify
12			* it under the terms of the GNU General Public License as published by
13			* the Free Software Foundation; either version 2 of the License, or
14			* (at your option) any later version.
15			*
16			* This program is distributed in the hope that it will be useful,
17			* but WITHOUT ANY WARRANTY; without even the implied warranty of
18			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19			* GNU General Public License for more details.
20			*
21			* You should have received a copy of the GNU General Public License along
22			* with this program; if not, write to the Free Software Foundation, Inc.,
23			* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
24			* http://www.gnu.org/copyleft/gpl.html
25			*
26			* @file
27			* @author <[email protected]>
28			* @ingroup Maintenance
29			*/
30
31			require_once __DIR__ . '/Maintenance.php';
32
33			/**
34			* Maintenance script that looks for 'orphan' revisions hooked to pages which
35			* don't exist and 'childless' pages with no revisions.
36			*
37			* @ingroup Maintenance
38			*/
39			class Orphans extends Maintenance {
40			public function __construct() {
41			parent::__construct();
42			$this->addDescription( "Look for 'orphan' revisions hooked to pages which don't exist\n" .
43			"and 'childless' pages with no revisions\n" .
44			"Then, kill the poor widows and orphans\n" .
45			"Man this is depressing"
46			);
47			$this->addOption( 'fix', 'Actually fix broken entries' );
48			}
49
50			public function execute() {
51			$this->checkOrphans( $this->hasOption( 'fix' ) );
52			$this->checkSeparation( $this->hasOption( 'fix' ) );
53			# Does not work yet, do not use
54			# $this->checkWidows( $this->hasOption( 'fix' ) );
55			}
56
57			/**
58			* Lock the appropriate tables for the script
59			* @param Database $db
60			* @param string $extraTable The name of any extra tables to lock (eg: text)
61			*/
62			private function lockTables( $db, $extraTable = [] ) {
63			$tbls = [ 'page', 'revision', 'redirect' ];
64			if ( $extraTable ) {
65			$tbls = array_merge( $tbls, $extraTable );
66			}
67			$db->lockTables( [], $tbls, __METHOD__, false );
68			}
69
70			/**
71			* Check for orphan revisions
72			* @param bool $fix Whether to fix broken revisions when found
73			*/
74			private function checkOrphans( $fix ) {
75			$dbw = $this->getDB( DB_MASTER );
76			$page = $dbw->tableName( 'page' );
77			$revision = $dbw->tableName( 'revision' );
78
79			if ( $fix ) {
80			$this->lockTables( $dbw );
			0 ignored issues – show Bug introduced 2016-09-29 17:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$dbw` defined by `$this->getDB(DB_MASTER)` on line `75` can be `null`; however, `Orphans::lockTables()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
81			}
82
83			$this->output( "Checking for orphan revision table entries... "
84			. "(this may take a while on a large wiki)\n" );
85			$result = $dbw->query( "
86			SELECT *
87			FROM $revision LEFT OUTER JOIN $page ON rev_page=page_id
88			WHERE page_id IS NULL
89			" );
90			$orphans = $result->numRows();
91			if ( $orphans > 0 ) {
92			global $wgContLang;
93
94			$this->output( "$orphans orphan revisions...\n" );
95			$this->output( sprintf(
96			"%10s %10s %14s %20s %s\n",
97			'rev_id', 'rev_page', 'rev_timestamp', 'rev_user_text', 'rev_comment'
98			) );
99
100			foreach ( $result as $row ) {
101			$comment = ( $row->rev_comment == '' )
102			? ''
103			: '(' . $wgContLang->truncate( $row->rev_comment, 40 ) . ')';
104			$this->output( sprintf( "%10d %10d %14s %20s %s\n",
105			$row->rev_id,
106			$row->rev_page,
107			$row->rev_timestamp,
108			$wgContLang->truncate( $row->rev_user_text, 17 ),
109			$comment ) );
110			if ( $fix ) {
111			$dbw->delete( 'revision', [ 'rev_id' => $row->rev_id ] );
112			}
113			}
114			if ( !$fix ) {
115			$this->output( "Run again with --fix to remove these entries automatically.\n" );
116			}
117			} else {
118			$this->output( "No orphans! Yay!\n" );
119			}
120
121			if ( $fix ) {
122			$dbw->unlockTables( __METHOD__ );
123			}
124			}
125
126			/**
127			* @param bool $fix
128			* @todo DON'T USE THIS YET! It will remove entries which have children,
129			* but which aren't properly attached (eg if page_latest is bogus
130			* but valid revisions do exist)
131			*/
132			private function checkWidows( $fix ) {
133			$dbw = $this->getDB( DB_MASTER );
134			$page = $dbw->tableName( 'page' );
135			$revision = $dbw->tableName( 'revision' );
136
137			if ( $fix ) {
138			$this->lockTables( $dbw );
			0 ignored issues – show Bug introduced 2016-09-29 17:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$dbw` defined by `$this->getDB(DB_MASTER)` on line `133` can be `null`; however, `Orphans::lockTables()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
139			}
140
141			$this->output( "\nChecking for childless page table entries... "
142			. "(this may take a while on a large wiki)\n" );
143			$result = $dbw->query( "
144			SELECT *
145			FROM $page LEFT OUTER JOIN $revision ON page_latest=rev_id
146			WHERE rev_id IS NULL
147			" );
148			$widows = $result->numRows();
149			if ( $widows > 0 ) {
150			$this->output( "$widows childless pages...\n" );
151			$this->output( sprintf( "%10s %11s %2s %s\n", 'page_id', 'page_latest', 'ns', 'page_title' ) );
152			foreach ( $result as $row ) {
153			printf( "%10d %11d %2d %s\n",
154			$row->page_id,
155			$row->page_latest,
156			$row->page_namespace,
157			$row->page_title );
158			if ( $fix ) {
159			$dbw->delete( 'page', [ 'page_id' => $row->page_id ] );
160			}
161			}
162			if ( !$fix ) {
163			$this->output( "Run again with --fix to remove these entries automatically.\n" );
164			}
165			} else {
166			$this->output( "No childless pages! Yay!\n" );
167			}
168
169			if ( $fix ) {
170			$dbw->unlockTables( __METHOD__ );
171			}
172			}
173
174			/**
175			* Check for pages where page_latest is wrong
176			* @param bool $fix Whether to fix broken entries
177			*/
178			private function checkSeparation( $fix ) {
179			$dbw = $this->getDB( DB_MASTER );
180			$page = $dbw->tableName( 'page' );
181			$revision = $dbw->tableName( 'revision' );
182
183			if ( $fix ) {
184			$this->lockTables( $dbw, [ 'user', 'text' ] );
			0 ignored issues – show Bug introduced 2016-09-29 17:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$dbw` defined by `$this->getDB(DB_MASTER)` on line `179` can be `null`; however, `Orphans::lockTables()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
185			}
186
187			$this->output( "\nChecking for pages whose page_latest links are incorrect... "
188			. "(this may take a while on a large wiki)\n" );
189			$result = $dbw->query( "
190			SELECT *
191			FROM $page LEFT OUTER JOIN $revision ON page_latest=rev_id
192			" );
193			$found = 0;
194			foreach ( $result as $row ) {
195			$result2 = $dbw->query( "
196			SELECT MAX(rev_timestamp) as max_timestamp
197			FROM $revision
198			WHERE rev_page=$row->page_id
199			" );
200			$row2 = $dbw->fetchObject( $result2 );
201			if ( $row2 ) {
202			if ( $row->rev_timestamp != $row2->max_timestamp ) {
203			if ( $found == 0 ) {
204			$this->output( sprintf( "%10s %10s %14s %14s\n",
205			'page_id', 'rev_id', 'timestamp', 'max timestamp' ) );
206			}
207			++$found;
208			$this->output( sprintf( "%10d %10d %14s %14s\n",
209			$row->page_id,
210			$row->page_latest,
211			$row->rev_timestamp,
212			$row2->max_timestamp ) );
213			if ( $fix ) {
214			# ...
215			$maxId = $dbw->selectField(
216			'revision',
217			'rev_id',
218			[
219			'rev_page' => $row->page_id,
220			'rev_timestamp' => $row2->max_timestamp ] );
221			$this->output( "... updating to revision $maxId\n" );
222			$maxRev = Revision::newFromId( $maxId );
223			$title = Title::makeTitle( $row->page_namespace, $row->page_title );
224			$article = WikiPage::factory( $title );
225			$article->updateRevisionOn( $dbw, $maxRev );
			0 ignored issues – show Bug introduced 2016-02-23 18:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$maxRev` defined by `\Revision::newFromId($maxId)` on line `222` can be `null`; however, `WikiPage::updateRevisionOn()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null / function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history... Bug introduced 2016-09-24 18:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$dbw` defined by `$this->getDB(DB_MASTER)` on line `179` can be `null`; however, `WikiPage::updateRevisionOn()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /* @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
226			}
227			}
228			} else {
229			$this->output( "wtf\n" );
230			}
231			}
232
233			if ( $found ) {
234			$this->output( "Found $found pages with incorrect latest revision.\n" );
235			} else {
236			$this->output( "No pages with incorrect latest revision. Yay!\n" );
237			}
238			if ( !$fix && $found > 0 ) {
239			$this->output( "Run again with --fix to remove these entries automatically.\n" );
240			}
241
242			if ( $fix ) {
243			$dbw->unlockTables( __METHOD__ );
244			}
245			}
246			}
247
248			$maintClass = "Orphans";
249			require_once RUN_MAINTENANCE_IF_MAIN;
250

wikimedia / mediawiki

Issues (4122)

Security Analysis not enabled

maintenance/orphans.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like