Issues in ImageHistoryPseudoPager.php (master) - Issues in master - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4122)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/page/ImageHistoryPseudoPager.php (3 issues)

Labels

Bug 3

Severity

Major 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 * http://www.gnu.org/copyleft/gpl.html
 *
 * @file
 */

class ImageHistoryPseudoPager extends ReverseChronologicalPager {
	protected $preventClickjacking = false;

	/**
	 * @var File
	 */
	protected $mImg;

	/**
	 * @var Title
	 */
	protected $mTitle;

	/**
	 * @param ImagePage $imagePage
	 */
	function __construct( $imagePage ) {
		parent::__construct( $imagePage->getContext() );
		$this->mImagePage = $imagePage;
class MyClass { }

$x = new MyClass();
$x->foo = true;
		$this->mTitle = clone $imagePage->getTitle();
		$this->mTitle->setFragment( '#filehistory' );
		$this->mImg = null;
		$this->mHist = [];
class MyClass { }

$x = new MyClass();
$x->foo = true;
		$this->mRange = [ 0, 0 ]; // display range
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}

	/**
	 * @return Title
	 */
	function getTitle() {
		return $this->mTitle;
	}

	function getQueryInfo() {
		return false;
	}

	/**
	 * @return string
	 */
	function getIndexField() {
		return '';
	}

	/**
	 * @param object $row
	 * @return string
	 */
	function formatRow( $row ) {
		return '';
	}

	/**
	 * @return string
	 */
	function getBody() {
		$s = '';
		$this->doQuery();
		if ( count( $this->mHist ) ) {
			if ( $this->mImg->isLocal() ) {
				// Do a batch existence check for user pages and talkpages
				$linkBatch = new LinkBatch();
				for ( $i = $this->mRange[0]; $i <= $this->mRange[1]; $i++ ) {
					$file = $this->mHist[$i];
					$user = $file->getUser( 'text' );
					$linkBatch->add( NS_USER, $user );
					$linkBatch->add( NS_USER_TALK, $user );
				}
				$linkBatch->execute();
			}

			$list = new ImageHistoryList( $this->mImagePage );
			# Generate prev/next links
			$navLink = $this->getNavigationBar();
			$s = $list->beginImageHistoryList( $navLink );
			// Skip rows there just for paging links
			for ( $i = $this->mRange[0]; $i <= $this->mRange[1]; $i++ ) {
				$file = $this->mHist[$i];
				$s .= $list->imageHistoryLine( !$file->isOld(), $file );
			}
			$s .= $list->endImageHistoryList( $navLink );

			if ( $list->getPreventClickjacking() ) {
				$this->preventClickjacking();
			}
		}
		return $s;
	}

	function doQuery() {
		if ( $this->mQueryDone ) {
			return;
		}
		$this->mImg = $this->mImagePage->getPage()->getFile(); // ensure loading
		if ( !$this->mImg->exists() ) {
			return;
		}
		$queryLimit = $this->mLimit + 1; // limit plus extra row
		if ( $this->mIsBackwards ) {
			// Fetch the file history
			$this->mHist = $this->mImg->getHistory( $queryLimit, null, $this->mOffset, false );
			// The current rev may not meet the offset/limit
			$numRows = count( $this->mHist );
			if ( $numRows <= $this->mLimit && $this->mImg->getTimestamp() > $this->mOffset ) {
				$this->mHist = array_merge( [ $this->mImg ], $this->mHist );
			}
		} else {
			// The current rev may not meet the offset
			if ( !$this->mOffset || $this->mImg->getTimestamp() < $this->mOffset ) {
				$this->mHist[] = $this->mImg;
			}
			// Old image versions (fetch extra row for nav links)
			$oiLimit = count( $this->mHist ) ? $this->mLimit : $this->mLimit + 1;
			// Fetch the file history
			$this->mHist = array_merge( $this->mHist,
				$this->mImg->getHistory( $oiLimit, $this->mOffset, null, false ) );
		}
		$numRows = count( $this->mHist ); // Total number of query results
		if ( $numRows ) {
			# Index value of top item in the list
			$firstIndex = $this->mIsBackwards ?
				$this->mHist[$numRows - 1]->getTimestamp() : $this->mHist[0]->getTimestamp();
			# Discard the extra result row if there is one
			if ( $numRows > $this->mLimit && $numRows > 1 ) {
				if ( $this->mIsBackwards ) {
					# Index value of item past the index
					$this->mPastTheEndIndex = $this->mHist[0]->getTimestamp();
					# Index value of bottom item in the list
					$lastIndex = $this->mHist[1]->getTimestamp();
					# Display range
					$this->mRange = [ 1, $numRows - 1 ];
				} else {
					# Index value of item past the index
					$this->mPastTheEndIndex = $this->mHist[$numRows - 1]->getTimestamp();
					# Index value of bottom item in the list
					$lastIndex = $this->mHist[$numRows - 2]->getTimestamp();
					# Display range
					$this->mRange = [ 0, $numRows - 2 ];
				}
			} else {
				# Setting indexes to an empty string means that they will be
				# omitted if they would otherwise appear in URLs. It just so
				# happens that this  is the right thing to do in the standard
				# UI, in all the relevant cases.
				$this->mPastTheEndIndex = '';
				# Index value of bottom item in the list
				$lastIndex = $this->mIsBackwards ?
					$this->mHist[0]->getTimestamp() : $this->mHist[$numRows - 1]->getTimestamp();
				# Display range
				$this->mRange = [ 0, $numRows - 1 ];
			}
		} else {
			$firstIndex = '';
			$lastIndex = '';
			$this->mPastTheEndIndex = '';
		}
		if ( $this->mIsBackwards ) {
			$this->mIsFirst = ( $numRows < $queryLimit );
			$this->mIsLast = ( $this->mOffset == '' );
			$this->mLastShown = $firstIndex;
			$this->mFirstShown = $lastIndex;
		} else {
			$this->mIsFirst = ( $this->mOffset == '' );
			$this->mIsLast = ( $numRows < $queryLimit );
			$this->mLastShown = $lastIndex;
			$this->mFirstShown = $firstIndex;
		}
		$this->mQueryDone = true;
	}

	/**
	 * @param bool $enable
	 */
	protected function preventClickjacking( $enable = true ) {
		$this->preventClickjacking = $enable;
	}

	/**
	 * @return bool
	 */
	public function getPreventClickjacking() {
		return $this->preventClickjacking;
	}

}


1		<?php
2		/**
3		* This program is free software; you can redistribute it and/or modify
4		* it under the terms of the GNU General Public License as published by
5		* the Free Software Foundation; either version 2 of the License, or
6		* (at your option) any later version.
7		*
8		* This program is distributed in the hope that it will be useful,
9		* but WITHOUT ANY WARRANTY; without even the implied warranty of
10		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11		* GNU General Public License for more details.
12		*
13		* You should have received a copy of the GNU General Public License along
14		* with this program; if not, write to the Free Software Foundation, Inc.,
15		* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16		* http://www.gnu.org/copyleft/gpl.html
17		*
18		* @file
19		*/
20
21		class ImageHistoryPseudoPager extends ReverseChronologicalPager {
22		protected $preventClickjacking = false;
23
24		/**
25		* @var File
26		*/
27		protected $mImg;
28
29		/**
30		* @var Title
31		*/
32		protected $mTitle;
33
34		/**
35		* @param ImagePage $imagePage
36		*/
37		function __construct( $imagePage ) {
38		parent::__construct( $imagePage->getContext() );
39		$this->mImagePage = $imagePage;
		0 ignored issues – show Bug introduced 2016-01-16 18:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `mImagePage` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
40		$this->mTitle = clone $imagePage->getTitle();
41		$this->mTitle->setFragment( '#filehistory' );
42		$this->mImg = null;
43		$this->mHist = [];
		0 ignored issues – show Bug introduced 2016-01-16 18:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `mHist` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44		$this->mRange = [ 0, 0 ]; // display range
		0 ignored issues – show Bug introduced 2016-01-16 18:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `mRange` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
45		}
46
47		/**
48		* @return Title
49		*/
50		function getTitle() {
51		return $this->mTitle;
52		}
53
54		function getQueryInfo() {
55		return false;
56		}
57
58		/**
59		* @return string
60		*/
61		function getIndexField() {
62		return '';
63		}
64
65		/**
66		* @param object $row
67		* @return string
68		*/
69		function formatRow( $row ) {
70		return '';
71		}
72
73		/**
74		* @return string
75		*/
76		function getBody() {
77		$s = '';
78		$this->doQuery();
79		if ( count( $this->mHist ) ) {
80		if ( $this->mImg->isLocal() ) {
81		// Do a batch existence check for user pages and talkpages
82		$linkBatch = new LinkBatch();
83		for ( $i = $this->mRange[0]; $i <= $this->mRange[1]; $i++ ) {
84		$file = $this->mHist[$i];
85		$user = $file->getUser( 'text' );
86		$linkBatch->add( NS_USER, $user );
87		$linkBatch->add( NS_USER_TALK, $user );
88		}
89		$linkBatch->execute();
90		}
91
92		$list = new ImageHistoryList( $this->mImagePage );
93		# Generate prev/next links
94		$navLink = $this->getNavigationBar();
95		$s = $list->beginImageHistoryList( $navLink );
96		// Skip rows there just for paging links
97		for ( $i = $this->mRange[0]; $i <= $this->mRange[1]; $i++ ) {
98		$file = $this->mHist[$i];
99		$s .= $list->imageHistoryLine( !$file->isOld(), $file );
100		}
101		$s .= $list->endImageHistoryList( $navLink );
102
103		if ( $list->getPreventClickjacking() ) {
104		$this->preventClickjacking();
105		}
106		}
107		return $s;
108		}
109
110		function doQuery() {
111		if ( $this->mQueryDone ) {
112		return;
113		}
114		$this->mImg = $this->mImagePage->getPage()->getFile(); // ensure loading
115		if ( !$this->mImg->exists() ) {
116		return;
117		}
118		$queryLimit = $this->mLimit + 1; // limit plus extra row
119		if ( $this->mIsBackwards ) {
120		// Fetch the file history
121		$this->mHist = $this->mImg->getHistory( $queryLimit, null, $this->mOffset, false );
122		// The current rev may not meet the offset/limit
123		$numRows = count( $this->mHist );
124		if ( $numRows <= $this->mLimit && $this->mImg->getTimestamp() > $this->mOffset ) {
125		$this->mHist = array_merge( [ $this->mImg ], $this->mHist );
126		}
127		} else {
128		// The current rev may not meet the offset
129		if ( !$this->mOffset \|\| $this->mImg->getTimestamp() < $this->mOffset ) {
130		$this->mHist[] = $this->mImg;
131		}
132		// Old image versions (fetch extra row for nav links)
133		$oiLimit = count( $this->mHist ) ? $this->mLimit : $this->mLimit + 1;
134		// Fetch the file history
135		$this->mHist = array_merge( $this->mHist,
136		$this->mImg->getHistory( $oiLimit, $this->mOffset, null, false ) );
137		}
138		$numRows = count( $this->mHist ); // Total number of query results
139		if ( $numRows ) {
140		# Index value of top item in the list
141		$firstIndex = $this->mIsBackwards ?
142		$this->mHist[$numRows - 1]->getTimestamp() : $this->mHist[0]->getTimestamp();
143		# Discard the extra result row if there is one
144		if ( $numRows > $this->mLimit && $numRows > 1 ) {
145		if ( $this->mIsBackwards ) {
146		# Index value of item past the index
147		$this->mPastTheEndIndex = $this->mHist[0]->getTimestamp();
148		# Index value of bottom item in the list
149		$lastIndex = $this->mHist[1]->getTimestamp();
150		# Display range
151		$this->mRange = [ 1, $numRows - 1 ];
152	View Code Duplication	} else {
153		# Index value of item past the index
154		$this->mPastTheEndIndex = $this->mHist[$numRows - 1]->getTimestamp();
155		# Index value of bottom item in the list
156		$lastIndex = $this->mHist[$numRows - 2]->getTimestamp();
157		# Display range
158		$this->mRange = [ 0, $numRows - 2 ];
159		}
160	View Code Duplication	} else {
161		# Setting indexes to an empty string means that they will be
162		# omitted if they would otherwise appear in URLs. It just so
163		# happens that this is the right thing to do in the standard
164		# UI, in all the relevant cases.
165		$this->mPastTheEndIndex = '';
166		# Index value of bottom item in the list
167		$lastIndex = $this->mIsBackwards ?
168		$this->mHist[0]->getTimestamp() : $this->mHist[$numRows - 1]->getTimestamp();
169		# Display range
170		$this->mRange = [ 0, $numRows - 1 ];
171		}
172		} else {
173		$firstIndex = '';
174		$lastIndex = '';
175		$this->mPastTheEndIndex = '';
176		}
177		if ( $this->mIsBackwards ) {
178		$this->mIsFirst = ( $numRows < $queryLimit );
179		$this->mIsLast = ( $this->mOffset == '' );
180		$this->mLastShown = $firstIndex;
181		$this->mFirstShown = $lastIndex;
182		} else {
183		$this->mIsFirst = ( $this->mOffset == '' );
184		$this->mIsLast = ( $numRows < $queryLimit );
185		$this->mLastShown = $lastIndex;
186		$this->mFirstShown = $firstIndex;
187		}
188		$this->mQueryDone = true;
189		}
190
191		/**
192		* @param bool $enable
193		*/
194		protected function preventClickjacking( $enable = true ) {
195		$this->preventClickjacking = $enable;
196		}
197
198		/**
199		* @return bool
200		*/
201		public function getPreventClickjacking() {
202		return $this->preventClickjacking;
203		}
204
205		}
206

wikimedia / mediawiki

Issues (4122)

Security Analysis not enabled

includes/page/ImageHistoryPseudoPager.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like