Issues (4122)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/logging/PatrolLog.php (1 issue)

Labels
Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/**
3
 * Specific methods for the patrol log.
4
 *
5
 * This program is free software; you can redistribute it and/or modify
6
 * it under the terms of the GNU General Public License as published by
7
 * the Free Software Foundation; either version 2 of the License, or
8
 * (at your option) any later version.
9
 *
10
 * This program is distributed in the hope that it will be useful,
11
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13
 * GNU General Public License for more details.
14
 *
15
 * You should have received a copy of the GNU General Public License along
16
 * with this program; if not, write to the Free Software Foundation, Inc.,
17
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18
 * http://www.gnu.org/copyleft/gpl.html
19
 *
20
 * @file
21
 * @author Rob Church <[email protected]>
22
 * @author Niklas Laxström
23
 */
24
25
/**
26
 * Class containing static functions for working with
27
 * logs of patrol events
28
 */
29
class PatrolLog {
30
	/**
31
	 * Record a log event for a change being patrolled
32
	 *
33
	 * @param int|RecentChange $rc Change identifier or RecentChange object
34
	 * @param bool $auto Was this patrol event automatic?
35
	 * @param User $user User performing the action or null to use $wgUser
36
	 * @param string|string[] $tags Change tags to add to the patrol log entry
37
	 *   ($user should be able to add the specified tags before this is called)
38
	 *
39
	 * @return bool
40
	 */
41
	public static function record( $rc, $auto = false, User $user = null, $tags = null ) {
42
		global $wgLogAutopatrol;
43
44
		// do not log autopatrolled edits if setting disables it
45
		if ( $auto && !$wgLogAutopatrol ) {
46
			return false;
47
		}
48
49
		if ( !$rc instanceof RecentChange ) {
50
			$rc = RecentChange::newFromId( $rc );
51
			if ( !is_object( $rc ) ) {
52
				return false;
53
			}
54
		}
55
56
		if ( !$user ) {
57
			global $wgUser;
58
			$user = $wgUser;
59
		}
60
61
		$action = $auto ? 'autopatrol' : 'patrol';
62
63
		$entry = new ManualLogEntry( 'patrol', $action );
64
		$entry->setTarget( $rc->getTitle() );
65
		$entry->setParameters( self::buildParams( $rc, $auto ) );
66
		$entry->setPerformer( $user );
67
		$entry->setTags( $tags );
0 ignored issues
show
It seems like $tags defined by parameter $tags on line 41 can also be of type null; however, ManualLogEntry::setTags() does only seem to accept string|array<integer,string>, maybe add an additional type check?

This check looks at variables that have been passed in as parameters and are passed out again to other methods.

If the outgoing method call has stricter type requirements than the method itself, an issue is raised.

An additional type check may prevent trouble.

Loading history...
68
		$logid = $entry->insert();
69
		if ( !$auto ) {
70
			$entry->publish( $logid, 'udp' );
71
		}
72
73
		return true;
74
	}
75
76
	/**
77
	 * Prepare log parameters for a patrolled change
78
	 *
79
	 * @param RecentChange $change RecentChange to represent
80
	 * @param bool $auto Whether the patrol event was automatic
81
	 * @return array
82
	 */
83
	private static function buildParams( $change, $auto ) {
84
		return [
85
			'4::curid' => $change->getAttribute( 'rc_this_oldid' ),
86
			'5::previd' => $change->getAttribute( 'rc_last_oldid' ),
87
			'6::auto' => (int)$auto
88
		];
89
	}
90
}
91