Issues in CachedBagOStuff.php (master) - Issues in master - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4122)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/libs/objectcache/CachedBagOStuff.php (1 issue)

Labels

Unused Code 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Wrapper around a BagOStuff that caches data in memory
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 * http://www.gnu.org/copyleft/gpl.html
 *
 * @file
 * @ingroup Cache
 */

/**
 * Wrapper around a BagOStuff that caches data in memory
 *
 * The differences between CachedBagOStuff and MultiWriteBagOStuff are:
 * * CachedBagOStuff supports only one "backend".
 * * There's a flag for writes to only go to the in-memory cache.
 * * The in-memory cache is always updated.
 * * Locks go to the backend cache (with MultiWriteBagOStuff, it would wind
 *   up going to the HashBagOStuff used for the in-memory cache).
 *
 * @ingroup Cache
 */
class CachedBagOStuff extends HashBagOStuff {
	/** @var BagOStuff */
	protected $backend;

	/**
	 * @param BagOStuff $backend Permanent backend to use
	 * @param array $params Parameters for HashBagOStuff
	 */
	function __construct( BagOStuff $backend, $params = [] ) {
		unset( $params['reportDupes'] ); // useless here

		parent::__construct( $params );

		$this->backend = $backend;
		$this->attrMap = $backend->attrMap;
	}

	protected function doGet( $key, $flags = 0 ) {
		$ret = parent::doGet( $key, $flags );
		if ( $ret === false && !$this->hasKey( $key ) ) {
			$ret = $this->backend->doGet( $key, $flags );
			$this->set( $key, $ret, 0, self::WRITE_CACHE_ONLY );
		}
		return $ret;
	}

	public function set( $key, $value, $exptime = 0, $flags = 0 ) {
		parent::set( $key, $value, $exptime, $flags );
		if ( !( $flags & self::WRITE_CACHE_ONLY ) ) {
			$this->backend->set( $key, $value, $exptime, $flags & ~self::WRITE_CACHE_ONLY );
		}
		return true;
	}

	public function delete( $key, $flags = 0 ) {
		unset( $this->bag[$key] );
		if ( !( $flags & self::WRITE_CACHE_ONLY ) ) {
			$this->backend->delete( $key );
		}

		return true;
	}

	public function setDebug( $bool ) {
		parent::setDebug( $bool );
		$this->backend->setDebug( $bool );
	}

	public function lock( $key, $timeout = 6, $expiry = 6, $rclass = '' ) {
		return $this->backend->lock( $key, $timeout, $expiry, $rclass );
	}

	public function unlock( $key ) {
		return $this->backend->unlock( $key );
	}

	public function deleteObjectsExpiringBefore( $date, $progressCallback = false ) {
		parent::deleteObjectsExpiringBefore( $date, $progressCallback );
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
		return $this->backend->deleteObjectsExpiringBefore( $date, $progressCallback );
	}

	public function getLastError() {
		return $this->backend->getLastError();
	}

	public function clearLastError() {
		$this->backend->clearLastError();
	}

	public function modifySimpleRelayEvent( array $event ) {
		return $this->backend->modifySimpleRelayEvent( $event );
	}

}


1			<?php
2			/**
3			* Wrapper around a BagOStuff that caches data in memory
4			*
5			* This program is free software; you can redistribute it and/or modify
6			* it under the terms of the GNU General Public License as published by
7			* the Free Software Foundation; either version 2 of the License, or
8			* (at your option) any later version.
9			*
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13			* GNU General Public License for more details.
14			*
15			* You should have received a copy of the GNU General Public License along
16			* with this program; if not, write to the Free Software Foundation, Inc.,
17			* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18			* http://www.gnu.org/copyleft/gpl.html
19			*
20			* @file
21			* @ingroup Cache
22			*/
23
24			/**
25			* Wrapper around a BagOStuff that caches data in memory
26			*
27			* The differences between CachedBagOStuff and MultiWriteBagOStuff are:
28			* * CachedBagOStuff supports only one "backend".
29			* * There's a flag for writes to only go to the in-memory cache.
30			* * The in-memory cache is always updated.
31			* * Locks go to the backend cache (with MultiWriteBagOStuff, it would wind
32			* up going to the HashBagOStuff used for the in-memory cache).
33			*
34			* @ingroup Cache
35			*/
36			class CachedBagOStuff extends HashBagOStuff {
37			/** @var BagOStuff */
38			protected $backend;
39
40			/**
41			* @param BagOStuff $backend Permanent backend to use
42			* @param array $params Parameters for HashBagOStuff
43			*/
44			function __construct( BagOStuff $backend, $params = [] ) {
45			unset( $params['reportDupes'] ); // useless here
46
47			parent::__construct( $params );
48
49			$this->backend = $backend;
50			$this->attrMap = $backend->attrMap;
51			}
52
53			protected function doGet( $key, $flags = 0 ) {
54			$ret = parent::doGet( $key, $flags );
55			if ( $ret === false && !$this->hasKey( $key ) ) {
56			$ret = $this->backend->doGet( $key, $flags );
57			$this->set( $key, $ret, 0, self::WRITE_CACHE_ONLY );
58			}
59			return $ret;
60			}
61
62			public function set( $key, $value, $exptime = 0, $flags = 0 ) {
63			parent::set( $key, $value, $exptime, $flags );
64			if ( !( $flags & self::WRITE_CACHE_ONLY ) ) {
65			$this->backend->set( $key, $value, $exptime, $flags & ~self::WRITE_CACHE_ONLY );
66			}
67			return true;
68			}
69
70			public function delete( $key, $flags = 0 ) {
71			unset( $this->bag[$key] );
72			if ( !( $flags & self::WRITE_CACHE_ONLY ) ) {
73			$this->backend->delete( $key );
74			}
75
76			return true;
77			}
78
79			public function setDebug( $bool ) {
80			parent::setDebug( $bool );
81			$this->backend->setDebug( $bool );
82			}
83
84			public function lock( $key, $timeout = 6, $expiry = 6, $rclass = '' ) {
85			return $this->backend->lock( $key, $timeout, $expiry, $rclass );
86			}
87
88			public function unlock( $key ) {
89			return $this->backend->unlock( $key );
90			}
91
92			public function deleteObjectsExpiringBefore( $date, $progressCallback = false ) {
93			parent::deleteObjectsExpiringBefore( $date, $progressCallback );
			0 ignored issues – show Unused Code introduced 2016-02-23 18:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to the method `HashBagOStuff::deleteObjectsExpiringBefore()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
94			return $this->backend->deleteObjectsExpiringBefore( $date, $progressCallback );
95			}
96
97			public function getLastError() {
98			return $this->backend->getLastError();
99			}
100
101			public function clearLastError() {
102			$this->backend->clearLastError();
103			}
104
105			public function modifySimpleRelayEvent( array $event ) {
106			return $this->backend->modifySimpleRelayEvent( $event );
107			}
108
109			}
110

wikimedia / mediawiki

Issues (4122)

Security Analysis not enabled

includes/libs/objectcache/CachedBagOStuff.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like