Issues in PackedImageGallery.php (master) - Issues in master - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4122)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/gallery/PackedImageGallery.php (4 issues)

Labels

Bug 4

Severity

Major 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Packed image gallery. All images adjusted to be same height.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 * http://www.gnu.org/copyleft/gpl.html
 *
 * @file
 */

class PackedImageGallery extends TraditionalImageGallery {
	function __construct( $mode = 'traditional', IContextSource $context = null ) {
		parent::__construct( $mode, $context );
		// Does not support per row option.
		$this->mPerRow = 0;
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}

	/**
	 * We artificially have 1.5 the resolution neccessary so that
	 * we can scale it up by that much on the client side, without
	 * worrying about requesting a new image.
	 */
	const SCALE_FACTOR = 1.5;

	protected function getVPad( $boxHeight, $thumbHeight ) {
		return ( $this->getThumbPadding() + $boxHeight - $thumbHeight / self::SCALE_FACTOR ) / 2;
	}

	protected function getThumbPadding() {
		return 0;
	}

	protected function getGBPadding() {
		return 2;
	}

	/**
	 * @param File $img The file being transformed. May be false
	 * @return array
	 */
	protected function getThumbParams( $img ) {
		if ( $img && $img->getMediaType() === MEDIATYPE_AUDIO ) {
			$width = $this->mWidths;
class MyClass { }

$x = new MyClass();
$x->foo = true;
		} else {
			// We want the width not to be the constraining
			// factor, so use random big number.
			$width = $this->mHeights * 10 + 100;
class MyClass { }

$x = new MyClass();
$x->foo = true;
		}

		// self::SCALE_FACTOR so the js has some room to manipulate sizes.
		return [
			'width' => $width * self::SCALE_FACTOR,
			'height' => $this->mHeights * self::SCALE_FACTOR,
		];
	}

	protected function getThumbDivWidth( $thumbWidth ) {
		// Require at least 60px wide, so caption is wide enough to work.
		if ( $thumbWidth < 60 * self::SCALE_FACTOR ) {
			$thumbWidth = 60 * self::SCALE_FACTOR;
		}

		return $thumbWidth / self::SCALE_FACTOR + $this->getThumbPadding();
	}

	/**
	 * @param MediaTransformOutput|bool $thumb The thumbnail, or false if no
	 *   thumb (which can happen)
	 * @return float
	 */
	protected function getGBWidth( $thumb ) {
		$thumbWidth = $thumb ? $thumb->getWidth() : $this->mWidths * self::SCALE_FACTOR;
function someFunction(A $objectMaybe = null)
{
    if ($objectMaybe instanceof A) {
        $objectMaybe->doSomething();
    }
}

		return $this->getThumbDivWidth( $thumbWidth ) + $this->getGBPadding();
	}

	protected function adjustImageParameters( $thumb, &$imageParameters ) {
		// Re-adjust back to normal size.
		$imageParameters['override-width'] = ceil( $thumb->getWidth() / self::SCALE_FACTOR );
		$imageParameters['override-height'] = ceil( $thumb->getHeight() / self::SCALE_FACTOR );
	}

	/**
	 * Add javascript which auto-justifies the rows by manipulating the image sizes.
	 * Also ensures that the hover version of this degrades gracefully.
	 * @return array
	 */
	protected function getModules() {
		return [ 'mediawiki.page.gallery' ];
	}

	/**
	 * Do not support per-row on packed. It really doesn't work
	 * since the images have varying widths.
	 * @param int $num
	 */
	public function setPerRow( $num ) {
		return;
	}
}


1			<?php
2			/**
3			* Packed image gallery. All images adjusted to be same height.
4			*
5			* This program is free software; you can redistribute it and/or modify
6			* it under the terms of the GNU General Public License as published by
7			* the Free Software Foundation; either version 2 of the License, or
8			* (at your option) any later version.
9			*
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13			* GNU General Public License for more details.
14			*
15			* You should have received a copy of the GNU General Public License along
16			* with this program; if not, write to the Free Software Foundation, Inc.,
17			* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18			* http://www.gnu.org/copyleft/gpl.html
19			*
20			* @file
21			*/
22
23			class PackedImageGallery extends TraditionalImageGallery {
24			function __construct( $mode = 'traditional', IContextSource $context = null ) {
25			parent::__construct( $mode, $context );
26			// Does not support per row option.
27			$this->mPerRow = 0;
			0 ignored issues – show Bug introduced 2016-01-16 18:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `mPerRow` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28			}
29
30			/**
31			* We artificially have 1.5 the resolution neccessary so that
32			* we can scale it up by that much on the client side, without
33			* worrying about requesting a new image.
34			*/
35			const SCALE_FACTOR = 1.5;
36
37			protected function getVPad( $boxHeight, $thumbHeight ) {
38			return ( $this->getThumbPadding() + $boxHeight - $thumbHeight / self::SCALE_FACTOR ) / 2;
39			}
40
41			protected function getThumbPadding() {
42			return 0;
43			}
44
45			protected function getGBPadding() {
46			return 2;
47			}
48
49			/**
50			* @param File $img The file being transformed. May be false
51			* @return array
52			*/
53			protected function getThumbParams( $img ) {
54			if ( $img && $img->getMediaType() === MEDIATYPE_AUDIO ) {
55			$width = $this->mWidths;
			0 ignored issues – show Bug introduced 2016-01-16 18:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `mWidths` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
56			} else {
57			// We want the width not to be the constraining
58			// factor, so use random big number.
59			$width = $this->mHeights * 10 + 100;
			0 ignored issues – show Bug introduced 2016-01-16 18:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `mHeights` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
60			}
61
62			// self::SCALE_FACTOR so the js has some room to manipulate sizes.
63			return [
64			'width' => $width * self::SCALE_FACTOR,
65			'height' => $this->mHeights * self::SCALE_FACTOR,
66			];
67			}
68
69			protected function getThumbDivWidth( $thumbWidth ) {
70			// Require at least 60px wide, so caption is wide enough to work.
71			if ( $thumbWidth < 60 * self::SCALE_FACTOR ) {
72			$thumbWidth = 60 * self::SCALE_FACTOR;
73			}
74
75			return $thumbWidth / self::SCALE_FACTOR + $this->getThumbPadding();
76			}
77
78			/**
79			* @param MediaTransformOutput\|bool $thumb The thumbnail, or false if no
80			* thumb (which can happen)
81			* @return float
82			*/
83			protected function getGBWidth( $thumb ) {
84			$thumbWidth = $thumb ? $thumb->getWidth() : $this->mWidths * self::SCALE_FACTOR;
			0 ignored issues – show Bug introduced 2016-01-16 18:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$thumb` is not always an object, but can also be of type `boolean`. Maybe add an additional type check? If a variable is not always an object, we recommend to add an additional type check to ensure your method call is safe: function someFunction(A $objectMaybe = null) { if ($objectMaybe instanceof A) { $objectMaybe->doSomething(); } } Loading history...
85
86			return $this->getThumbDivWidth( $thumbWidth ) + $this->getGBPadding();
87			}
88
89			protected function adjustImageParameters( $thumb, &$imageParameters ) {
90			// Re-adjust back to normal size.
91			$imageParameters['override-width'] = ceil( $thumb->getWidth() / self::SCALE_FACTOR );
92			$imageParameters['override-height'] = ceil( $thumb->getHeight() / self::SCALE_FACTOR );
93			}
94
95			/**
96			* Add javascript which auto-justifies the rows by manipulating the image sizes.
97			* Also ensures that the hover version of this degrades gracefully.
98			* @return array
99			*/
100			protected function getModules() {
101			return [ 'mediawiki.page.gallery' ];
102			}
103
104			/**
105			* Do not support per-row on packed. It really doesn't work
106			* since the images have varying widths.
107			* @param int $num
108			*/
109			public function setPerRow( $num ) {
110			return;
111			}
112			}
113

wikimedia / mediawiki

Issues (4122)

Security Analysis not enabled

includes/gallery/PackedImageGallery.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like