Issues in ForeignDBViaLBRepo.php (master) - Issues in master - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4122)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/filerepo/ForeignDBViaLBRepo.php (3 issues)

Labels

Deprecated Code 3

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * A foreign repository with a MediaWiki database accessible via the configured LBFactory.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 * http://www.gnu.org/copyleft/gpl.html
 *
 * @file
 * @ingroup FileRepo
 */

/**
 * A foreign repository with a MediaWiki database accessible via the configured LBFactory
 *
 * @ingroup FileRepo
 */
class ForeignDBViaLBRepo extends LocalRepo {
	/** @var string */
	protected $wiki;

	/** @var string */
	protected $dbName;

	/** @var string */
	protected $tablePrefix;

	/** @var array */
	protected $fileFactory = [ 'ForeignDBFile', 'newFromTitle' ];

	/** @var array */
	protected $fileFromRowFactory = [ 'ForeignDBFile', 'newFromRow' ];

	/** @var bool */
	protected $hasSharedCache;

	/**
	 * @param array|null $info
	 */
	function __construct( $info ) {
		parent::__construct( $info );
		$this->wiki = $info['wiki'];
		list( $this->dbName, $this->tablePrefix ) = wfSplitWikiID( $this->wiki );
		$this->hasSharedCache = $info['hasSharedCache'];
	}

	/**
	 * @return IDatabase
	 */
	function getMasterDB() {
		return wfGetLB( $this->wiki )->getConnectionRef( DB_MASTER, [], $this->wiki );

	}

	/**
	 * @return IDatabase
	 */
	function getSlaveDB() {
		return wfGetLB( $this->wiki )->getConnectionRef( DB_REPLICA, [], $this->wiki );

	}

	/**
	 * @return Closure
	 */
	protected function getDBFactory() {
		return function( $index ) {
			return wfGetLB( $this->wiki )->getConnectionRef( $index, [], $this->wiki );

		};
	}

	function hasSharedCache() {
		return $this->hasSharedCache;
	}

	/**
	 * Get a key on the primary cache for this repository.
	 * Returns false if the repository's cache is not accessible at this site.
	 * The parameters are the parts of the key, as for wfMemcKey().
	 * @return bool|string
	 */
	function getSharedCacheKey( /*...*/ ) {
		if ( $this->hasSharedCache() ) {
			$args = func_get_args();
			array_unshift( $args, $this->wiki );

			return implode( ':', $args );
		} else {
			return false;
		}
	}

	protected function assertWritableRepo() {
		throw new MWException( get_class( $this ) . ': write operations are not supported.' );
	}

	public function getInfo() {
		return FileRepo::getInfo();
	}
}


1			<?php
2			/**
3			* A foreign repository with a MediaWiki database accessible via the configured LBFactory.
4			*
5			* This program is free software; you can redistribute it and/or modify
6			* it under the terms of the GNU General Public License as published by
7			* the Free Software Foundation; either version 2 of the License, or
8			* (at your option) any later version.
9			*
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13			* GNU General Public License for more details.
14			*
15			* You should have received a copy of the GNU General Public License along
16			* with this program; if not, write to the Free Software Foundation, Inc.,
17			* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18			* http://www.gnu.org/copyleft/gpl.html
19			*
20			* @file
21			* @ingroup FileRepo
22			*/
23
24			/**
25			* A foreign repository with a MediaWiki database accessible via the configured LBFactory
26			*
27			* @ingroup FileRepo
28			*/
29			class ForeignDBViaLBRepo extends LocalRepo {
30			/** @var string */
31			protected $wiki;
32
33			/** @var string */
34			protected $dbName;
35
36			/** @var string */
37			protected $tablePrefix;
38
39			/** @var array */
40			protected $fileFactory = [ 'ForeignDBFile', 'newFromTitle' ];
41
42			/** @var array */
43			protected $fileFromRowFactory = [ 'ForeignDBFile', 'newFromRow' ];
44
45			/** @var bool */
46			protected $hasSharedCache;
47
48			/**
49			* @param array\|null $info
50			*/
51			function __construct( $info ) {
52			parent::__construct( $info );
53			$this->wiki = $info['wiki'];
54			list( $this->dbName, $this->tablePrefix ) = wfSplitWikiID( $this->wiki );
55			$this->hasSharedCache = $info['hasSharedCache'];
56			}
57
58			/**
59			* @return IDatabase
60			*/
61			function getMasterDB() {
62			return wfGetLB( $this->wiki )->getConnectionRef( DB_MASTER, [], $this->wiki );
			0 ignored issues – show Deprecated Code introduced 2016-10-06 17:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this The function `wfGetLB()` has been deprecated with message: since 1.27, use MediaWikiServices::getDBLoadBalancer() or MediaWikiServices::getDBLoadBalancerFactory() instead. This function has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the function will be removed from the class and what other function to use instead. Loading history...
63			}
64
65			/**
66			* @return IDatabase
67			*/
68			function getSlaveDB() {
69			return wfGetLB( $this->wiki )->getConnectionRef( DB_REPLICA, [], $this->wiki );
			0 ignored issues – show Deprecated Code introduced 2016-10-06 17:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this The function `wfGetLB()` has been deprecated with message: since 1.27, use MediaWikiServices::getDBLoadBalancer() or MediaWikiServices::getDBLoadBalancerFactory() instead. This function has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the function will be removed from the class and what other function to use instead. Loading history...
70			}
71
72			/**
73			* @return Closure
74			*/
75			protected function getDBFactory() {
76			return function( $index ) {
77			return wfGetLB( $this->wiki )->getConnectionRef( $index, [], $this->wiki );
			0 ignored issues – show Deprecated Code introduced 2016-10-06 17:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this The function `wfGetLB()` has been deprecated with message: since 1.27, use MediaWikiServices::getDBLoadBalancer() or MediaWikiServices::getDBLoadBalancerFactory() instead. This function has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the function will be removed from the class and what other function to use instead. Loading history...
78			};
79			}
80
81			function hasSharedCache() {
82			return $this->hasSharedCache;
83			}
84
85			/**
86			* Get a key on the primary cache for this repository.
87			* Returns false if the repository's cache is not accessible at this site.
88			* The parameters are the parts of the key, as for wfMemcKey().
89			* @return bool\|string
90			*/
91			function getSharedCacheKey( /.../ ) {
92			if ( $this->hasSharedCache() ) {
93			$args = func_get_args();
94			array_unshift( $args, $this->wiki );
95
96			return implode( ':', $args );
97			} else {
98			return false;
99			}
100			}
101
102			protected function assertWritableRepo() {
103			throw new MWException( get_class( $this ) . ': write operations are not supported.' );
104			}
105
106			public function getInfo() {
107			return FileRepo::getInfo();
108			}
109			}
110

wikimedia / mediawiki

Issues (4122)

Security Analysis not enabled

includes/filerepo/ForeignDBViaLBRepo.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like