Complex classes like DBConnRef often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DBConnRef, and based on these observations, apply Extract Interface, too.
| 1 | <?php | ||
| 10 | class DBConnRef implements IDatabase { | ||
| 11 | /** @var LoadBalancer */ | ||
| 12 | private $lb; | ||
| 13 | |||
| 14 | /** @var DatabaseBase|null */ | ||
| 15 | private $conn; | ||
| 16 | |||
| 17 | /** @var array|null */ | ||
| 18 | private $params; | ||
| 19 | |||
| 20 | /** | ||
| 21 | * @param LoadBalancer $lb | ||
| 22 | * @param DatabaseBase|array $conn Connection or (server index, group, wiki ID) array | ||
| 23 | */ | ||
| 24 | 	public function __construct( LoadBalancer $lb, $conn ) { | ||
| 32 | |||
| 33 | 	function __call( $name, array $arguments ) { | ||
| 41 | |||
| 42 | 	public function getServerInfo() { | ||
| 45 | |||
| 46 | 	public function bufferResults( $buffer = null ) { | ||
| 49 | |||
| 50 | 	public function trxLevel() { | ||
| 53 | |||
| 54 | 	public function trxTimestamp() { | ||
| 57 | |||
| 58 | 	public function explicitTrxActive() { | ||
| 61 | |||
| 62 | 	public function tablePrefix( $prefix = null ) { | ||
| 65 | |||
| 66 | 	public function dbSchema( $schema = null ) { | ||
| 69 | |||
| 70 | 	public function getLBInfo( $name = null ) { | ||
| 73 | |||
| 74 | 	public function setLBInfo( $name, $value = null ) { | ||
| 77 | |||
| 78 | 	public function implicitGroupby() { | ||
| 81 | |||
| 82 | 	public function implicitOrderby() { | ||
| 85 | |||
| 86 | 	public function lastQuery() { | ||
| 89 | |||
| 90 | 	public function doneWrites() { | ||
| 93 | |||
| 94 | 	public function lastDoneWrites() { | ||
| 97 | |||
| 98 | 	public function writesPending() { | ||
| 101 | |||
| 102 | 	public function writesOrCallbacksPending() { | ||
| 105 | |||
| 106 | 	public function pendingWriteQueryDuration() { | ||
| 109 | |||
| 110 | 	public function pendingWriteCallers() { | ||
| 113 | |||
| 114 | 	public function isOpen() { | ||
| 117 | |||
| 118 | 	public function setFlag( $flag ) { | ||
| 121 | |||
| 122 | 	public function clearFlag( $flag ) { | ||
| 125 | |||
| 126 | 	public function getFlag( $flag ) { | ||
| 129 | |||
| 130 | 	public function getProperty( $name ) { | ||
| 133 | |||
| 134 | 	public function getWikiID() { | ||
| 137 | |||
| 138 | 	public function getType() { | ||
| 141 | |||
| 142 | 	public function open( $server, $user, $password, $dbName ) { | ||
| 145 | |||
| 146 | 	public function fetchObject( $res ) { | ||
| 149 | |||
| 150 | 	public function fetchRow( $res ) { | ||
| 153 | |||
| 154 | 	public function numRows( $res ) { | ||
| 157 | |||
| 158 | 	public function numFields( $res ) { | ||
| 161 | |||
| 162 | 	public function fieldName( $res, $n ) { | ||
| 165 | |||
| 166 | 	public function insertId() { | ||
| 169 | |||
| 170 | 	public function dataSeek( $res, $row ) { | ||
| 173 | |||
| 174 | 	public function lastErrno() { | ||
| 177 | |||
| 178 | 	public function lastError() { | ||
| 181 | |||
| 182 | 	public function fieldInfo( $table, $field ) { | ||
| 185 | |||
| 186 | 	public function affectedRows() { | ||
| 189 | |||
| 190 | 	public function getSoftwareLink() { | ||
| 193 | |||
| 194 | 	public function getServerVersion() { | ||
| 197 | |||
| 198 | 	public function close() { | ||
| 201 | |||
| 202 | 	public function reportConnectionError( $error = 'Unknown error' ) { | ||
| 205 | |||
| 206 | 	public function query( $sql, $fname = __METHOD__, $tempIgnore = false ) { | ||
| 209 | |||
| 210 | 	public function reportQueryError( $error, $errno, $sql, $fname, $tempIgnore = false ) { | ||
| 213 | |||
| 214 | 	public function freeResult( $res ) { | ||
| 217 | |||
| 218 | public function selectField( | ||
| 223 | |||
| 224 | public function selectFieldValues( | ||
| 229 | |||
| 230 | public function select( | ||
| 236 | |||
| 237 | public function selectSQLText( | ||
| 243 | |||
| 244 | public function selectRow( | ||
| 250 | |||
| 251 | public function estimateRowCount( | ||
| 256 | |||
| 257 | public function selectRowCount( | ||
| 262 | |||
| 263 | 	public function fieldExists( $table, $field, $fname = __METHOD__ ) { | ||
| 266 | |||
| 267 | 	public function indexExists( $table, $index, $fname = __METHOD__ ) { | ||
| 270 | |||
| 271 | 	public function tableExists( $table, $fname = __METHOD__ ) { | ||
| 274 | |||
| 275 | 	public function indexUnique( $table, $index ) { | ||
| 278 | |||
| 279 | 	public function insert( $table, $a, $fname = __METHOD__, $options = [] ) { | ||
| 282 | |||
| 283 | 	public function update( $table, $values, $conds, $fname = __METHOD__, $options = [] ) { | ||
| 286 | |||
| 287 | 	public function makeList( $a, $mode = LIST_COMMA ) { | ||
| 290 | |||
| 291 | 	public function makeWhereFrom2d( $data, $baseKey, $subKey ) { | ||
| 294 | |||
| 295 | 	public function bitNot( $field ) { | ||
| 298 | |||
| 299 | 	public function bitAnd( $fieldLeft, $fieldRight ) { | ||
| 302 | |||
| 303 | 	public function bitOr( $fieldLeft, $fieldRight ) { | ||
| 306 | |||
| 307 | 	public function buildConcat( $stringList ) { | ||
| 310 | |||
| 311 | public function buildGroupConcatField( | ||
| 316 | |||
| 317 | 	public function selectDB( $db ) { | ||
| 320 | |||
| 321 | 	public function getDBname() { | ||
| 324 | |||
| 325 | 	public function getServer() { | ||
| 328 | |||
| 329 | 	public function addQuotes( $s ) { | ||
| 332 | |||
| 333 | 	public function buildLike() { | ||
| 336 | |||
| 337 | 	public function anyChar() { | ||
| 340 | |||
| 341 | 	public function anyString() { | ||
| 344 | |||
| 345 | 	public function nextSequenceValue( $seqName ) { | ||
| 348 | |||
| 349 | 	public function replace( $table, $uniqueIndexes, $rows, $fname = __METHOD__ ) { | ||
| 352 | |||
| 353 | public function upsert( | ||
| 358 | |||
| 359 | public function deleteJoin( | ||
| 364 | |||
| 365 | 	public function delete( $table, $conds, $fname = __METHOD__ ) { | ||
| 368 | |||
| 369 | public function insertSelect( | ||
| 375 | |||
| 376 | 	public function unionSupportsOrderAndLimit() { | ||
| 379 | |||
| 380 | 	public function unionQueries( $sqls, $all ) { | ||
| 383 | |||
| 384 | 	public function conditional( $cond, $trueVal, $falseVal ) { | ||
| 387 | |||
| 388 | 	public function strreplace( $orig, $old, $new ) { | ||
| 391 | |||
| 392 | 	public function getServerUptime() { | ||
| 395 | |||
| 396 | 	public function wasDeadlock() { | ||
| 399 | |||
| 400 | 	public function wasLockTimeout() { | ||
| 403 | |||
| 404 | 	public function wasErrorReissuable() { | ||
| 407 | |||
| 408 | 	public function wasReadOnlyError() { | ||
| 411 | |||
| 412 | 	public function masterPosWait( DBMasterPos $pos, $timeout ) { | ||
| 415 | |||
| 416 | 	public function getSlavePos() { | ||
| 419 | |||
| 420 | 	public function getMasterPos() { | ||
| 423 | |||
| 424 | 	public function serverIsReadOnly() { | ||
| 427 | |||
| 428 | 	public function onTransactionResolution( callable $callback ) { | ||
| 431 | |||
| 432 | 	public function onTransactionIdle( callable $callback ) { | ||
| 435 | |||
| 436 | 	public function onTransactionPreCommitOrIdle( callable $callback ) { | ||
| 439 | |||
| 440 | 	public function startAtomic( $fname = __METHOD__ ) { | ||
| 443 | |||
| 444 | 	public function endAtomic( $fname = __METHOD__ ) { | ||
| 447 | |||
| 448 | 	public function doAtomicSection( $fname, callable $callback ) { | ||
| 451 | |||
| 452 | 	public function begin( $fname = __METHOD__, $mode = IDatabase::TRANSACTION_EXPLICIT ) { | ||
| 455 | |||
| 456 | 	public function commit( $fname = __METHOD__, $flush = '' ) { | ||
| 459 | |||
| 460 | 	public function rollback( $fname = __METHOD__, $flush = '' ) { | ||
| 463 | |||
| 464 | 	public function listTables( $prefix = null, $fname = __METHOD__ ) { | ||
| 467 | |||
| 468 | 	public function timestamp( $ts = 0 ) { | ||
| 471 | |||
| 472 | 	public function timestampOrNull( $ts = null ) { | ||
| 475 | |||
| 476 | 	public function ping() { | ||
| 479 | |||
| 480 | 	public function getLag() { | ||
| 483 | |||
| 484 | 	public function getSessionLagStatus() { | ||
| 487 | |||
| 488 | 	public function maxListLen() { | ||
| 491 | |||
| 492 | 	public function encodeBlob( $b ) { | ||
| 495 | |||
| 496 | 	public function decodeBlob( $b ) { | ||
| 499 | |||
| 500 | 	public function setSessionOptions( array $options ) { | ||
| 503 | |||
| 504 | 	public function setSchemaVars( $vars ) { | ||
| 507 | |||
| 508 | 	public function lockIsFree( $lockName, $method ) { | ||
| 511 | |||
| 512 | 	public function lock( $lockName, $method, $timeout = 5 ) { | ||
| 515 | |||
| 516 | 	public function unlock( $lockName, $method ) { | ||
| 519 | |||
| 520 | 	public function getScopedLockAndFlush( $lockKey, $fname, $timeout ) { | ||
| 523 | |||
| 524 | 	public function namedLocksEnqueue() { | ||
| 527 | |||
| 528 | 	public function getInfinity() { | ||
| 531 | |||
| 532 | 	public function encodeExpiry( $expiry ) { | ||
| 535 | |||
| 536 | 	public function decodeExpiry( $expiry, $format = TS_MW ) { | ||
| 539 | |||
| 540 | 	public function setBigSelects( $value = true ) { | ||
| 543 | |||
| 544 | 	public function isReadOnly() { | ||
| 547 | |||
| 548 | /** | ||
| 549 | * Clean up the connection when out of scope | ||
| 550 | */ | ||
| 551 | 	function __destruct() { | ||
| 556 | } | ||
| 557 |