HTMLTitleTextField::validate() - Code Metrics - Inspection of "Daily Inspection: Merge "Tell users that js/css su..." - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (d7c4e6)

unknown

created 2016-08-23 17:31 UTC

HTMLTitleTextField::validate() C

↳ Parent: HTMLTitleTextField

Complexity

Conditions	12
Paths	17

Size

Total Lines	41
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	12
eloc	25
nc	17
nop	2
dl	0
loc	41
rs	5.1612
c	0
b	0
f	0

How to fix Complexity

<?php

use MediaWiki\Widget\TitleInputWidget;

/**
 * Implements a text input field for page titles.
 * Automatically does validation that the title is valid,
 * as well as autocompletion if using the OOUI display format.
 *
 * Note: Forms using GET requests will need to make sure the title value is not
 * an empty string.
 *
 * Optional parameters:
 * 'namespace' - Namespace the page must be in
 * 'relative' - If true and 'namespace' given, strip/add the namespace from/to the title as needed
 * 'creatable' - Whether to validate the title is creatable (not a special page)
 * 'exists' - Whether to validate that the title already exists
 *
 * @since 1.26
 */
class HTMLTitleTextField extends HTMLTextField {
	public function __construct( $params ) {
		$params += [
			'namespace' => false,
			'relative' => false,
			'creatable' => false,
			'exists' => false,
		];

		parent::__construct( $params );
	}

	public function validate( $value, $alldata ) {
		if ( $this->mParent->getMethod() === 'get' && $value === '' ) {
			// If the form is a GET form and has no value, assume it hasn't been
			// submitted yet, and skip validation
			return parent::validate( $value, $alldata );
		}
		try {
			if ( !$this->mParams['relative'] ) {
				$title = Title::newFromTextThrow( $value );
			} else {
				// Can't use Title::makeTitleSafe(), because it doesn't throw useful exceptions
				global $wgContLang;
				$namespaceName = $wgContLang->getNsText( $this->mParams['namespace'] );
				$title = Title::newFromTextThrow( $namespaceName . ':' . $value );
			}
		} catch ( MalformedTitleException $e ) {
			$msg = $this->msg( $e->getErrorMessage() );
			$params = $e->getErrorMessageParameters();
			if ( $params ) {
				$msg->params( $params );
			}
			return $msg->parse();
		}

		$text = $title->getPrefixedText();
		if ( $this->mParams['namespace'] !== false &&
			!$title->inNamespace( $this->mParams['namespace'] )
		) {
			return $this->msg( 'htmlform-title-badnamespace', $this->mParams['namespace'], $text )->parse();
		}

		if ( $this->mParams['creatable'] && !$title->canExist() ) {
			return $this->msg( 'htmlform-title-not-creatable', $text )->escaped();
		}

		if ( $this->mParams['exists'] && !$title->exists() ) {
			return $this->msg( 'htmlform-title-not-exists', $text )->parse();
		}

		return parent::validate( $value, $alldata );
	}

	protected function getInputWidget( $params ) {
		if ( $this->mParams['namespace'] !== false ) {
			$params['namespace'] = $this->mParams['namespace'];
		}
		$params['relative'] = $this->mParams['relative'];
		return new TitleInputWidget( $params );
	}

	protected function shouldInfuseOOUI() {
		return true;
	}

	protected function getOOUIModules() {
		// FIXME: TitleInputWidget should be in its own module
		return [ 'mediawiki.widgets' ];
	}

	public function getInputHtml( $value ) {
		// add mw-searchInput class to enable search suggestions for non-OOUI, too
		$this->mClass .= 'mw-searchInput';

		// return the HTMLTextField html
		return parent::getInputHTML( $value );
	}

	protected function getDataAttribs() {
		return [
			'data-mw-searchsuggest' => FormatJson::encode( [
				'wrapAsLink' => false,
			] ),
		];
	}
}


1			<?php
2
3			use MediaWiki\Widget\TitleInputWidget;
4
5			/**
6			* Implements a text input field for page titles.
7			* Automatically does validation that the title is valid,
8			* as well as autocompletion if using the OOUI display format.
9			*
10			* Note: Forms using GET requests will need to make sure the title value is not
11			* an empty string.
12			*
13			* Optional parameters:
14			* 'namespace' - Namespace the page must be in
15			* 'relative' - If true and 'namespace' given, strip/add the namespace from/to the title as needed
16			* 'creatable' - Whether to validate the title is creatable (not a special page)
17			* 'exists' - Whether to validate that the title already exists
18			*
19			* @since 1.26
20			*/
21			class HTMLTitleTextField extends HTMLTextField {
22			public function __construct( $params ) {
23			$params += [
24			'namespace' => false,
25			'relative' => false,
26			'creatable' => false,
27			'exists' => false,
28			];
29
30			parent::__construct( $params );
31			}
32
33			public function validate( $value, $alldata ) {
34			if ( $this->mParent->getMethod() === 'get' && $value === '' ) {
35			// If the form is a GET form and has no value, assume it hasn't been
36			// submitted yet, and skip validation
37			return parent::validate( $value, $alldata );
38			}
39			try {
40			if ( !$this->mParams['relative'] ) {
41			$title = Title::newFromTextThrow( $value );
42			} else {
43			// Can't use Title::makeTitleSafe(), because it doesn't throw useful exceptions
44			global $wgContLang;
45			$namespaceName = $wgContLang->getNsText( $this->mParams['namespace'] );
46			$title = Title::newFromTextThrow( $namespaceName . ':' . $value );
47			}
48			} catch ( MalformedTitleException $e ) {
49			$msg = $this->msg( $e->getErrorMessage() );
50			$params = $e->getErrorMessageParameters();
51			if ( $params ) {
52			$msg->params( $params );
53			}
54			return $msg->parse();
55			}
56
57			$text = $title->getPrefixedText();
58			if ( $this->mParams['namespace'] !== false &&
59			!$title->inNamespace( $this->mParams['namespace'] )
60			) {
61			return $this->msg( 'htmlform-title-badnamespace', $this->mParams['namespace'], $text )->parse();
62			}
63
64			if ( $this->mParams['creatable'] && !$title->canExist() ) {
65			return $this->msg( 'htmlform-title-not-creatable', $text )->escaped();
66			}
67
68			if ( $this->mParams['exists'] && !$title->exists() ) {
69			return $this->msg( 'htmlform-title-not-exists', $text )->parse();
70			}
71
72			return parent::validate( $value, $alldata );
73			}
74
75			protected function getInputWidget( $params ) {
76			if ( $this->mParams['namespace'] !== false ) {
77			$params['namespace'] = $this->mParams['namespace'];
78			}
79			$params['relative'] = $this->mParams['relative'];
80			return new TitleInputWidget( $params );
81			}
82
83			protected function shouldInfuseOOUI() {
84			return true;
85			}
86
87			protected function getOOUIModules() {
88			// FIXME: TitleInputWidget should be in its own module
89			return [ 'mediawiki.widgets' ];
90			}
91
92			public function getInputHtml( $value ) {
93			// add mw-searchInput class to enable search suggestions for non-OOUI, too
94			$this->mClass .= 'mw-searchInput';
95
96			// return the HTMLTextField html
97			return parent::getInputHTML( $value );
98			}
99
100			protected function getDataAttribs() {
101			return [
102			'data-mw-searchsuggest' => FormatJson::encode( [
103			'wrapAsLink' => false,
104			] ),
105			];
106			}
107			}
108

wikimedia / mediawiki

Branch — master (d7c4e6)

HTMLTitleTextField::validate() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like