@@ -134,7 +134,8 @@ discard block |
||
134 | 134 | |
135 | 135 | |
136 | 136 | /** |
137 | - * @param string $fname the filename |
|
137 | + * @param string $xml |
|
138 | + * @param boolean $isFile |
|
138 | 139 | */ |
139 | 140 | private function validateFromInput( $xml, $isFile ) { |
140 | 141 | $reader = new XMLReader(); |
@@ -175,6 +176,9 @@ discard block |
||
175 | 176 | $this->wellFormed = false; |
176 | 177 | } |
177 | 178 | |
179 | + /** |
|
180 | + * @param XMLReader $reader |
|
181 | + */ |
|
178 | 182 | private function validate( $reader ) { |
179 | 183 | |
180 | 184 | // First, move through anything that isn't an element, and |
@@ -286,7 +290,7 @@ discard block |
||
286 | 290 | } |
287 | 291 | |
288 | 292 | /** |
289 | - * @param $name |
|
293 | + * @param string $name |
|
290 | 294 | * @param $attribs |
291 | 295 | */ |
292 | 296 | private function elementOpen( $name, $attribs ) { |
@@ -94,7 +94,7 @@ |
||
94 | 94 | /** |
95 | 95 | * @param array $list |
96 | 96 | * @param array $path |
97 | - * @param mixed $item |
|
97 | + * @param License $item |
|
98 | 98 | */ |
99 | 99 | protected function stackItem( &$list, $path, $item ) { |
100 | 100 | $position =& $list; |
@@ -413,8 +413,8 @@ discard block |
||
413 | 413 | |
414 | 414 | /** |
415 | 415 | * @param stdClass $row Row |
416 | - * @param string|array $type |
|
417 | - * @param string|array $action |
|
416 | + * @param string[] $type |
|
417 | + * @param string $action |
|
418 | 418 | * @param string $right |
419 | 419 | * @return bool |
420 | 420 | */ |
@@ -649,7 +649,7 @@ discard block |
||
649 | 649 | * @param IDatabase $db |
650 | 650 | * @param string $audience Public/user |
651 | 651 | * @param User $user User to check, or null to use $wgUser |
652 | - * @return string|bool String on success, false on failure. |
|
652 | + * @return string|false String on success, false on failure. |
|
653 | 653 | */ |
654 | 654 | public static function getExcludeClause( $db, $audience = 'public', User $user = null ) { |
655 | 655 | global $wgLogRestrictions; |
@@ -423,7 +423,7 @@ |
||
423 | 423 | * Returns a sentence describing the log action. Usually |
424 | 424 | * a Message object is returned, but old style log types |
425 | 425 | * and entries might return pre-escaped HTML string. |
426 | - * @return Message|string Pre-escaped HTML |
|
426 | + * @return Message Pre-escaped HTML |
|
427 | 427 | */ |
428 | 428 | protected function getActionMessage() { |
429 | 429 | $message = $this->msg( $this->getMessageKey() ); |
@@ -474,7 +474,7 @@ |
||
474 | 474 | * |
475 | 475 | * @param User $watchingUser |
476 | 476 | * @param string $source |
477 | - * @return bool |
|
477 | + * @return Status |
|
478 | 478 | * @private |
479 | 479 | */ |
480 | 480 | function sendPersonalised( $watchingUser, $source ) { |
@@ -255,7 +255,7 @@ discard block |
||
255 | 255 | * Get metadata, unserializing it if neccessary. |
256 | 256 | * |
257 | 257 | * @param File $file The DjVu file in question |
258 | - * @return string XML metadata as a string. |
|
258 | + * @return boolean XML metadata as a string. |
|
259 | 259 | * @throws MWException |
260 | 260 | */ |
261 | 261 | private function getUnserializedMetadata( File $file ) { |
@@ -371,6 +371,10 @@ discard block |
||
371 | 371 | return 'djvuxml'; |
372 | 372 | } |
373 | 373 | |
374 | + /** |
|
375 | + * @param File $image |
|
376 | + * @param boolean $metadata |
|
377 | + */ |
|
374 | 378 | function isMetadataValid( $image, $metadata ) { |
375 | 379 | return !empty( $metadata ) && $metadata != serialize( array() ); |
376 | 380 | } |
@@ -94,6 +94,11 @@ discard block |
||
94 | 94 | fclose( $file ); |
95 | 95 | } |
96 | 96 | |
97 | + /** |
|
98 | + * @param resource $file |
|
99 | + * @param string $length |
|
100 | + * @param integer $indent |
|
101 | + */ |
|
97 | 102 | private function dumpForm( $file, $length, $indent ) { |
98 | 103 | $start = ftell( $file ); |
99 | 104 | $secondary = fread( $file, 4 ); |
@@ -187,6 +192,10 @@ discard block |
||
187 | 192 | } |
188 | 193 | } |
189 | 194 | |
195 | + /** |
|
196 | + * @param resource $file |
|
197 | + * @param string $formLength |
|
198 | + */ |
|
190 | 199 | private function getMultiPageInfo( $file, $formLength ) { |
191 | 200 | // For now, we'll just look for the first page in the file |
192 | 201 | // and report its information, hoping others are the same size. |
@@ -390,6 +399,9 @@ discard block |
||
390 | 399 | return $xml; |
391 | 400 | } |
392 | 401 | |
402 | + /** |
|
403 | + * @param string $line |
|
404 | + */ |
|
393 | 405 | function parseFormDjvu( $line, &$xml ) { |
394 | 406 | $parentLevel = strspn( $line, ' ' ); |
395 | 407 | $line = strtok( "\n" ); |
@@ -82,7 +82,7 @@ |
||
82 | 82 | |
83 | 83 | /** |
84 | 84 | * @param File $image |
85 | - * @param array $metadata |
|
85 | + * @param boolean $metadata |
|
86 | 86 | * @return bool|int |
87 | 87 | */ |
88 | 88 | function isMetadataValid( $image, $metadata ) { |
@@ -1230,8 +1230,8 @@ discard block |
||
1230 | 1230 | * numbers, joins arrays of numbers with commas. |
1231 | 1231 | * |
1232 | 1232 | * @param mixed $num The value to format |
1233 | - * @param float|int|bool $round Digits to round to or false. |
|
1234 | - * @return mixed A floating point number or whatever we were fed |
|
1233 | + * @param integer $round Digits to round to or false. |
|
1234 | + * @return string|null A floating point number or whatever we were fed |
|
1235 | 1235 | */ |
1236 | 1236 | private function formatNum( $num, $round = false ) { |
1237 | 1237 | $m = array(); |
@@ -1396,7 +1396,7 @@ discard block |
||
1396 | 1396 | * |
1397 | 1397 | * @param int $coord Degrees, minutes and seconds |
1398 | 1398 | * @param string $type Latitude or longitude (for if its a NWS or E) |
1399 | - * @return mixed A floating point number or whatever we were fed |
|
1399 | + * @return string A floating point number or whatever we were fed |
|
1400 | 1400 | */ |
1401 | 1401 | private function formatCoords( $coord, $type ) { |
1402 | 1402 | $ref = ''; |