wikimedia / mediawiki

includes/libs/objectcache/MemcachedClient.php

Doc Comments +7 added lines, -7 removed lines

@@ -309,7 +309,7 @@ 
 	 * @param string $key Key to decrease
 	 * @param int $amt (optional) amount to decrease
 	 *
-	 * @return mixed False on failure, value on success
+	 * @return null|string False on failure, value on success
 	 */
 	public function decr( $key, $amt = 1 ) {
 		return $this->_incrdecr( 'decr', $key, $amt );
@@ -548,7 +548,7 @@ 
 	 * @param string $key Key to increment
 	 * @param int $amt (optional) amount to increment
 	 *
-	 * @return int|null Null if the key does not exist yet (this does NOT
+	 * @return null|string Null if the key does not exist yet (this does NOT
 	 * create new mappings if the key does not exist). If the key does
 	 * exist, this returns the new value for that key.
 	 */
@@ -872,10 +872,10 @@ 
 	 * Perform increment/decriment on $key
 	 *
 	 * @param string $cmd Command to perform
-	 * @param string|array $key Key to perform it on
+	 * @param string $key Key to perform it on
 	 * @param int $amt Amount to adjust
 	 *
-	 * @return int New value of $key
+	 * @return null|string New value of $key
 	 * @access private
 	 */
 	function _incrdecr( $cmd, $key, $amt = 1 ) {
@@ -915,7 +915,7 @@ 
 	 * @param Resource $sock Socket to read from
 	 * @param array $ret returned values
 	 * @param float $casToken [optional]
-	 * @return bool True for success, false for failure
+	 * @return boolean|null True for success, false for failure
 	 *
 	 * @access private
 	 */
@@ -1183,7 +1183,7 @@ 
 	 *
 	 * @param Resource $sock The socket
 	 * @param int $len The number of bytes to read
-	 * @return string|bool The string on success, false on failure.
+	 * @return false|string The string on success, false on failure.
 	 */
 	function _fread( $sock, $len ) {
 		$buf = '';
@@ -1214,7 +1214,7 @@ 
 	 * The \r\n line ending is stripped from the response.
 	 *
 	 * @param Resource $sock The socket
-	 * @return string|bool The string on success, false on failure
+	 * @return false|string The string on success, false on failure
 	 */
 	function _fgets( $sock ) {
 		$result = fgets( $sock );

includes/libs/replacers/DoubleReplacer.php

Doc Comments +2 added lines, -2 removed lines

@@ -23,8 +23,8 @@
  */
 class DoubleReplacer extends Replacer {
 	/**
-	 * @param mixed $from
-	 * @param mixed $to
+	 * @param string $from
+	 * @param string $to
 	 * @param int $index
 	 */
 	public function __construct( $from, $to, $index = 0 ) {

includes/libs/XmlTypeCheck.php

Doc Comments +6 added lines, -2 removed lines

@@ -134,7 +134,8 @@ 
 
 
 	/**
-	 * @param string $fname the filename
+	 * @param string $xml
+	 * @param boolean $isFile
 	 */
 	private function validateFromInput( $xml, $isFile ) {
 		$reader = new XMLReader();
@@ -175,6 +176,9 @@ 
 		$this->wellFormed = false;
 	}
 
+	/**
+	 * @param XMLReader $reader
+	 */
 	private function validate( $reader ) {
 
 		// First, move through anything that isn't an element, and
@@ -286,7 +290,7 @@ 
 	}
 
 	/**
-	 * @param $name
+	 * @param string $name
 	 * @param $attribs
 	 */
 	private function elementOpen( $name, $attribs ) {

includes/Licenses.php

Doc Comments +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
 	/**
 	 * @param array $list
 	 * @param array $path
-	 * @param mixed $item
+	 * @param License $item
 	 */
 	protected function stackItem( &$list, $path, $item ) {
 		$position =& $list;

includes/logging/LogEventsList.php

Doc Comments +3 added lines, -3 removed lines

@@ -413,8 +413,8 @@ 
 
 	/**
 	 * @param stdClass $row Row
-	 * @param string|array $type
-	 * @param string|array $action
+	 * @param string[] $type
+	 * @param string $action
 	 * @param string $right
 	 * @return bool
 	 */
@@ -649,7 +649,7 @@ 
 	 * @param IDatabase $db
 	 * @param string $audience Public/user
 	 * @param User $user User to check, or null to use $wgUser
-	 * @return string|bool String on success, false on failure.
+	 * @return string|false String on success, false on failure.
 	 */
 	public static function getExcludeClause( $db, $audience = 'public', User $user = null ) {
 		global $wgLogRestrictions;

includes/mail/EmailNotification.php

Doc Comments +1 added lines, -1 removed lines

@@ -474,7 +474,7 @@
 	 *
 	 * @param User $watchingUser
 	 * @param string $source
-	 * @return bool
+	 * @return Status
 	 * @private
 	 */
 	function sendPersonalised( $watchingUser, $source ) {

includes/media/FormatMetadata.php

Doc Comments +3 added lines, -3 removed lines

@@ -1230,8 +1230,8 @@ 
 	 * numbers, joins arrays of numbers with commas.
 	 *
 	 * @param mixed $num The value to format
-	 * @param float|int|bool $round Digits to round to or false.
-	 * @return mixed A floating point number or whatever we were fed
+	 * @param integer $round Digits to round to or false.
+	 * @return string|null A floating point number or whatever we were fed
 	 */
 	private function formatNum( $num, $round = false ) {
 		$m = array();
@@ -1396,7 +1396,7 @@ 
 	 *
 	 * @param int $coord Degrees, minutes and seconds
 	 * @param string $type Latitude or longitude (for if its a NWS or E)
-	 * @return mixed A floating point number or whatever we were fed
+	 * @return string A floating point number or whatever we were fed
 	 */
 	private function formatCoords( $coord, $type ) {
 		$ref = '';

includes/media/JpegMetadataExtractor.php

Doc Comments +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
 	 * and those can't extract xmp on files containing both exif and xmp data
 	 *
 	 * @param string $filename Name of jpeg file
-	 * @return array Array of interesting segments.
+	 * @return string Array of interesting segments.
 	 * @throws MWException If given invalid file.
 	 */
 	static function segmentSplitter( $filename ) {

includes/media/SVGMetadataExtractor.php

Doc Comments +5 added lines, -1 removed lines

@@ -29,6 +29,10 @@ 
  * @ingroup Media
  */
 class SVGMetadataExtractor {
+
+	/**
+	 * @param string $filename
+	 */
 	static function getMetadata( $filename ) {
 		$svg = new SVGReader( $filename );
 
@@ -372,7 +376,7 @@ 
 	 * http://www.w3.org/TR/SVG11/coords.html#UnitIdentifiers
 	 *
 	 * @param string $length CSS/SVG length.
-	 * @param float|int $viewportSize Optional scale for percentage units...
+	 * @param integer $viewportSize Optional scale for percentage units...
 	 * @return float Length in pixels
 	 */
 	static function scaleSVGUnit( $length, $viewportSize = 512 ) {