wikimedia / mediawiki

includes/jobqueue/jobs/ThumbnailRenderJob.php

Doc Comments +4 added lines

@@ -77,6 +77,10 @@
 		}
 	}
 
+	/**
+	 * @param File $file
+	 * @param string $thumbUrl
+	 */
 	protected function hitThumbUrl( $file, $transformParams, &$thumbUrl ) {
 		global $wgUploadThumbnailRenderHttpCustomHost, $wgUploadThumbnailRenderHttpCustomDomain;
 

includes/libs/ArrayUtils.php

Doc Comments -1 removed lines

@@ -151,7 +151,6 @@
 	 * @since 1.23
 	 *
 	 * @param array $array1 The array to compare from
-	 * @param array $array2,... More arrays to compare against
 	 * @return array An array containing all the values from array1
 	 *               that are not present in any of the other arrays.
 	 */

includes/libs/Cookie.php

Doc Comments +4 added lines

@@ -33,6 +33,10 @@
 	// TO IMPLEMENT? protected $version
 	// TO IMPLEMENT? protected $comment
 
+	/**
+	 * @param string $name
+	 * @param string $value
+	 */
 	function __construct( $name, $value, $attr ) {
 		$this->name = $name;
 		$this->set( $value, $attr );

includes/libs/DeferredStringifier.php

Doc Comments -1 removed lines

@@ -35,7 +35,6 @@
 
 	/**
 	 * @param callable $callback Callback that gets called by __toString
-	 * @param mixed $param,... Parameters to the callback
 	 */
 	public function __construct( $callback /*...*/ ) {
 		$this->params = func_get_args();

includes/libs/GenericArrayObject.php

Doc Comments +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
 	 *
 	 * @since 1.20
 	 *
-	 * @param null|array $input
+	 * @param Site[] $input
 	 * @param int $flags
 	 * @param string $iterator_class
 	 */

includes/libs/JavaScriptMinifier.php

Doc Comments +5 added lines

@@ -608,6 +608,11 @@
 		return $out;
 	}
 
+	/**
+	 * @param string $fullJavascript
+	 * @param integer $position
+	 * @param string $errorMsg
+	 */
 	static function parseError($fullJavascript, $position, $errorMsg) {
 		// TODO: Handle the error: trigger_error, throw exception, return false...
 		return false;

includes/libs/jsminplus.php

Doc Comments +38 added lines

@@ -207,6 +207,9 @@ 
 		return $instance->min($js, $filename);
 	}
 
+	/**
+	 * @param string $filename
+	 */
 	private function min($js, $filename)
 	{
 		try
@@ -222,6 +225,9 @@ 
 		return false;
 	}
 
+	/**
+	 * @param JSNode $n
+	 */
 	public function parseTree($n, $noBlockGrouping = false)
 	{
 		$s = '';
@@ -660,6 +666,9 @@ 
 		return $s;
 	}
 
+	/**
+	 * @param string $string
+	 */
 	private function isValidIdentifier($string)
 	{
 		return preg_match('/^[a-zA-Z_][a-zA-Z0-9_]*$/', $string) && !in_array($string, $this->reserved);
@@ -724,12 +733,18 @@ 
 		TOKEN_CONDCOMMENT_START => 1, TOKEN_CONDCOMMENT_END => 1
 	);
 
+	/**
+	 * @param JSMinPlus $minifier
+	 */
 	public function __construct($minifier=null)
 	{
 		$this->minifier = $minifier;
 		$this->t = new JSTokenizer();
 	}
 
+	/**
+	 * @param integer $l
+	 */
 	public function parse($s, $f, $l)
 	{
 		// initialize tokenizer
@@ -743,6 +758,9 @@ 
 		return $n;
 	}
 
+	/**
+	 * @param JSCompilerContext $x
+	 */
 	private function Script($x)
 	{
 		$n = $this->Statements($x);
@@ -1106,6 +1124,10 @@ 
 		return $n;
 	}
 
+	/**
+	 * @param boolean $requireName
+	 * @param integer $functionForm
+	 */
 	private function FunctionDefinition($x, $requireName, $functionForm)
 	{
 		$f = new JSNode($this->t);
@@ -1572,6 +1594,10 @@ 
 	}
 
 	// Statement stack and nested statement handler.
+
+	/**
+	 * @param JSNode $node
+	 */
 	private function nest($x, $node, $end = false)
 	{
 		array_push($x->stmtStack, $node);
@@ -1636,6 +1662,9 @@ 
 	public $funDecls = array();
 	public $varDecls = array();
 
+	/**
+	 * @param boolean $inFunction
+	 */
 	public function __construct($inFunction)
 	{
 		$this->inFunction = $inFunction;
@@ -1654,6 +1683,9 @@ 
 	public $funDecls = array();
 	public $varDecls = array();
 
+	/**
+	 * @param JSTokenizer $t
+	 */
 	public function __construct($t, $type=0)
 	{
 		if ($token = $t->currentToken())
@@ -1765,6 +1797,9 @@ 
 		$this->scanOperand = true;
 	}
 
+	/**
+	 * @param integer|null $chunksize
+	 */
 	public function getInput($chunksize)
 	{
 		if ($chunksize)
@@ -2112,6 +2147,9 @@ 
 		$this->tokenIndex = ($this->tokenIndex - 1) & 3;
 	}
 
+	/**
+	 * @param string $m
+	 */
 	public function newSyntaxError($m)
 	{
 		return new Exception('Parse error: ' . $m . ' in file \'' . $this->filename . '\' on line ' . $this->lineno);

includes/libs/MemoizedCallable.php

Doc Comments +1 added lines

@@ -74,6 +74,7 @@
 	 *
 	 * @param string $key
 	 * @param bool &$success
+	 * @param boolean $success
 	 */
 	protected function fetchResult( $key, &$success ) {
 		$success = false;

includes/libs/objectcache/MemcachedClient.php

Doc Comments +7 added lines, -7 removed lines

@@ -309,7 +309,7 @@ 
 	 * @param string $key Key to decrease
 	 * @param int $amt (optional) amount to decrease
 	 *
-	 * @return mixed False on failure, value on success
+	 * @return null|string False on failure, value on success
 	 */
 	public function decr( $key, $amt = 1 ) {
 		return $this->_incrdecr( 'decr', $key, $amt );
@@ -548,7 +548,7 @@ 
 	 * @param string $key Key to increment
 	 * @param int $amt (optional) amount to increment
 	 *
-	 * @return int|null Null if the key does not exist yet (this does NOT
+	 * @return null|string Null if the key does not exist yet (this does NOT
 	 * create new mappings if the key does not exist). If the key does
 	 * exist, this returns the new value for that key.
 	 */
@@ -872,10 +872,10 @@ 
 	 * Perform increment/decriment on $key
 	 *
 	 * @param string $cmd Command to perform
-	 * @param string|array $key Key to perform it on
+	 * @param string $key Key to perform it on
 	 * @param int $amt Amount to adjust
 	 *
-	 * @return int New value of $key
+	 * @return null|string New value of $key
 	 * @access private
 	 */
 	function _incrdecr( $cmd, $key, $amt = 1 ) {
@@ -915,7 +915,7 @@ 
 	 * @param Resource $sock Socket to read from
 	 * @param array $ret returned values
 	 * @param float $casToken [optional]
-	 * @return bool True for success, false for failure
+	 * @return boolean|null True for success, false for failure
 	 *
 	 * @access private
 	 */
@@ -1183,7 +1183,7 @@ 
 	 *
 	 * @param Resource $sock The socket
 	 * @param int $len The number of bytes to read
-	 * @return string|bool The string on success, false on failure.
+	 * @return false|string The string on success, false on failure.
 	 */
 	function _fread( $sock, $len ) {
 		$buf = '';
@@ -1214,7 +1214,7 @@ 
 	 * The \r\n line ending is stripped from the response.
 	 *
 	 * @param Resource $sock The socket
-	 * @return string|bool The string on success, false on failure
+	 * @return false|string The string on success, false on failure
 	 */
 	function _fgets( $sock ) {
 		$result = fgets( $sock );