@@ -31,7 +31,7 @@ |
||
31 | 31 | /** |
32 | 32 | * @param Language $langobj |
33 | 33 | * @param string $maincode |
34 | - * @param array $variants |
|
34 | + * @param string[] $variants |
|
35 | 35 | * @param array $variantfallbacks |
36 | 36 | * @param array $flags |
37 | 37 | * @param array $manualLevel |
@@ -46,7 +46,7 @@ |
||
46 | 46 | |
47 | 47 | /** |
48 | 48 | * @param string $string |
49 | - * @return mixed|string |
|
49 | + * @return string |
|
50 | 50 | */ |
51 | 51 | function lcfirst( $string ) { |
52 | 52 | if ( strlen( $string ) && $string[0] == 'I' ) { |
@@ -121,6 +121,9 @@ |
||
121 | 121 | } |
122 | 122 | } |
123 | 123 | |
124 | + /** |
|
125 | + * @param IDatabase $dbw |
|
126 | + */ |
|
124 | 127 | public function doSpecialPageCacheUpdates( $dbw ) { |
125 | 128 | global $wgSpecialPageCacheUpdates; |
126 | 129 |
@@ -92,7 +92,7 @@ |
||
92 | 92 | * Adds a line to the log |
93 | 93 | * |
94 | 94 | * @since 1.19 |
95 | - * @param mixed $str |
|
95 | + * @param string $str |
|
96 | 96 | */ |
97 | 97 | public static function log( $str ) { |
98 | 98 | if ( !self::$enabled ) { |
@@ -470,6 +470,10 @@ discard block |
||
470 | 470 | return $status; |
471 | 471 | } |
472 | 472 | |
473 | + /** |
|
474 | + * @param string $fullCont |
|
475 | + * @param string $dirRel |
|
476 | + */ |
|
473 | 477 | protected function doSecureInternal( $fullCont, $dirRel, array $params ) { |
474 | 478 | $status = Status::newGood(); |
475 | 479 | list( , $shortCont, ) = FileBackend::splitStoragePath( $params['dir'] ); |
@@ -885,7 +889,7 @@ discard block |
||
885 | 889 | |
886 | 890 | /** |
887 | 891 | * @see Iterator::current() |
888 | - * @return string|bool String or false |
|
892 | + * @return string String or false |
|
889 | 893 | */ |
890 | 894 | public function current() { |
891 | 895 | return $this->getRelPath( $this->iter->current()->getPathname() ); |
@@ -377,7 +377,7 @@ |
||
377 | 377 | |
378 | 378 | /** |
379 | 379 | * @see JobQueue::pop() |
380 | - * @return Job|bool |
|
380 | + * @return Job |
|
381 | 381 | */ |
382 | 382 | abstract protected function doPop(); |
383 | 383 |
@@ -302,8 +302,8 @@ |
||
302 | 302 | * @param \WebRequest $request |
303 | 303 | * @param string $key |
304 | 304 | * @param string $prefix |
305 | - * @param mixed $default |
|
306 | - * @return mixed |
|
305 | + * @param boolean $default |
|
306 | + * @return string |
|
307 | 307 | */ |
308 | 308 | protected function getCookie( $request, $key, $prefix, $default = null ) { |
309 | 309 | $value = $request->getCookie( $key, $prefix, $default ); |
@@ -85,6 +85,9 @@ discard block |
||
85 | 85 | unset( $this->db ); |
86 | 86 | } |
87 | 87 | |
88 | + /** |
|
89 | + * @param integer $row |
|
90 | + */ |
|
88 | 91 | public function seek( $row ) { |
89 | 92 | $this->cursor = min( $row, $this->nrows ); |
90 | 93 | } |
@@ -484,7 +487,7 @@ discard block |
||
484 | 487 | |
485 | 488 | /** |
486 | 489 | * This must be called after nextSequenceVal |
487 | - * @return null|int |
|
490 | + * @return integer |
|
488 | 491 | */ |
489 | 492 | function insertId() { |
490 | 493 | return $this->mInsertId; |
@@ -571,6 +574,9 @@ discard block |
||
571 | 574 | return $retVal; |
572 | 575 | } |
573 | 576 | |
577 | + /** |
|
578 | + * @param string $table |
|
579 | + */ |
|
574 | 580 | private function fieldBindStatement( $table, $col, &$val, $includeCol = false ) { |
575 | 581 | $col_info = $this->fieldInfoMulti( $table, $col ); |
576 | 582 | $col_type = $col_info != false ? $col_info->type() : 'CONSTANT'; |
@@ -812,6 +818,9 @@ discard block |
||
812 | 818 | return strtoupper( parent::tableName( $name, $format ) ); |
813 | 819 | } |
814 | 820 | |
821 | + /** |
|
822 | + * @param string $name |
|
823 | + */ |
|
815 | 824 | function tableNameInternal( $name ) { |
816 | 825 | $name = $this->tableName( $name ); |
817 | 826 | |
@@ -1269,6 +1278,9 @@ discard block |
||
1269 | 1278 | return "'" . $this->strencode( $s ) . "'"; |
1270 | 1279 | } |
1271 | 1280 | |
1281 | + /** |
|
1282 | + * @param string $s |
|
1283 | + */ |
|
1272 | 1284 | public function addIdentifierQuotes( $s ) { |
1273 | 1285 | if ( !$this->getFlag( DBO_DDLMODE ) ) { |
1274 | 1286 | $s = '/*Q*/' . $s; |
@@ -1332,7 +1344,7 @@ discard block |
||
1332 | 1344 | * |
1333 | 1345 | * @param array $options An associative array of options to be turned into |
1334 | 1346 | * an SQL query, valid keys are listed in the function. |
1335 | - * @return array |
|
1347 | + * @return string[] |
|
1336 | 1348 | */ |
1337 | 1349 | function makeSelectOptions( $options ) { |
1338 | 1350 | $preLimitTail = $postLimitTail = ''; |
@@ -232,7 +232,7 @@ discard block |
||
232 | 232 | * @param string|bool $group Query group, or false for the generic reader |
233 | 233 | * @param string|bool $wiki Wiki ID, or false for the current wiki |
234 | 234 | * @throws MWException |
235 | - * @return bool|int|string |
|
235 | + * @return string |
|
236 | 236 | */ |
237 | 237 | public function getReaderIndex( $group = false, $wiki = false ) { |
238 | 238 | global $wgDBtype; |
@@ -437,7 +437,7 @@ discard block |
||
437 | 437 | * Returns false if there is no connection open |
438 | 438 | * |
439 | 439 | * @param int $i |
440 | - * @return DatabaseBase|bool False on failure |
|
440 | + * @return DatabaseBase|null False on failure |
|
441 | 441 | */ |
442 | 442 | public function getAnyOpenConnection( $i ) { |
443 | 443 | foreach ( $this->mConns as $conns ) { |
@@ -968,7 +968,7 @@ discard block |
||
968 | 968 | |
969 | 969 | /** |
970 | 970 | * Get the current master position for chronology control purposes |
971 | - * @return mixed |
|
971 | + * @return DBMasterPos |
|
972 | 972 | */ |
973 | 973 | public function getMasterPos() { |
974 | 974 | # If this entire request was served from a slave without opening a connection to the |
@@ -1289,7 +1289,7 @@ discard block |
||
1289 | 1289 | /** |
1290 | 1290 | * Call a function with each open connection object |
1291 | 1291 | * @param callable $callback |
1292 | - * @param array $params |
|
1292 | + * @param string[] $params |
|
1293 | 1293 | */ |
1294 | 1294 | public function forEachOpenConnection( $callback, array $params = [] ) { |
1295 | 1295 | foreach ( $this->mConns as $conns2 ) { |
@@ -1364,7 +1364,7 @@ discard block |
||
1364 | 1364 | * case on many installations. |
1365 | 1365 | * |
1366 | 1366 | * @param IDatabase $conn |
1367 | - * @return int|bool Returns false on error |
|
1367 | + * @return integer Returns false on error |
|
1368 | 1368 | */ |
1369 | 1369 | public function safeGetLag( IDatabase $conn ) { |
1370 | 1370 | if ( $this->getServerCount() == 1 ) { |