BadTitleError::report() - Code Metrics - Inspection of "Daily Inspection: Add rel="noreferrer noopener" wh..." - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (13ece3)

unknown

created 2016-05-20 17:29 UTC

BadTitleError::report() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	8
rs	9.4285
cc	1
eloc	4
nc	1
nop	0

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 * http://www.gnu.org/copyleft/gpl.html
 *
 * @file
 */

/**
 * Show an error page on a badtitle.
 *
 * Uses BadRequestError to emit a 400 HTTP error code to ensure caching proxies and
 * mobile browsers know not to cache it as valid content. (T35646)
 *
 * @since 1.19
 * @ingroup Exception
 */
class BadTitleError extends BadRequestError {
	/**
	 * @param string|Message|MalformedTitleException $msg A message key (default: 'badtitletext'), or
	 *     a MalformedTitleException to figure out things from
	 * @param array $params Parameter to wfMessage()
	 */
	public function __construct( $msg = 'badtitletext', $params = [] ) {
		if ( $msg instanceof MalformedTitleException ) {
			$errorMessage = $msg->getErrorMessage();
			if ( !$errorMessage ) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
				parent::__construct( 'badtitle', 'badtitletext', [] );
			} else {
				$errorMessageParams = $msg->getErrorMessageParameters();
				parent::__construct( 'badtitle', $errorMessage, $errorMessageParams );
			}
		} else {
			parent::__construct( 'badtitle', $msg, $params );
		}
	}
}


1			<?php
2			/**
3			* This program is free software; you can redistribute it and/or modify
4			* it under the terms of the GNU General Public License as published by
5			* the Free Software Foundation; either version 2 of the License, or
6			* (at your option) any later version.
7			*
8			* This program is distributed in the hope that it will be useful,
9			* but WITHOUT ANY WARRANTY; without even the implied warranty of
10			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11			* GNU General Public License for more details.
12			*
13			* You should have received a copy of the GNU General Public License along
14			* with this program; if not, write to the Free Software Foundation, Inc.,
15			* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16			* http://www.gnu.org/copyleft/gpl.html
17			*
18			* @file
19			*/
20
21			/**
22			* Show an error page on a badtitle.
23			*
24			* Uses BadRequestError to emit a 400 HTTP error code to ensure caching proxies and
25			* mobile browsers know not to cache it as valid content. (T35646)
26			*
27			* @since 1.19
28			* @ingroup Exception
29			*/
30			class BadTitleError extends BadRequestError {
31			/**
32			* @param string\|Message\|MalformedTitleException $msg A message key (default: 'badtitletext'), or
33			* a MalformedTitleException to figure out things from
34			* @param array $params Parameter to wfMessage()
35			*/
36			public function __construct( $msg = 'badtitletext', $params = [] ) {
37			if ( $msg instanceof MalformedTitleException ) {
38			$errorMessage = $msg->getErrorMessage();
39			if ( !$errorMessage ) {
			0 ignored issues – show Bug Best Practice introduced 2016-01-16 18:00 UTC by Report Bug Copy Issue Report The expression `$errorMessage` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
40			parent::__construct( 'badtitle', 'badtitletext', [] );
41			} else {
42			$errorMessageParams = $msg->getErrorMessageParameters();
43			parent::__construct( 'badtitle', $errorMessage, $errorMessageParams );
44			}
45			} else {
46			parent::__construct( 'badtitle', $msg, $params );
47			}
48			}
49			}
50

wikimedia / mediawiki

Branch — master (13ece3)

BadTitleError::report() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like