Completed
Branch master (13ece3)
by
unknown
22:07
created

MWOldPassword   A

Complexity

Total Complexity 7

Size/Duplication

Total Lines 24
Duplicated Lines 12.5 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 1
Bugs 0 Features 0
Metric Value
c 1
b 0
f 0
dl 3
loc 24
rs 10
wmc 7
lcom 1
cbo 2

3 Methods

Rating   Name   Duplication   Size   Complexity  
A getDefaultParams() 0 3 1
A getDelimiter() 0 3 1
B crypt() 3 14 5

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * Implements the MWOldPassword class for the MediaWiki software.
4
 *
5
 * This program is free software; you can redistribute it and/or modify
6
 * it under the terms of the GNU General Public License as published by
7
 * the Free Software Foundation; either version 2 of the License, or
8
 * (at your option) any later version.
9
 *
10
 * This program is distributed in the hope that it will be useful,
11
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13
 * GNU General Public License for more details.
14
 *
15
 * You should have received a copy of the GNU General Public License along
16
 * with this program; if not, write to the Free Software Foundation, Inc.,
17
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18
 * http://www.gnu.org/copyleft/gpl.html
19
 *
20
 * @file
21
 */
22
23
/**
24
 * The old style of MediaWiki password hashing. It involves
25
 * running MD5 on the password.
26
 *
27
 * @since 1.24
28
 */
29
class MWOldPassword extends ParameterizedPassword {
30
	protected function getDefaultParams() {
31
		return [];
32
	}
33
34
	protected function getDelimiter() {
35
		return ':';
36
	}
37
38
	public function crypt( $plaintext ) {
39
		global $wgPasswordSalt;
40
41
		if ( $wgPasswordSalt && count( $this->args ) === 1 ) {
42
			$this->hash = md5( $this->args[0] . '-' . md5( $plaintext ) );
43
		} else {
44
			$this->args = [];
45
			$this->hash = md5( $plaintext );
46
		}
47
48 View Code Duplication
		if ( !is_string( $this->hash ) || strlen( $this->hash ) < 32 ) {
49
			throw new PasswordError( 'Error when hashing password.' );
50
		}
51
	}
52
}
53