wikimedia / mediawiki

includes/resourceloader/ResourceLoaderModule.php

Doc Comments +2 added lines, -4 removed lines

@@ -87,7 +87,7 @@ 
 	 * Get this module's name. This is set when the module is registered
 	 * with ResourceLoader::register()
 	 *
-	 * @return string|null Name (string) or null if no name was set
+	 * @return string Name (string) or null if no name was set
 	 */
 	public function getName() {
 		return $this->name;
@@ -208,7 +208,7 @@ 
 	 * MUST return either an only= URL or a non-load.php URL.
 	 *
 	 * @param ResourceLoaderContext $context
-	 * @return array Array of URLs
+	 * @return string[] Array of URLs
 	 */
 	public function getScriptURLsForDebug( ResourceLoaderContext $context ) {
 		$resourceLoader = $context->getResourceLoader();
@@ -410,8 +410,6 @@ 
 	 * This is used to retrieve data in batches. See ResourceLoader::preloadModuleInfo().
 	 * To save the data, use saveFileDependencies().
 	 *
-	 * @param string $skin Skin name
-	 * @param array $deps Array of file names
 	 */
 	public function setFileDependencies( ResourceLoaderContext $context, $files ) {
 		$vary = $context->getSkin() . '|' . $context->getLanguage();

includes/resourceloader/ResourceLoaderWikiModule.php

Doc Comments +2 added lines, -2 removed lines

@@ -135,14 +135,14 @@
 	 * NOTE: This ONLY works for getTitleInfo() and isKnownEmpty(), NOT FOR ANYTHING ELSE.
 	 * In particular, it doesn't work for getContent() or getScript() etc.
 	 *
-	 * @return IDatabase|null
+	 * @return DatabaseBase
 	 */
 	protected function getDB() {
 		return wfGetDB( DB_SLAVE );
 	}
 
 	/**
-	 * @param string $title
+	 * @param string $titleText
 	 * @return null|string
 	 */
 	protected function getContent( $titleText ) {

includes/Revision.php

Doc Comments +10 added lines, -10 removed lines

@@ -423,7 +423,7 @@ 
 	/**
 	 * Return the list of revision fields that should be selected to create
 	 * a new revision.
-	 * @return array
+	 * @return string[]
 	 */
 	public static function selectFields() {
 		global $wgContentHandlerUseDB;
@@ -454,7 +454,7 @@ 
 	/**
 	 * Return the list of revision fields that should be selected to create
 	 * a new revision from an archive row.
-	 * @return array
+	 * @return string[]
 	 */
 	public static function selectArchiveFields() {
 		global $wgContentHandlerUseDB;
@@ -485,7 +485,7 @@ 
 	/**
 	 * Return the list of text fields that should be selected to read the
 	 * revision text
-	 * @return array
+	 * @return string[]
 	 */
 	public static function selectTextFields() {
 		return array(
@@ -496,7 +496,7 @@ 
 
 	/**
 	 * Return the list of page fields that should be selected from page table
-	 * @return array
+	 * @return string[]
 	 */
 	public static function selectPageFields() {
 		return array(
@@ -511,7 +511,7 @@ 
 
 	/**
 	 * Return the list of user fields that should be selected from user table
-	 * @return array
+	 * @return string[]
 	 */
 	public static function selectUserFields() {
 		return array( 'user_name' );
@@ -756,7 +756,7 @@ 
 	/**
 	 * Returns the base36 sha1 of the text in this revision, or null if unknown.
 	 *
-	 * @return string|null
+	 * @return string
 	 */
 	public function getSha1() {
 		return $this->mSha1;
@@ -838,7 +838,7 @@ 
 	/**
 	 * Fetch revision's user id without regard for the current user's permissions
 	 *
-	 * @return string
+	 * @return integer
 	 * @deprecated since 1.25, use getUser( Revision::RAW )
 	 */
 	public function getRawUser() {
@@ -1533,7 +1533,7 @@ 
 	 * Lazy-load the revision's text.
 	 * Currently hardcoded to the 'text' table storage engine.
 	 *
-	 * @return string|bool The revision's text, or false on failure
+	 * @return string The revision's text, or false on failure
 	 */
 	protected function loadText() {
 		// Caching may be beneficial for massive use of external storage
@@ -1734,7 +1734,7 @@ 
 	 *
 	 * @param Title $title
 	 * @param int $id
-	 * @return string|bool False if not found
+	 * @return string|false False if not found
 	 */
 	static function getTimestampFromId( $title, $id, $flags = 0 ) {
 		$db = ( $flags & self::READ_LATEST )
@@ -1790,7 +1790,7 @@ 
 	 * @since 1.20
 	 * @deprecated since 1.24
 	 *
-	 * @param IDatabase|int $db The Database to perform the check on. May be given as a
+	 * @param integer $db The Database to perform the check on. May be given as a
 	 *        Database object or a database identifier usable with wfGetDB.
 	 * @param int $pageId The ID of the page in question
 	 * @param int $userId The ID of the user in question

includes/revisiondelete/RevDelArchivedFileItem.php

Doc Comments +4 added lines

@@ -23,6 +23,10 @@
  * Item class for a filearchive table row
  */
 class RevDelArchivedFileItem extends RevDelFileItem {
+
+	/**
+	 * @param RevDelArchivedFileList $list
+	 */
 	public function __construct( $list, $row ) {
 		RevDelItem::__construct( $list, $row );
 		$this->file = ArchivedFile::newFromRow( $row );

includes/revisiondelete/RevDelFileItem.php

Doc Comments +3 added lines

@@ -26,6 +26,9 @@
 	/** @var File */
 	public $file;
 
+	/**
+	 * @param RevDelFileList $list
+	 */
 	public function __construct( $list, $row ) {
 		parent::__construct( $list, $row );
 		$this->file = RepoGroup::singleton()->getLocalRepo()->newFileFromRow( $row );

includes/revisiondelete/RevDelLogList.php

Doc Comments +3 added lines

@@ -39,6 +39,9 @@
 		return LogPage::DELETED_ACTION;
 	}
 
+	/**
+	 * @param integer $target
+	 */
 	public static function suggestTarget( $target, array $ids ) {
 		$result = wfGetDB( DB_SLAVE )->select( 'logging',
 			'log_type',

includes/revisiondelete/RevDelRevisionItem.php

Doc Comments +3 added lines

@@ -26,6 +26,9 @@
 	/** @var Revision */
 	public $revision;
 
+	/**
+	 * @param RevDelRevisionList $list
+	 */
 	public function __construct( $list, $row ) {
 		parent::__construct( $list, $row );
 		$this->revision = new Revision( $row );

includes/RevisionList.php

Doc Comments +2 added lines, -2 removed lines

@@ -57,7 +57,7 @@ 
 	/**
 	 * Get the internal type name of this list. Equal to the table name.
 	 * Override this function.
-	 * @return null
+	 * @return string
 	 */
 	public function getType() {
 		return null;
@@ -216,7 +216,7 @@ 
 
 	/**
 	 * Get the timestamp in MW 14-char form
-	 * @return mixed
+	 * @return string|false
 	 */
 	public function getTimestamp() {
 		$field = $this->getTimestampField();

includes/Sanitizer.php

Doc Comments +5 added lines, -5 removed lines

@@ -448,7 +448,7 @@ 
 	 *   replacements in HTML attribute values
 	 * @param array|bool $args Arguments for the processing callback
 	 * @param array $extratags For any extra tags to include
-	 * @param array $removetags For any tags (default or extra) to exclude
+	 * @param string[] $removetags For any tags (default or extra) to exclude
 	 * @return string
 	 */
 	public static function removeHTMLtags( $text, $processCallback = null,
@@ -1212,7 +1212,7 @@ 
 	 * character references are decoded to UTF-8 text.
 	 *
 	 * @param string $text
-	 * @return array
+	 * @return callable
 	 */
 	public static function decodeTagAttributes( $text ) {
 		if ( trim( $text ) == '' ) {
@@ -1265,7 +1265,7 @@ 
 	 * Pick the appropriate attribute value from a match set from the
 	 * attribs regex matches.
 	 *
-	 * @param array $set
+	 * @param string[] $set
 	 * @throws MWException When tag conditions are not met.
 	 * @return string
 	 */
@@ -1780,7 +1780,7 @@ 
 
 	/**
 	 * @param string $url
-	 * @return mixed|string
+	 * @return string
 	 */
 	static function cleanUrl( $url ) {
 		# Normalize any HTML entities in input. They will be
@@ -1866,7 +1866,7 @@ 
 	 * @since 1.18
 	 *
 	 * @param string $addr E-mail address
-	 * @return bool
+	 * @return null|boolean
 	 */
 	public static function validateEmail( $addr ) {
 		$result = null;